From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Date: Sun, 28 Feb 2021 15:13:24 +0100 Message-ID: <87h7lwmgaj.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20103"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Matt Armstrong , 46819@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 13:21:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGhXy-00058V-OT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 13:21:10 +0100 Original-Received: from localhost ([::1]:49126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGhXx-0001dX-Qu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 07:21:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGhXq-0001cg-JA for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 07:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGhXq-0006gl-Bp for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 07:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGhXq-0001wD-7n for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 07:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 12:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46819 X-GNU-PR-Package: emacs Original-Received: via spool by 46819-submit@debbugs.gnu.org id=B46819.16146012277365 (code B ref 46819); Mon, 01 Mar 2021 12:21:02 +0000 Original-Received: (at 46819) by debbugs.gnu.org; 1 Mar 2021 12:20:27 +0000 Original-Received: from localhost ([127.0.0.1]:48348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGhXH-0001uj-4f for submit@debbugs.gnu.org; Mon, 01 Mar 2021 07:20:27 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:41590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGhXF-0001uW-89 for 46819@debbugs.gnu.org; Mon, 01 Mar 2021 07:20:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Resent-Message-ID:Resent-Date:Resent-From: Resent-To:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Sender:Resent-Cc:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0+iNIVuKLxpTesliPFzdassHef2LHub7S8sdLuDSeQE=; b=FvoRzgN101LajGGpzKpeIwsPc6 WtDs+tMpb9NHvata3Ul1slq0QM1L63iDkgHLhfED5EFx5r7xezoSsTFEAjcXGRnkUL6RoLyLObvXb gzZzqzbXwATnYMTe2aVT6GxBiu/IRWlV1GwI8LQWb0J+0m9F1iqzks7Z5cwmaRsM45DA=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGhX7-0001i5-A9 for 46819@debbugs.gnu.org; Mon, 01 Mar 2021 13:20:19 +0100 Resent-X-Now-Playing: Siouxsie and the Banshees's _Join Hands_: "The Lords Prayer" Resent-To: 46819@debbugs.gnu.org Resent-From: Lars Ingebrigtsen Resent-Date: Mon, 01 Mar 2021 13:20:16 +0100 Resent-Message-ID: <87sg5f9ibj.fsf@gnus.org> X-From-Line: nobody Sun Feb 28 15:13:28 2021 X-Now-Playing: Boris's _Love_: "Coma" In-Reply-To: (Stefan Monnier's message of "Sat, 27 Feb 2021 16:00:21 -0500") Original-Lines: 18 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201074 Archived-At: Stefan Monnier writes: > It'd be easy to put an explicit nil in the loop's body, but.... > > The idea was that in actual (non-macroexpanded) source code, empty let > bodies are usually the result of a misplaced paren. But it's probably > more often annoying than useful since we can't easily distinguish a "let > from source code" from a "let from a macro expansion". > > So I'm also voting to revert that change. > Any objection? It is a nice and helpful warning, though, so if it could be fixed in another way, that'd be great. (But I have no idea how, of course.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no