From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Tue, 02 Mar 2021 11:38:34 +0000 Message-ID: <87h7ltvl8l.fsf@tcd.ie> References: <87im9fgm27.fsf@protesilaos.com> <83im9814oh.fsf@gnu.org> <87sg6po0yd.fsf_-_@protesilaos.com> <83czxt2fpd.fsf@gnu.org> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> <87r1kyrtrl.fsf@protesilaos.com> <878s75x2uk.fsf@tcd.ie> <603e1b98.1c69fb81.7221b.9c4c@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4705"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Protesilaos Stavrou , 45068@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 12:39:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lH3N4-00016s-Bb for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 12:39:22 +0100 Original-Received: from localhost ([::1]:37264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH3N3-00068F-0a for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 06:39:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH3Mk-000686-Qf for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 06:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40453) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lH3Mk-0002hj-Jt for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 06:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lH3Mk-0003oa-Hv for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 06:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 11:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.161468512514636 (code B ref 45068); Tue, 02 Mar 2021 11:39:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 2 Mar 2021 11:38:45 +0000 Original-Received: from localhost ([127.0.0.1]:51997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH3MT-0003o0-8k for submit@debbugs.gnu.org; Tue, 02 Mar 2021 06:38:45 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:53308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH3MR-0003nk-3W for 45068@debbugs.gnu.org; Tue, 02 Mar 2021 06:38:43 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id e23so1936303wmh.3 for <45068@debbugs.gnu.org>; Tue, 02 Mar 2021 03:38:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kIzV7bFYOFf5NMryJ6oUIOH7vRmcZAxtwC2ecL2GHTM=; b=ZB+1x7UVkl5Z4dnvC6j4eVR/Lx2uGwMM3eAyNQDl7DzVnR38sSrcCQdTUjn6yk03cA kDPMF+xHO/ep7ghPyknxW+hU4A4V3sZd194HxuA61ZYJpDD7+Wsfw1p6FMlhVb/8EqzS XXgwy1eGXFwGTDlfZaBYti2XsulMl2GNR5z78meTFMbOBldLqPWUi8hHmcNq3n+veJM8 6bSxVqo3ud1h4ggtBGZD0SipBkfOiuN/fF2Y0rXS7jgezgNc81kq0p9hFlw0QhCNWjTU kYBVANoZIchdh9bGWUy44p+ML4yKhZWpHUOPtUm69GlzB/U1WX9XV1Q9Z7PmXMVzrU0v DDIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kIzV7bFYOFf5NMryJ6oUIOH7vRmcZAxtwC2ecL2GHTM=; b=Drt4hIFIGPD0yOl24tRFLtEzN6TsgSqpucpWYpgGf/Ey6N1FYu9X9Zf78eAw9Nq0Fg TXkjGShm8Jsy035mS/J1MBZRCKT7FmjuIpdtdDcgjxPD2P9oEurLRPvtC1SyZxqeG/kb a9irqRYWhm8MOK5COTF6GNj7dOh3Bv7rpl4/3uEdSeaN7lqfPMA9tjXXnWK1DZVsAaX3 QK9b4wwPIyMRTno6MEZdHi+XAr3bSheHX9c/ZG68w3J1geaigYtTM3yYb+cSSH/S1DwM 8QRaLghT+WVVdROxTGT53LneMmhXfNoF8EomI7UxZ4VFzFI+I+Ak1EBaBMrTtKaNO9Ay CMag== X-Gm-Message-State: AOAM531fZYYRZ1dE9lYuDCXDuJcc9CCLudcpmKYNl0SsnCKPRzUv5vFJ ie0EZb/iTPlQz5ERBPBKx2SwMg== X-Google-Smtp-Source: ABdhPJzo9W5H9l4sMpx7DaaPNOw/D4BaqdcVNa7zQGgCUlAlgvTru1RVf2eAWMQPKfa/DzNrzwZ1xA== X-Received: by 2002:a1c:28c1:: with SMTP id o184mr3462379wmo.183.1614685117181; Tue, 02 Mar 2021 03:38:37 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id u20sm1237606wru.6.2021.03.02.03.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 03:38:36 -0800 (PST) In-Reply-To: <603e1b98.1c69fb81.7221b.9c4c@mx.google.com> (Mauro Aranda's message of "Tue, 02 Mar 2021 08:03:49 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201208 Archived-At: Mauro Aranda writes: > I'll just say that I raised the question because (usually) theme files > are just settings, so for a user to check the safety it is normally > enough to go through the custom-theme-set-* functions and see what the > theme is setting. Now the user would be asked to check a require-theme > call for its safety, and since a call to require-theme looks a lot like > require, it might not be obvious that it can load (and enable) any theme > it wants. I'm suggesting that require-theme never enables any themes. And to the eyes of the user, it would be no different than a call to require or load, which we already don't warn a second time about. > And if a theme uses require-theme to do that, it can "hide" > the "unsafe theme" settings, because the first element of > custom-enabled-themes will just be the "safe" theme. Sorry, I'm not sure what you mean, could you please elaborate on the steps involved? > Those were my reasons, feel free to ignore them if you think they make > no sense. I doubt that's the case :). Thanks, -- Basil