From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#47493: 27.1; auto-save-file-name-transforms with uniquify should not create invalid filenames Date: Tue, 06 Apr 2021 20:40:29 +0200 Message-ID: <87h7kjxnmq.fsf@gmx.de> References: <877dlpqloo.fsf@delllaptop.lockywolf.net> <87ft0d3wk1.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38113"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47493@debbugs.gnu.org To: Vladimir Nikishkin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 06 20:41:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTqdU-0009nP-Hg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Apr 2021 20:41:12 +0200 Original-Received: from localhost ([::1]:34202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTqdT-0001Yt-Ia for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Apr 2021 14:41:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTqdK-0001WW-AE for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2021 14:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTqdK-00061C-27 for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2021 14:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lTqdJ-0005K3-Rm for bug-gnu-emacs@gnu.org; Tue, 06 Apr 2021 14:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Apr 2021 18:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47493 X-GNU-PR-Package: emacs Original-Received: via spool by 47493-submit@debbugs.gnu.org id=B47493.161773443920414 (code B ref 47493); Tue, 06 Apr 2021 18:41:01 +0000 Original-Received: (at 47493) by debbugs.gnu.org; 6 Apr 2021 18:40:39 +0000 Original-Received: from localhost ([127.0.0.1]:41746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTqcx-0005JA-Hb for submit@debbugs.gnu.org; Tue, 06 Apr 2021 14:40:39 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:46743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTqcv-0005Iv-Or for 47493@debbugs.gnu.org; Tue, 06 Apr 2021 14:40:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1617734430; bh=N4dCBHiF3+VSaH2adaBUAJ/4cGka7E6UoyTaA7lJLK0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=bdWueG9/InoeXjArqjFPeFdKyUetXdmfYv6LSX5ooR1efLAfxGqBP5ATU9SZt2M4W k2hItUudQUXdXmz/JozJe0Zx23QjI6bQ6gSrr5W/miFZ/MII1UMmcjcSXg2pu8H+Oz SJduJ0UuE09myh/cqc+GnCyNx1/0IK29kmQGu1X8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.60.204]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MsHns-1ljia42yvS-00tlx3; Tue, 06 Apr 2021 20:40:30 +0200 In-Reply-To: <87ft0d3wk1.fsf@gmx.de> (Michael Albinus's message of "Tue, 30 Mar 2021 09:55:26 +0200") X-Provags-ID: V03:K1:ADtBfVnxT0iAbNxyVkl2d4kpnjoWeeX4Z+rCqhKT7i2aqhEu5/r YsA6m9p1MgyKAY+tYNF9jOvc7SVV5LuusmJc4OsTQBrXkggVyrf3GiFNr8yX+WVlS26Io3h Mx6Dp/gFIbjS8mSyYVgaTNc6wxzBHYBh24HmajpDLR3iND2cWbkwS2PsfEexYbv/sZTnv2e UCtWHBmipPVeFHM6xkHNQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:edIwN2GnsJU=:sR/9wODlExhs9biHp30EUz +OzQfu9dmjsiIv0F3gG3rU6VTjYDSXh7RP2MamNf0EF6wx3oDq8B6Gz+wbfdAxVKUErr0Pdkk BRHKpzrjDaPIY3Mt2jdnnttfcnvsunXbP32Q0KpRfh/wM344XbTv+SCp/72lNtBiFD/jdyYyR 3dV2LXJLTKxGjn/+dJZtHmLEHA7d00Jq7bOgT73Mpsx2brMommCZutAifyqhI+ZesIrXy+zRi Fc4cCPimXBSa0KdxuKVkjKem4O5L/EP6jwkaGWu7MjwcBOdvQx94Dh6Q8Zz4p3Dquby8J2I22 /VTLfv62JA6zydC+HlRkCuaV92s1mo3cF1zJ7SwqXxVfV4CTSqOB0aiRdiDX4Nol3WESMVjGL hIHSfPULPay+9W0vHxqWZkQiEaGRX34NP5iNTIYkMFKu/EoheIUCBKX8o+qRToEQChIHILamB ZUQf8/Vo/NAp6T9ERAUQWDGIZWTWpgPHBs17sFdmE4sMo6yWqDFtUKvKVcz9wRNAyI7xAW/o8 sak9AQ+1BuZdVeOM2kchAxZM58sjJ6eVpZc5ZmasFBsvmoh8JCXd4hirFf/VQVgcwVuwAIptZ YGKL0AgwVfiLFJt0F8YMwEiE0kOs5G6IFK7O4czF6+zSW19BwQsLLzrMOx5KsEycIK4gNGrZs KdPZDKsTpRgDzbIbzu2CFdDNAMJQmdN40BSy6/wxD1dqYCQkmX4nio/c+GvyQnqbO2/vuLdRh /SPKOY9YbXMuIempBRrqaoBssg6JzD2scnm+f3H6/6JIpfEQ1BNIvm2cMeXXamYfLFBv3O2f X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203647 Archived-At: --=-=-= Content-Type: text/plain Michael Albinus writes: Hi, >> Would it be possible, to, maybe, add a flag "ensure-filesystem-correctness"? > > Maybe we could have a flag which means "convert the directory part of a > file name into sha1" (or whatever `secure-hash' provides). Nobody has commented. Well, in a couple of days I will push the appended patch, unless there are objections. >> Your sincerely, >> Vladimir Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable *** /tmp/ediffH8hUs7 2021-04-06 20:36:48.215610320 +0200 =2D-- /home/albinus/src/emacs/lisp/files.el 2021-04-06 20:36:13.439660165 = +0200 *************** *** 392,397 **** =2D-- 392,403 ---- changed to `!' to prevent clashes. This will not work correctly if your filesystem truncates the resulting name. + If the optional element UNIQUIFY is a symbol returned by function + `secure-hash-algorithms', the auto-save file name is constructed + by taking the directory part of the replaced file-name, + concatenated with the buffer file name run through `secure-hash' + instead. This returns a valid name for your filesystem any way. + All the transforms in the list are tried, in the order they are listed. When one transform applies, its result is final; no further transforms are tried. *************** *** 6593,6606 **** uniq (car (cddr (car list))))) (setq list (cdr list))) (if result ! (if uniq ! (setq filename (concat ! (file-name-directory result) ! (subst-char-in-string ! ?/ ?! ! (replace-regexp-in-string "!" "!!" ! filename)))) ! (setq filename result))) (setq result (if (and (eq system-type 'ms-dos) (not (msdos-long-file-names))) =2D-- 6599,6618 ---- uniq (car (cddr (car list))))) (setq list (cdr list))) (if result ! (setq filename ! (cond ! ((member uniq (secure-hash-algorithms)) ! (concat ! (file-name-directory result) ! (secure-hash uniq filename))) ! (uniq ! (concat ! (file-name-directory result) ! (subst-char-in-string ! ?/ ?! ! (replace-regexp-in-string ! "!" "!!" filename)))) ! (t result)))) (setq result (if (and (eq system-type 'ms-dos) (not (msdos-long-file-names))) --=-=-=--