From: Michael Albinus <michael.albinus@gmx.de>
To: Andrea Corallo <akrl@sdf.org>
Cc: 48031@debbugs.gnu.org
Subject: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 18:16:49 +0200 [thread overview]
Message-ID: <87h7jtkolq.fsf@gmx.de> (raw)
In-Reply-To: <xjfk0op5a17.fsf@sdf.org> (Andrea Corallo's message of "Mon, 26 Apr 2021 15:40:36 +0000")
Andrea Corallo <akrl@sdf.org> writes:
> Hi Michael,
Hi Andrea,
> as of 9d34fd8b33 both issues should be solved, could you have a look if
> it works for you too?
LGTM.
Btw, in ert-x.el we have the macros `ert-resource-directory' and
`ert-resource-file'.
--8<---------------cut here---------------start------------->8---
(defconst comp-test-directory (concat (file-name-directory
(or load-file-name
buffer-file-name))
"comp-tests-resources/"))
--8<---------------cut here---------------end--------------->8---
could be
--8<---------------cut here---------------start------------->8---
(defconst comp-test-directory (ert-resource-directory)
--8<---------------cut here---------------end--------------->8---
(or just be removed), and
--8<---------------cut here---------------start------------->8---
(defconst comp-test-src
(expand-file-name "comp-test-funcs.el" comp-test-directory))
--8<---------------cut here---------------end--------------->8---
could be
--8<---------------cut here---------------start------------->8---
(defconst comp-test-src (ert-resource-file "comp-test-funcs.el")
--8<---------------cut here---------------end--------------->8---
etc pp.
> Thanks for reporting, regards
>
> Andrea
Best regards, Michael.
PS: Could you, pls, introduce tag :nativecomp in test/README? Thanks.
next prev parent reply other threads:[~2021-04-26 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 9:37 bug#48031: 28.0.50; comp-tests oddities Michael Albinus
2021-04-26 9:45 ` Michael Albinus
2021-04-26 15:40 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-26 16:16 ` Michael Albinus [this message]
2021-04-26 16:46 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-26 17:30 ` Michael Albinus
2021-04-26 18:07 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-26 19:12 ` Michael Albinus
2021-04-26 20:13 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7jtkolq.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=48031@debbugs.gnu.org \
--cc=akrl@sdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).