From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gustavo Barros Newsgroups: gmane.emacs.bugs Subject: bug#48472: [FR] A small suggestion for repeat-mode Date: Tue, 18 May 2021 19:09:37 -0300 Message-ID: <87h7izn17i.fsf@gmail.com> References: <87bl9atpen.fsf@gmail.com> <871ra5xalk.fsf@mail.linkov.net> <87o8d847ls.fsf@gmail.com> <87a6orwy6x.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23748"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 27.2 Cc: 48472@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 19 00:10:35 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj7v9-0005yb-8U for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 May 2021 00:10:35 +0200 Original-Received: from localhost ([::1]:53110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj7v8-00008b-Bq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 18:10:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj7ug-00006d-RI for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 18:10:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45974) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lj7ub-00038F-Rm for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 18:10:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lj7ub-00079m-JO for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 18:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gustavo Barros Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 May 2021 22:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 48472-submit@debbugs.gnu.org id=B48472.162137578927488 (code B ref 48472); Tue, 18 May 2021 22:10:01 +0000 Original-Received: (at 48472) by debbugs.gnu.org; 18 May 2021 22:09:49 +0000 Original-Received: from localhost ([127.0.0.1]:57520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj7uP-00079I-Fw for submit@debbugs.gnu.org; Tue, 18 May 2021 18:09:49 -0400 Original-Received: from mail-qv1-f49.google.com ([209.85.219.49]:37401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj7uN-000794-GD for 48472@debbugs.gnu.org; Tue, 18 May 2021 18:09:48 -0400 Original-Received: by mail-qv1-f49.google.com with SMTP id z1so5807958qvo.4 for <48472@debbugs.gnu.org>; Tue, 18 May 2021 15:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:references:user-agent:from:to:cc:subject:in-reply-to :message-id:date:mime-version; bh=A9nrSN7Ho3xTo8vyIG+O2ttT9AYJJ8PDR8OdZ+6JT+Q=; b=QU1cLUeAwKSk6zBHN8hLbnRtJhWCQT/MtC3aQMBx3eaPuXAZemBCuPIQC4Djx1/Cbu IP/P5YRMhXZKqXOg9U/ClNQF7Ax4LLTecIalqm25jDypANyArCvsdsd+X0w1mohtSyqO HiQajJK11aZqAVOGSUvwGEV+p/W5DLaPx+QrONwvnsQp06vwRUYWASsAEoiK74N6FlT8 5SYMay7FF3FY3Hl5bMjDJwQbz/ofZqp7O77dReW6YBiBl23/MAQh/tYOKHAKOg2m0gjS G8KqMyPiK3cOmIZGMC0vxiT9wwVmynGFKX41vK/uBQtLZKtE4shrh7OZqxtUOxatFA/3 bMIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=A9nrSN7Ho3xTo8vyIG+O2ttT9AYJJ8PDR8OdZ+6JT+Q=; b=slXK9xJwX1g9nWSvuuVBGAYy8r7o+Z2ygbIGwy9wPhUEEe5hxAtpYll3YGKWVY/z/G Tl3Lse2HOilGy2BxS3dznty3CRFSHkSCQzdYP1szNy05E8Ti5tn42+Ua9W0NSq8YAzPq E/VnuI69KoJ9pKZGTRcZWgJDQgrj0BqxaLQXqJkHQUO1FBlLcXTEqsaoq2pAapOslVnl /pd1jCDQKASsxeluT7TRvFkeO0e1groA5k7ZOvb9u4zME81mwpxtDEFUyKBrETR1qq+n OxBzUqy7wpaCYj4H3Qeiv7Gi3mIjLJjpg10OE3qg2KjgksPWNV/DwY7T2XDgzIkuUlX/ edkA== X-Gm-Message-State: AOAM531r3/5sSAU1TLbSimXRuLH/aAUSb9TxbyTfo1h9+GmKatcfvUWH 5Y2t1Mthqr9ZrwYvIHXbF2frzWRfAIo= X-Google-Smtp-Source: ABdhPJyOM5XJGZFXxEykIp9hOcD0jMHE8T8SsuC5BxeXpKhCVzxdCGq+aGSbhPW48WBC8t5RvGdA1g== X-Received: by 2002:ad4:5ca2:: with SMTP id q2mr8511521qvh.49.1621375781608; Tue, 18 May 2021 15:09:41 -0700 (PDT) Original-Received: from gusbrs-laptop ([143.244.35.87]) by smtp.gmail.com with ESMTPSA id d28sm13478651qkl.105.2021.05.18.15.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 15:09:40 -0700 (PDT) In-reply-to: <87a6orwy6x.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206843 Archived-At: Hi Juri, On Tue, 18 May 2021 at 18:04, Juri Linkov wrote: > It's amazing that the function returns exactly what we need > even though its return value is not yet used anywhere. > So I copied the same design to another similar function > display-buffer-override-next-command to return exitfun as well. Indeed it is pretty cool, nice that it has fulfilled its purpose and even "reproduced". > You are welcome to sign papers, so the next time you could offer a > patch. Well, I'd love to, and have tried to, but it turns out I can't sign them. > Now I pushed the implementation based on your suggestion, thanks for > it! > > (The implementation also includes a lot of small details like > correctly > handling the messages, etc.) I thank you! And I had assumed the timer would have to be stored and canceled at every repeat, and also that somehow the message would have to be cleared when the exit function timer ran. I see you handled all that. Looks good to me. > If you are running on 27.2, you could still take the second part > of repeat.el from Emacs 28. I might! :-) But if you push me to you it, you run the risk of getting yet other "small suggestions". Thanks again! Gustavo.