From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Sun, 29 Aug 2021 19:44:50 +0300 Organization: LINKOV.NET Message-ID: <87h7f8dzm5.fsf@mail.linkov.net> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> <87k0lildtq.fsf@gnus.org> <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> <877dgoutmz.fsf@gnus.org> <2602aeaf-0f02-e744-2b4f-012e73e012e8@yandex.ru> <87y28nbky4.fsf@linkov.net> <9fa4e453-9f8b-9c2b-b3d3-76bb656d6ad5@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27244"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 29 18:56:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKO6Q-0006wY-11 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Aug 2021 18:56:14 +0200 Original-Received: from localhost ([::1]:36132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKO6O-0003MA-0G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Aug 2021 12:56:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKO6F-0003G9-0W for bug-gnu-emacs@gnu.org; Sun, 29 Aug 2021 12:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45742) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKO6E-0000ag-OJ for bug-gnu-emacs@gnu.org; Sun, 29 Aug 2021 12:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKO6E-0003RX-NQ for bug-gnu-emacs@gnu.org; Sun, 29 Aug 2021 12:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Aug 2021 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.163025610713095 (code B ref 39452); Sun, 29 Aug 2021 16:56:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 29 Aug 2021 16:55:07 +0000 Original-Received: from localhost ([127.0.0.1]:57269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKO5K-0003P9-MX for submit@debbugs.gnu.org; Sun, 29 Aug 2021 12:55:06 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:55991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKO5I-0003OX-Cs for 39452@debbugs.gnu.org; Sun, 29 Aug 2021 12:55:05 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 9B7301BF203; Sun, 29 Aug 2021 16:54:55 +0000 (UTC) In-Reply-To: <9fa4e453-9f8b-9c2b-b3d3-76bb656d6ad5@yandex.ru> (Dmitry Gutov's message of "Sun, 29 Aug 2021 03:18:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212938 Archived-At: >> Would be great to add some test, though. vc-tests.el currently doesn't >> exercise vc-rename-file at all. > > Just added the tests for vc-rename-file. Thanks, I tried to run the test, but it fails: Test vc-test-rcs05-rename-file condition: (ert-test-failed ((should (equal (vc-state new-name) 'added)) :form (equal up-to-date added) :value nil :explanation (different-atoms up-to-date added))) FAILED 12/12 vc-test-rcs05-rename-file Another question: after removing vc-git--literal-pathspecs from vc-git-rename-file, does this mean that vc-git-rename-file now doesn't support literal paths? Maybe it could be possible to fix vc-git--literal-pathspecs to support relative literal paths for vc-git-rename-file?