From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Andr=C3=A9?= A. Gomes Newsgroups: gmane.emacs.bugs Subject: bug#50852: [PATCH] Fix search of the look program. Date: Tue, 28 Sep 2021 11:41:38 +0300 Message-ID: <87h7e56qil.fsf@gmail.com> References: <87wnn17t85.fsf@gmail.com> <8335ppkzc1.fsf@gnu.org> <87ilylfcvt.fsf@gnus.org> <83v92ljhmt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10735"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: Lars Ingebrigtsen , 50852@debbugs.gnu.org, stefan@marxist.se To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 28 10:42:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mV8gy-0002cM-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 10:42:24 +0200 Original-Received: from localhost ([::1]:56408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mV8gx-0003X5-MG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 04:42:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mV8gd-0003VZ-Bf for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 04:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60417) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mV8gc-0003UA-9J for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 04:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mV8gc-0005kD-59 for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 04:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Andr=C3=A9?= A. Gomes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Sep 2021 08:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 50852-submit@debbugs.gnu.org id=B50852.163281850822061 (code B ref 50852); Tue, 28 Sep 2021 08:42:02 +0000 Original-Received: (at 50852) by debbugs.gnu.org; 28 Sep 2021 08:41:48 +0000 Original-Received: from localhost ([127.0.0.1]:43730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV8gO-0005jl-BB for submit@debbugs.gnu.org; Tue, 28 Sep 2021 04:41:48 -0400 Original-Received: from mail-lf1-f54.google.com ([209.85.167.54]:36641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV8gM-0005jX-G6 for 50852@debbugs.gnu.org; Tue, 28 Sep 2021 04:41:47 -0400 Original-Received: by mail-lf1-f54.google.com with SMTP id b20so89767698lfv.3 for <50852@debbugs.gnu.org>; Tue, 28 Sep 2021 01:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5y1Ki3abDZixWNmu0jElURgPhYnWD4VvCwmiPS1weUU=; b=OpEUiJZMIhBg+58mFdquhSo3CDAGNAnzQH1BRJ8zAa4CjDtrKpjEja/6YlHj/AMI5g UKeiqLSGsiKOntHF7SUzlMtitMVUETqAXe4FLCDuiaQb9I67zadq7aWBO4nhYspfm45c Uj2jeNoDDXMRPnk/DUsITrb3xJ4+Zx2dhnFpPc0NCWpxuSb11tTLIVPA+/RDnpGIgG5i JyLxfbYFNFpMJww7ANPyXQIKDt/R29El74sC6pNIsYHBfA9u91c6Z6fm/4j4PAqy7PL3 zd17agGH1g6LkNFxNo3+lbIYzhqusOrwJ7dpv+segFR3hYY04FE3bIaSVTy03XQVWe/G Bopw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5y1Ki3abDZixWNmu0jElURgPhYnWD4VvCwmiPS1weUU=; b=adqHieVHjpkHWeZD9LXbZoL69BhO16wKMnkvgm9mZA/FtudAtPwTUrqlPcHKTx2HPz aZZKCknGwcI0BS+DMkNPrwrOfdwDo+JRnlSHo2yEpZCrGBTPnfFREYEaYXZB0KmiCoGF cB55A+2goB7z/ecJc4nIcvojXS4RyuRKC+VOMR4lHLARfTGMeQpUDsQvhFrf11ZtngG5 MWxegpMso3GR5gNbt7q1vACcbZvHmJDLMwd2Z+hfr/6TQDM6QscaHfLvBR7WYb82R5e8 Bbh8uDrlkMFGobdT7rXT/6SOxgVkBqsZnuPX3dFqDZSbeERQO+eZ9OCtOT5wzI2IU1Z0 tKJQ== X-Gm-Message-State: AOAM530//A2Rv19Jaf7l6unJqC/MEXtcrJbottkPTrmPBbxBVUI1co7I m5KhZyxM0nleL/KsSpaI60TScuiVQxw= X-Google-Smtp-Source: ABdhPJxGYJzBRoz9SBn8JuqBd3srF4xRPtBtsDUKel8nDlYgrtz09p6gtozP++hQ7McvR9MBWCLvUw== X-Received: by 2002:ac2:54a6:: with SMTP id w6mr4442965lfk.510.1632818500401; Tue, 28 Sep 2021 01:41:40 -0700 (PDT) Original-Received: from guix-xps13 (95-29-46-147.broadband.corbina.ru. [95.29.46.147]) by smtp.gmail.com with ESMTPSA id t17sm1840655lft.296.2021.09.28.01.41.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 01:41:40 -0700 (PDT) In-Reply-To: <83v92ljhmt.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Sep 2021 10:15:06 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215758 Archived-At: Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> Cc: Stefan Kangas , andremegafone@gmail.com, >> 50852@debbugs.gnu.org >> Date: Tue, 28 Sep 2021 08:11:18 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> > In this case, why not simply have the value as "look" with no leading >> > directories? If the program is installed, it will be found when it's >> > invoked, and if it isn't installed, the user gets an error message at >> > that time. >>=20 >> That's a good point. And the ispell-look-p variable is itself rather >> odd -- why have both ispell-look-command and that variable (with a >> non-standard name)? > > Right. The existence of "look" should IMO be tested as part of > ispell-lookup-words, not when the package loads. Then the command > could decide whether to use "look" or Grep at that time, and the need > for the ispell-look-p variable would disappear. You're both right. I was actually silly. I can prepare a patch following these ideas. --=20 Andr=C3=A9 A. Gomes "Free Thought, Free World"