From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alexandre Duret-Lutz Newsgroups: gmane.emacs.bugs Subject: bug#50749: 28.0.50; three gnus-icalendar issues w.r.t. RFC5546 and party crashers Date: Fri, 01 Oct 2021 17:39:47 +0200 Message-ID: <87h7e0da9o.fsf@lrde.epita.fr> References: <87czozag28.fsf@lrde.epita.fr> <875yurvu6d.fsf@gnus.org> <877df69773.fsf@lrde.epita.fr> <87lf3ltre9.fsf@gnus.org> <87v92hcg8x.fsf@lrde.epita.fr> <874ka1x7or.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38952"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 50749@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 01 17:52:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWKpe-0009tH-V0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Oct 2021 17:52:18 +0200 Original-Received: from localhost ([::1]:46858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWKpc-0000Y7-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Oct 2021 11:52:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWKdm-0001Ym-QF for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 11:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWKdm-0004An-Gb for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 11:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWKdm-0001VS-BU for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 11:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alexandre Duret-Lutz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Oct 2021 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50749 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50749-submit@debbugs.gnu.org id=B50749.16331028005764 (code B ref 50749); Fri, 01 Oct 2021 15:40:02 +0000 Original-Received: (at 50749) by debbugs.gnu.org; 1 Oct 2021 15:40:00 +0000 Original-Received: from localhost ([127.0.0.1]:57153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWKdj-0001Ut-Qr for submit@debbugs.gnu.org; Fri, 01 Oct 2021 11:40:00 -0400 Original-Received: from smtp.lrde.epita.fr ([91.243.117.225]:33892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWKde-0001UY-DD for 50749@debbugs.gnu.org; Fri, 01 Oct 2021 11:39:58 -0400 Original-Received: from goulash (goulash.lrde.epita.fr [192.168.101.25]) by smtp.lrde.epita.fr (Postfix) with ESMTPSA id C251D43427; Fri, 1 Oct 2021 17:39:47 +0200 (CEST) In-Reply-To: <874ka1x7or.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 01 Oct 2021 14:15:16 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216061 Archived-At: Lars Ingebrigtsen writes: > I forgot to check whether there were any test regressions. Sorry, I should have known better a looked for that. > gnus-icalendar-parse fails, but the following change makes it pass. > > I'm not very familiar with this code -- was this change intended? > > diff --git a/test/lisp/gnus/gnus-icalendar-tests.el b/test/lisp/gnus/gnus-icalendar-tests.el > index 90c3a34a5c..61fe9701fe 100644 > --- a/test/lisp/gnus/gnus-icalendar-tests.el > +++ b/test/lisp/gnus/gnus-icalendar-tests.el > @@ -103,7 +103,7 @@ gnus-icalendar-parse > (should (string= (format-time-string "%Y-%m-%d %H:%M" end-time) "2020-12-08 16:00")) > (should (string= uid "iipdt88slddpeu7hheuu09sfmd@google.com")) > (should (not rsvp)) > - (should (eq participation-type 'non-participant)))) > + (should (eq participation-type 'required)))) > (setenv "TZ" tz)))) Reading the test case, it looks like an event that does not list any attendee. So I'd expect 'non-participant. Looks my third patch is wrong then. In (let* (... (role (or (plist-get (cadr attendee) 'ROLE) "REQ-PARTICIPANT")) I meant to set REQ-PARTICIPANT only when the attendee list is non-empty but the 'ROLE property is not found (= I have been listed as an attendee of the event without being given a role). But the above code will set REQ-PARTICIPANT even if attendee is empty (= I'm not listed, as in the test case). Let me learn from my mistake and see if I can find how to run these tests and add a test case for for what I intended to fix.