From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51173: 28.0.60; gnus-article-describe-key doesn't work Date: Wed, 13 Oct 2021 20:24:42 +0300 Organization: LINKOV.NET Message-ID: <87h7dkx2g5.fsf@mail.linkov.net> References: <87h7dl6spg.fsf@gnus.org> <87r1cox4th.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19433"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Katsumi Yamaoka , Stefan Monnier , 51173@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 13 19:34:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mai99-0004wa-QX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Oct 2021 19:34:31 +0200 Original-Received: from localhost ([::1]:36690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mai98-00035K-Pl for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Oct 2021 13:34:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mai8h-0002fs-44 for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2021 13:34:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mai8g-0000WQ-RX for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2021 13:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mai8g-0001hn-Hw; Wed, 13 Oct 2021 13:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 13 Oct 2021 17:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51173 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 51173-submit@debbugs.gnu.org id=B51173.16341463966413 (code B ref 51173); Wed, 13 Oct 2021 17:34:02 +0000 Original-Received: (at 51173) by debbugs.gnu.org; 13 Oct 2021 17:33:16 +0000 Original-Received: from localhost ([127.0.0.1]:33303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mai7w-0001fN-EA for submit@debbugs.gnu.org; Wed, 13 Oct 2021 13:33:16 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:57019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mai7u-0001ev-Cr for 51173@debbugs.gnu.org; Wed, 13 Oct 2021 13:33:15 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id E530324000A; Wed, 13 Oct 2021 17:33:04 +0000 (UTC) In-Reply-To: <87r1cox4th.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 13 Oct 2021 19:33:30 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217153 Archived-At: > I think this is mea culpa - commit 2d1564103e. > It was changed to handle context menu clicks > in the displayed window. This patch should handle only mouse events specially: diff --git a/lisp/help.el b/lisp/help.el index fa4eaee417..956a3d0d32 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -699,7 +699,10 @@ help--analyze-key ;; is selected from the context menu that should describe KEY ;; at the position of mouse click that opened the context menu. ;; When no mouse was involved, it defaults to window-point. - (defn (save-excursion (mouse-set-point event) (key-binding key t)))) + (defn (if (consp event) + (save-excursion + (mouse-set-point event) (key-binding key t)) + (key-binding key t)))) ;; Handle the case where we faked an entry in "Select and Paste" menu. (when (and (eq defn nil) (stringp (aref key (1- (length key)))) --