From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack Date: Mon, 25 Oct 2021 20:05:33 +0300 Organization: LINKOV.NET Message-ID: <87h7d5xcf6.fsf@mail.linkov.net> References: <06080F99-49F3-4936-A39A-D135F5ECCEE2@acm.org> <0c88bcef-f07d-5a38-fa7d-b0ddd048cb48@yandex.ru> <072CF8C3-2ADC-4610-A7E1-94C795A22618@acm.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3942"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Dmitry Gutov , yyoncho , 38797@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 25 19:09:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mf3TV-0000uR-Vw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Oct 2021 19:09:29 +0200 Original-Received: from localhost ([::1]:36512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mf3TU-0002OL-2N for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Oct 2021 13:09:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mf3T4-0001gz-GE for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 13:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mf3T4-0004aC-7x for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 13:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mf3T4-0002qQ-3d for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 13:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Oct 2021 17:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38797-submit@debbugs.gnu.org id=B38797.163518170310872 (code B ref 38797); Mon, 25 Oct 2021 17:09:02 +0000 Original-Received: (at 38797) by debbugs.gnu.org; 25 Oct 2021 17:08:23 +0000 Original-Received: from localhost ([127.0.0.1]:44159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf3SR-0002p7-Bv for submit@debbugs.gnu.org; Mon, 25 Oct 2021 13:08:23 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:51981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mf3SN-0002oi-1t for 38797@debbugs.gnu.org; Mon, 25 Oct 2021 13:08:20 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id EEEC0240008; Mon, 25 Oct 2021 17:08:10 +0000 (UTC) In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 25 Oct 2021 17:49:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218324 Archived-At: >> LGTM, please install. > > Thank you Dmitry, now pushed to master. I took a look at your change, and noticed an asymmetry between the names xref-pop-marker-stack and xref-go-forward. Shouldn't the name xref-pop-marker-stack be obsoleted, and replaced with a new name xref-go-back? (I see now that you added FIXME for this.) Another question is that in the menu bar currently the order is "Forward" and "Back". But more natural order would be "Back" and "Forward". > Juri, would you help out with adding (or not) `xref-go-forward` to the > context menu? I wasn't sure if we had agreed on good names for this and the > go-back entries. The current "Back Definition" is a bit nonsensical in > English. I completely agree that the current title is inappropriate. > I favour (lightly) "Go Back" / "Go Forward" because they make sense in > context with the other Xref operations in that separator-delimited group of > entries in the menu, and because it's a wording often used for these > operations elsewhere such as in web browsers and IDEs (though often it's > just "Back" and "Forward"). > > "Xref {Back,Forward}" or "{Back,Forward} Xref" would also do and displays > the link to Xref up front, but the English is decidedly less natural. With such a test case: 0. emacs -Q 1. click mouse-3 on any word in *scratch*, and select from the context menu "Find Definition". It should fail with the error "No definitions found for: This". This is correct. 2. now click mouse-3 at the end of *scratch*, not on a word. The menu contains the item "Back Definition". (BTW, why if the search failed?) This menu item is too ambiguous. Renaming it to "Go Back" or "Go Forward" doesn't make the menu item clearer. Only adding a word "Xref" somewhere will disambiguate it. Maybe then "Go Back in Xref" or "Go Back with Xref"? We need more opinions.