From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45226: Avoid redundant calls in narrow-to-defun Date: Thu, 11 Nov 2021 06:57:59 +0100 Message-ID: <87h7cj8c9k.fsf@gnus.org> References: <87mtyhwozr.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32598"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 45226@debbugs.gnu.org To: Tomas Nordin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 07:03:36 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml3BQ-0008If-7c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 07:03:36 +0100 Original-Received: from localhost ([::1]:43610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml3BO-0005es-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 01:03:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml371-00010X-7I for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 00:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml370-0003BD-1T for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 00:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ml36z-0007BN-PY for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 00:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 05:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45226 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45226-submit@debbugs.gnu.org id=B45226.163661029227534 (code B ref 45226); Thu, 11 Nov 2021 05:59:01 +0000 Original-Received: (at 45226) by debbugs.gnu.org; 11 Nov 2021 05:58:12 +0000 Original-Received: from localhost ([127.0.0.1]:39912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml36C-0007A2-Bp for submit@debbugs.gnu.org; Thu, 11 Nov 2021 00:58:12 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:50362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml369-00079m-Sv for 45226@debbugs.gnu.org; Thu, 11 Nov 2021 00:58:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Xt6lbREewBUr0mg1pmrT7JwidasG4yKaHfv9AceII7Q=; b=XyrITCahHtOQ8C6PE7CGNrT/eI iUdwokCnSh79N7dWlYpG1Y5kajmi9q6tQr+fSY95pvtujhbvSCUaWpPCi+BEWM8jbfERjQPvFLRHH qDIrQ4UqBTf2WvMjJ5S/EP0I/SQtVjlOEX/F+va+w21y2vSpFhXxB3MxfJoYvcoRB6rc=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml360-0002u4-DP; Thu, 11 Nov 2021 06:58:03 +0100 X-Now-Playing: Moor Mother's _Black Encyclopedia of the Air_: "Mangrove (feat. Elucid & Antonia Gabriela)" In-Reply-To: <87mtyhwozr.fsf@posteo.net> (Tomas Nordin's message of "Sun, 13 Dec 2020 19:16:24 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219597 Archived-At: Tomas Nordin writes: > `narrow-to-defun' fixup > > * emacs-lisp/lisp.el (narrow-to-defun): `beginning-of-defun' goes > to previous function when point is on the first character of a > function. Take care of that in `narrow-to-defun'. > [...] > With the attached patch I suggest a partial revert of the above commit, > keeping only the forward-char service. I have been experimenting with it > a lot and see no problem. I made 'make check' and see no failures FWIW. > As a bonus, in combination with a patch I submitted with bug#40563, > python nested defuns can be narrowed. > > What do you think, maybe I am missing something. Or do you agree the > check and the additional call is redundant? I think the use case is if you have a language where you can define several function definitions on the same line. Like something like: (defun foo ())(defun bar ())(defun zot ()) Unfortunately the original bug report didn't have a case for reproduction, so I don't know what the language in question where the problem may have been in. (There should have been a test case, of course.) (And in Emacs Lisp, this doesn't work anyway) So I'd prefer not to revert the change (it's a defensive change), unless we know what it's not really doing anything useful. So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no