From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52593: 28.0.90; (thing-at-point thing) has so much overhead since commit 7db376e560448e61485ba054def8c82b21f33d6a Date: Sun, 19 Dec 2021 15:44:29 +0100 Message-ID: <87h7b4u01e.fsf@gnus.org> References: <83zgoybbfr.fsf@gnu.org> <83ee689156.fsf@gnu.org> <878rwgra3k.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25447"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52593@debbugs.gnu.org To: Kang Niu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 19 15:45:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myxR5-0006Pp-TW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 15:45:15 +0100 Original-Received: from localhost ([::1]:52100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myxR4-0003WE-3a for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 09:45:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myxQs-0003VI-Mr for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 09:45:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myxQs-0002Fd-Ex for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 09:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myxQs-0008My-Aq for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 09:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Dec 2021 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52593 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 52593-submit@debbugs.gnu.org id=B52593.163992508232120 (code B ref 52593); Sun, 19 Dec 2021 14:45:02 +0000 Original-Received: (at 52593) by debbugs.gnu.org; 19 Dec 2021 14:44:42 +0000 Original-Received: from localhost ([127.0.0.1]:45350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myxQY-0008M0-Ik for submit@debbugs.gnu.org; Sun, 19 Dec 2021 09:44:42 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:42838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myxQW-0008Ll-Ht for 52593@debbugs.gnu.org; Sun, 19 Dec 2021 09:44:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qNyGJthKTGEYjK5PVcQo+NMJ9LnalRxO+wFrOae1/Vg=; b=HfgzcGcSNprsD5lsFTlHFGLxnN i7zbPnx9UK5RHq9eGZa56t/Yx2nqSUPqwXqeYLFUs7/86m94bwZ4WAPYCIPsi9J7yABN2AP6pdcKf 4fXIKHpYw4u2vCJOwFBqACLrpMG6/k2A5HfCcAvrLieB9JK9IJnoNODPWZBEw7jCoPdo=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myxQN-0004Wt-MR; Sun, 19 Dec 2021 15:44:34 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXt9Ni5w6KIknZR Tkn///+5aDmTAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UMEw4rBpiMQLcAAAGjSURBVDjLbZOBkcQg CEUl24CwDQRs4CL993YfMW7cOzKTmfAE5ENKCeOwWv4YMZsOBGiPA8xiwky1aKFaC8H1AQZA+Nbx plUCgFVZ+cAZIv4APGqiVcSM9bqLR+lKqFIUVUTPda2ve95XG03k17jzfqpdeZh2P0vrmXVFRH5R 0Qnw3JXh7x0g1KClGuGSSG8mLjWbqutm0lTM+4z4SEsCcd29j7ZoAeHm9ga46t3SAJiEwZr7SCXn Aia9eWc306c8ZAO4uWsfmW2G9A6fO4KKR4Kllcf5KF0Oz3HOXGY+Qs7yDoApawKxzFVLcygbmiR4 e6ZSa1rDd8wiBwr38Md3JcxchmiFoEWDumhMThYRpZzlESqNVNZ+cjz1TjWsQ5Wr3EuYqYZBsQHO J7hktN40tZtB0RzllWPqbLxAh7AD2HNS0ATjS+D1CbDFPrv3bQulYRHcppIPOwJwgp8NeNM5kx28 vNXZ5J8IRkQ8fu3AYm9fOd/nj+F2No5F6a7br+HWrthEl2470FbRpeFX2Bos7RpL+uWNdejFvv/b BFr+N/rH9ws+hkt2nuNQ0QAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0xMi0xOVQxNDo0MzowNisw MDowMDUyjEMAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTItMTlUMTQ6NDM6MDYrMDA6MDBEbzT/ AAAAAElFTkSuQmCC X-Now-Playing: Michelle Shocked's _The Texas Campfire Tapes_: "The Secret Admirer" In-Reply-To: (Kang Niu's message of "Sun, 19 Dec 2021 22:39:55 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222695 Archived-At: Kang Niu writes: > There are no fields in the buffer. (field-beginning) (field-end) return the same value > as (point-min) (point-max). Odd. Does the following fix the performance problem? I'm wondering whether it's the field functions that are slow or whether the narrow-to-region is the thing that somehow triggers the slowness. diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el index 2d1bf2013e..e746d94080 100644 --- a/lisp/thingatpt.el +++ b/lisp/thingatpt.el @@ -178,7 +178,11 @@ thing-at-point See the file `thingatpt.el' for documentation on how to define a symbol as a valid THING." (save-restriction - (narrow-to-region (field-beginning) (field-end)) + (let ((beg (field-beginning)) + (end (field-end))) + (when (or (not (= beg (point-min))) + (not (= end (point-max)))) + (narrow-to-region (field-beginning) (field-end)))) (let ((text (cond ((cl-loop for (pthing . function) in thing-at-point-provider-alist -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no