From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size Date: Mon, 20 Dec 2021 11:26:32 +0800 Message-ID: <87h7b43qjb.fsf@yahoo.com> References: <87wnk0xaz4.fsf@dick> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14902"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 52676-done@debbugs.gnu.org To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 20 04:27:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mz9KR-0003jS-JX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Dec 2021 04:27:11 +0100 Original-Received: from localhost ([::1]:39740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mz9KP-0005nj-Q5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 22:27:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mz9KI-0005mG-Rt for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 22:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mz9KI-0004tk-Jm for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 22:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mz9KI-0001Zy-F6 for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 22:27:02 -0500 Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Dec 2021 03:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 52676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 52676@debbugs.gnu.org, luangruo@yahoo.com, dick.r.chiang@gmail.com Original-Received: via spool by 52676-done@debbugs.gnu.org id=D52676.16399708096047 (code D ref 52676); Mon, 20 Dec 2021 03:27:02 +0000 Original-Received: (at 52676-done) by debbugs.gnu.org; 20 Dec 2021 03:26:49 +0000 Original-Received: from localhost ([127.0.0.1]:48596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz9K5-0001ZT-1I for submit@debbugs.gnu.org; Sun, 19 Dec 2021 22:26:49 -0500 Original-Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:44786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz9K3-0001ZE-FI for 52676-done@debbugs.gnu.org; Sun, 19 Dec 2021 22:26:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639970801; bh=7BYYzT+wOJLi7mKg/h+Obced8UFSPZHZYdraWJDIntk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=K9e1dLMipGXoXy6wsAc6QC1TXxMUR5aLV3hV9EdUY+CKp0ssopUTSXq1U29FiqNbx95AByofhOZudibNG+HIsvMO6WAoC1P92UQHmiJhR2bJ1nYqYdtTjfpnzzl2VsEvG4HR0wAor/CfzrNzdPPB21yQY2b19sZFp9oOj0um8II1pgElEb9zj+44WC+8UfQp4GdnvMXcyjZYDWJx7vs1Tv7iMKj2Fmy6yNzpITQAUFCmWUfT4vMnAfOH4dra74nwR02Ah+lzcqw9aU5O8MaH0bqPcVVrdpOdmS6tJaCVbAmr0jG1VA1yAzj5KNNStM8GeXN6qsOOzfiChVgnzL0Bwg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639970801; bh=hCnPFKutrpuywiO3biZGuqvAIwV7oXIeYs9/IP8JVLG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Jaua5rh9QTUs1gpIvbWspoQUu9Wwl58kWAMsW88gp+HPLNmK34Qxs+t9plWnMB97piC5QR0LQ7USWvIbbIPDn/SHSGx94hERIcYDOakM7Umvt+k8h5cuFpHHrehNsjVrOK4qf7ncZmd3wqrdq1Klkj2RdKc07EBPYtMBW69azz+qlvWlUj/OeoQ32jjQ+nUddtnpWKcQnYGCvstG08d7RlS+6h0Yu3YYf5aqbi6ytCNtZVLwyTymAakrEB+ifCuxwnwh25K/WfhGxenY4cvTCmn4xqLCbxKAJ48yxXxHHgIyf/H7y1pzZpNJF0UpJ5lA8cYesQ7qLixxgY7xB5fTvQ== X-YMail-OSG: I9Oze3gVM1lO9VI5oM922amCS.HQftj2sKfSHS0Sp9P_igqFxytlxJjIkTvG5Hf 1ghTS_U9OUHuPH7jMA1XGFmg1qYG85N09zYp5LLmN9AMp.zQGH8lxOvFlNFf.Ivji734WvoGQYrT 0bSvYEBFhmoMrDDAnL3jRMBrdXf2yJcFX_P67xPi6ugA.uPWWSZCnZtTWyR9BIq2eOJLH8KQ.MH7 4TriP720frIfp141Rk7FiYeyOEwuFjAS_5DrbWkC9SLHj9Ew2Yg3Wzst1yNnCwzqF2EgQABx258V X_pJCV4xaSntR15FeB2Gm_6rLqj4f.ifk.lGOM71Ztb9CE9y_c3Y6Y3ED.fKQowkrwBlsC8p51Hm xMyrKrhzP3iPbrJn8fkxvS9hApdL4KQnwAQZJrfIJfkMEN.4kU7RLxCdpCE4mZiLbBlCIhzvdBiO uVqEBJkWMjwGLzQ3WWVRhd9YnsgAu7e8xfLq9NXknZVwNMUCXHflmlGiDe3.OLDovAlC5s_37tou bCjLyYBPaeMx6Oua7oi__8gHDNfb2.intqynIL030nyYM2w6uQVSwDP_EQgERwgiShUuXJMmBngQ BL2DJAInX0LKbzg9Eg_I99bpV_soO6.FQb8t_5CT8q0TP7pHtaDfmiR99B1UC0Rq9NHGDl1nANmr yFtWhFha8pHcEdopuc8PVWGHJEUavbtmPjzJZhWp3gD8c96npX0LM_pxxf22aTt1gzo3GMO28XA6 GTZMP0fQXPd0zhNu2V0zA0z6Nal87JrWyGWeStvyPiWE3iVYV4crj2wtBcWq1h54rYPX946Nx4F7 _wIaupvUXJLJOR23EXa0V32CBI7OCZBtX7BD3WWoBq X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Mon, 20 Dec 2021 03:26:41 +0000 Original-Received: by kubenode518.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 50122396893179d2b30e313d2a6d673f; Mon, 20 Dec 2021 03:26:36 +0000 (UTC) In-Reply-To: <87wnk0xaz4.fsf@dick> (dick's message of "Sun, 19 Dec 2021 21:32:15 -0500") X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222763 Archived-At: dick writes: > Even if 43c4cc2 did anything (it doesn't), it was obviously the wrong > way to go about it. On the contrary, it does. The pixel-scrolling code works on a line with a line-prefix because of it. > + (car (window-text-pixel-size > + nil (line-beginning-position) (line-end-position))))))))) This suggests that it will not work for the usecase that the option was intended to support, because the position `line-beginning-position' might not be on the start of the visual line. Trust me, I tried quite a few options including precisely this before implementing this option. Closing.