From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52593: 28.0.90; (thing-at-point thing) has so much overhead since commit 7db376e560448e61485ba054def8c82b21f33d6a Date: Wed, 22 Dec 2021 13:52:01 +0100 Message-ID: <87h7b0er9q.fsf@gnus.org> References: <83zgoybbfr.fsf@gnu.org> <83ee689156.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9693"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52593@debbugs.gnu.org To: Kang Niu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 22 13:53:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n017H-0002HA-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Dec 2021 13:53:11 +0100 Original-Received: from localhost ([::1]:47076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n017G-0006sx-LN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Dec 2021 07:53:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0178-0006rU-8n for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 07:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n0177-0002df-V8 for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 07:53:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n0177-0007qJ-SS for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 07:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Dec 2021 12:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52593 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 52593-submit@debbugs.gnu.org id=B52593.164017753330087 (code B ref 52593); Wed, 22 Dec 2021 12:53:01 +0000 Original-Received: (at 52593) by debbugs.gnu.org; 22 Dec 2021 12:52:13 +0000 Original-Received: from localhost ([127.0.0.1]:57041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n016K-0007pC-U5 for submit@debbugs.gnu.org; Wed, 22 Dec 2021 07:52:13 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:48926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n016J-0007oz-BT for 52593@debbugs.gnu.org; Wed, 22 Dec 2021 07:52:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BtVLuIlIlFWba77h3RSN4IFGNT9et6MQdPaj66t0Y4U=; b=vIKqwvLoPlBceSqigtrgwgq1N7 KvxqsENl4kr5tLTSlAvXRO2vNG3iL9He4mgVYI6YP/S3KivLh6WDfjlczgYNeGi8dEnsuMvTIVbY/ FzFJGcgoP+0GRMHgBQeIQT5Tasf8t9GtH3gjNRiTzZiEgZrSxfEpN0QJ2CoxqUwYaM/M=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n016A-000067-0c; Wed, 22 Dec 2021 13:52:04 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEWRkZT+/v5paWzB v77w7+/Q0NIuLzLq6epWV1t9fYF4eX2BgYX///9Qx3zCAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+UM FgwuJXPG4dwAAADTSURBVDjLxZLdCQMhDIDtBg3kuAE6iSC4Rlc4cIUO4AiFLtAN61800dxbaX3x 8Lt8iSbmAvoyvwA3q55v5u61c7yaBx4KsJuJsK8yTDmeAE5NnsAisw3MMqQIgKCrJpllgMuwRcS6 dxlaCbqMQgmQDHvyN305LuKgyEYNA2RZFwkAbogkENfkgKfgIIm8Cpx4zX7BWtF+LKBV5BdA/Q0T 6H0nWesHu5oXgA0KBgbEAFVZAfyNSFbAPHEBTiYxyxKYRE2WwXKe/23lruu/IH4PvE7AB00ScSJT y/qvAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTEyLTIyVDEyOjQ2OjM3KzAwOjAwUkfktAAAACV0 RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMi0yMlQxMjo0NjozNyswMDowMCMaXAgAAAAASUVORK5CYII= X-Now-Playing: Qasim Naqvi's _Erased Tapes: 1 + 1 = X (1)_: "Brutal Moderna" In-Reply-To: (Kang Niu's message of "Wed, 22 Dec 2021 10:44:27 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222932 Archived-At: Kang Niu writes: > Maybe an optional arg for thing-at-point is necessary to respect fields? > As I understand, it should be determined by the user of thing-at-point to get what > kind of thing at point. > If the user knows or expects fields in the text, he passes the optional arg. > If the user just wants the "normal" thing at the point whether there are fields or > not, he calls it without the opt arg as the old way. The problem is interoperability between packages. If a package uses fields to make the buffer more understandable, then other packages like symbol-overlay should use those fields automatically without having to be altered. And if symbol-overlay says "do use fields", then we're back to the same performance problems we're already seeing. Ideally the way to make this work would be to change all the thingatp functions to do their normal thing, but then see whether there's any field separators in that area, and if so, recalculate the "thing". But that would require a big rewrite. I think at this point, the way forward is to revert this change on emacs-28 to fix the performance regression, and then open a new bug report for this. So I'll do both now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no