unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kang Niu <isgniuk@gmail.com>
Cc: 52593@debbugs.gnu.org
Subject: bug#52593: 28.0.90; (thing-at-point thing) has so much overhead since commit 7db376e560448e61485ba054def8c82b21f33d6a
Date: Wed, 22 Dec 2021 13:52:01 +0100	[thread overview]
Message-ID: <87h7b0er9q.fsf@gnus.org> (raw)
In-Reply-To: <CAOa1fPtprXs7x62FA1Ufhh_mm0bu3OOAq=M9JRc7kiVeqFJ3OQ@mail.gmail.com> (Kang Niu's message of "Wed, 22 Dec 2021 10:44:27 +0800")

Kang Niu <isgniuk@gmail.com> writes:

> Maybe an optional arg for thing-at-point is necessary to respect fields?
> As I understand, it should be determined by the user of thing-at-point to get what
> kind of thing at point.
> If the user knows or expects fields in the text, he passes the optional arg.
> If the user just wants the "normal" thing at the point whether there are fields or
> not, he calls it without the opt arg as the old way.

The problem is interoperability between packages.  If a package uses
fields to make the buffer more understandable, then other packages like
symbol-overlay should use those fields automatically without having to
be altered.  And if symbol-overlay says "do use fields", then we're back
to the same performance problems we're already seeing.

Ideally the way to make this work would be to change all the thingatp
functions to do their normal thing, but then see whether there's any
field separators in that area, and if so, recalculate the "thing".

But that would require a big rewrite.

I think at this point, the way forward is to revert this change on
emacs-28 to fix the performance regression, and then open a new bug
report for this.  So I'll do both now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-12-22 12:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-18  5:59 bug#52593: 28.0.90; (thing-at-point thing) has so much overhead since commit 7db376e560448e61485ba054def8c82b21f33d6a Kang Niu
2021-12-18  7:48 ` Eli Zaretskii
     [not found]   ` <CAOa1fPsPmyHpzyT8AUzkc4vFGCJXgWJ3NVjGg=99hF4b8AuaWQ@mail.gmail.com>
2021-12-19 13:26     ` Eli Zaretskii
2021-12-19 13:35       ` Lars Ingebrigtsen
2021-12-19 14:39         ` Kang Niu
2021-12-19 14:44           ` Lars Ingebrigtsen
2021-12-19 15:19             ` Kang Niu
2021-12-19 15:37               ` Kang Niu
2021-12-19 15:49                 ` Lars Ingebrigtsen
2021-12-19 15:55                   ` Lars Ingebrigtsen
2021-12-19 16:14                     ` Lars Ingebrigtsen
     [not found]                       ` <CAOa1fPuD=gVEF-SKtvuu4jkzu3p40xUBoejBjUrv-v0kDrc0qg@mail.gmail.com>
2021-12-20  9:24                         ` Lars Ingebrigtsen
2021-12-19 16:22       ` Lars Ingebrigtsen
2021-12-19 17:21         ` Lars Ingebrigtsen
2021-12-19 17:33           ` Lars Ingebrigtsen
2021-12-19 17:38             ` Eli Zaretskii
2021-12-20  9:23               ` Lars Ingebrigtsen
2021-12-20 17:23                 ` Eli Zaretskii
2021-12-21 11:03                   ` Lars Ingebrigtsen
2021-12-22  2:44       ` Kang Niu
2021-12-22 12:52         ` Lars Ingebrigtsen [this message]
2021-12-24 22:43           ` bug#52593: [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7b0er9q.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=52593@debbugs.gnu.org \
    --cc=isgniuk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).