From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: 53492@debbugs.gnu.org
Subject: bug#53492: 29.0.50; Remove use of define-keymap in gnus-registry.el?
Date: Sun, 23 Jan 2022 20:24:08 -0800 [thread overview]
Message-ID: <87h79t69sn.fsf@ericabrahamsen.net> (raw)
Commit 453db25 changes the Gnus registry's key bindings to use
`define-keymap'. The problem is that the old code *added* the registry
bindings to the "M" prefix in `gnus-summary-mode-map', while the new
code *overrides* everything that was defined on that "M" prefix, in
favor of the registry's keys. There used to be a lot of commands there.
The simple solution would be to not use `define-keymap' in the registry
code, and instead use `define-key' inside the loop at
gnus-registry.el:959, defining each command individually on a "M <key>"
binding.
Another possibility would be to explicitly name the sub-keymap that's
currently hung on the "M" prefix, at gnus-sum.el:2038. Then that could
be used as a :parent in the `define-keymap' call in gnus-registry.el.
Or is there a way to attach a `define-keymap' to an anonymous prefixed
keymap?
Eric
next reply other threads:[~2022-01-24 4:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 4:24 Eric Abrahamsen [this message]
2022-01-24 10:10 ` bug#53491: 29.0.50; Fixing use of define-keymap in gnus-registry.el Lars Ingebrigtsen
2022-01-24 17:49 ` bug#53492: " Eric Abrahamsen
2022-01-24 18:30 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h79t69sn.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=53492@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).