From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#53207: 28.0.91; create-lockfiles nil breaks file change detection Date: Sat, 29 Jan 2022 11:53:55 +0100 Message-ID: <87h79m24os.fsf@gmx.de> References: <509ddd0f-589c-45b0-9b60-5820f4c1d716@www.fastmail.com> <83sftr3nyx.fsf@gnu.org> <83h7a73fab.fsf@gnu.org> <87fspqz94l.fsf@gmx.de> <87v8ylmnie.fsf@gnus.org> <837db11he9.fsf@gnu.org> <83h79pdrlh.fsf@gnu.org> <877dakht8k.fsf@gnus.org> <83h79oc4qi.fsf@gnu.org> <87leyz29jl.fsf@gmx.de> <83bkzvdh5y.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38814"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: rgm@gnu.org, larsi@gnus.org, ejb@ql.org, 53207@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 29 11:56:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDlOj-0009vn-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Jan 2022 11:56:01 +0100 Original-Received: from localhost ([::1]:52454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDlOh-0007V4-9S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Jan 2022 05:55:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDlNn-0007Ui-1e for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 05:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDlNm-0003B8-Oe for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 05:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDlNm-0006Lm-IK for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 05:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jan 2022 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53207 X-GNU-PR-Package: emacs Original-Received: via spool by 53207-submit@debbugs.gnu.org id=B53207.164345364924328 (code B ref 53207); Sat, 29 Jan 2022 10:55:02 +0000 Original-Received: (at 53207) by debbugs.gnu.org; 29 Jan 2022 10:54:09 +0000 Original-Received: from localhost ([127.0.0.1]:32797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDlMv-0006KK-4T for submit@debbugs.gnu.org; Sat, 29 Jan 2022 05:54:09 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:42887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDlMs-0006Jo-LJ for 53207@debbugs.gnu.org; Sat, 29 Jan 2022 05:54:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643453637; bh=leWwYdpbUiPYGvYyCyS2+58OdbRBoM5q+BFPPi7ukwM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=QGEUwsV9zTZYYH4bW86h+cmdN+FGFyE6qOxPxgmmvJ5bi5yQO6GeloOmW2ieRF83b geHbiq/YnN4Y2Xdw4mA/xvGmNAWiWATTRfRK0adcY8mMeFtc+CM7h0eIt/CENa+n0G 3jVRjZu7fedGwMwxvaelj5iwWQLX17AanKLrYXpM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.118.102]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MOzSu-1msu2C3hW8-00PNZV; Sat, 29 Jan 2022 11:53:57 +0100 In-Reply-To: <83bkzvdh5y.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Jan 2022 17:16:41 +0200") X-Provags-ID: V03:K1:gNuwAzUBf+t8BvzTktaMqg1W4DVgsTMo+ND0Y7nreHL2w5y8VV5 DthkEV1QzIn7tNb60avCI9FusXfKIc3Q4vQ7oken+dmODLVDONuB+PtCfa20S3N8JpMvjgu xH3Vn7P7uiq5qFoxIqC4SLnu6UxnwZrb8hUKgc8mUM7zHRDsuhPzEF7x+HW51Y1RSyNcpbx OSgy3sbIABjBu8jGk84iQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:nSJG9j2udMY=:yatmVO6DxjnE6Rq/6f2laU cCnxL72TDkV6tAx8fA8S22DWr0vJ5W9gaQOdFGdRGOecnni9L2QlVn3DJyKT8wIxB6MQ6BhKN dgmRZ7x4to/x/XrNXP7UXXZAS75VDsqUt/NYXEaXrk9ihwDsd83vt738UIOgO1wfd5HpdHQ7T Wy7r/wMRYDiFsXImpZtBP+Oj3c9CIiXMmWG7qkWpqV/WDDHH+uDeSqJSJ6XVgBVQnHkhrdtYF 16cSYuEwxahq3fvHLalRp47/xeYjxZafIPd7MoiPlPY0ca6dyZaZ1yuSyb6phOcAtNnNmBd1n DRObtl8Z+xn398K5o2Cmtuo6mlu/Gwl9j7z5AWhz/ZhD6yKsnLGN4oBky6zBsLF0DDL6JVuad oTT5CpMlgkz1yc9sMYNHgMiOCaL0I/vq8WLQBPYQBQwfUGZogdLVX2N904DFNOesJ5/VgKlUJ ky25rzgVu4dq/RQ/X2v+XjBws4kWtuHNkff6ipdNag2RqimFSdUkT0MtQ8wXxn5KSKNIKhDAV evzIZT1ZZcVVbciaVQlLBwlRz1T97OmEhWB53GUBrLJPBzoy4iqWNV/L4Aas8iA1rqZhv1/TF kgKM46AdZ++0VxTIbmI2TBTn92Q6koCeiRB55Yxv05giRcfHTOFYHjwOeRZ5mW1wSHLJTF/Fk NTZ6yS3/OcES8/z+QNoUxXslgUsKM30ZOna9RIg8uGQwkZI9HdGs/WyTEVUuLpWp61tYSZWeS eY5rVX/o8y+Od+ZqpYaUgJsGlOaX/dV+wB/XOo5hYLElaaiiKmQwOspSr7JWHAgHA10YqvPP X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225514 Archived-At: Eli Zaretskii writes: Hi everybody, >> > Michael, could you please suggest a patch along these lines? The >> > changeset which moved userlock--ask-user-about-supersession-threat >> > into Flock_file and put that under the create-lockfiles condition was >> > your change to support locking remote files. >> >> Will do. How urgent is this? I'd rather work on it tomorow. > > Tomorrow is fine, thanks. I've pushed ddba3c3dba to the emacs-28 branch. Tested with =2D-8<---------------cut here---------------start------------->8--- # make -C test files-tests filelock-tests tramp-tests SELECTOR=3D'"lock"' =2D-8<---------------cut here---------------end--------------->8--- for regression. I've tested also the recipe of the OP, it works now as expected (like in Emacs 27.2). The recipe of the OP does not work yet for remote files. I'll continue to fix it, but this shouldn't stall the Emacs 28 release, because the regression tests work also for them. I'll keep the bug open, until this remote case has been fixed, too. Feedback, whether it works as expected, most welcome. Best regards, Michael.