From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#53638: [PATCH] newsticker better path handling and data storage Date: Mon, 31 Jan 2022 16:47:13 +0100 Message-ID: <87h79j29ha.fsf@gnus.org> References: <87h79lgg5n.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32359"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53638@debbugs.gnu.org To: mailj2@protonmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 31 17:08:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEZEK-00089T-8A for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Jan 2022 17:08:36 +0100 Original-Received: from localhost ([::1]:33312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEZEJ-0001g3-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Jan 2022 11:08:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEYuQ-000240-OK for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 10:48:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEYuQ-0002SG-Dv for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 10:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEYuQ-0003Tc-DK for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 10:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Jan 2022 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53638-submit@debbugs.gnu.org id=B53638.164364404412331 (code B ref 53638); Mon, 31 Jan 2022 15:48:02 +0000 Original-Received: (at 53638) by debbugs.gnu.org; 31 Jan 2022 15:47:24 +0000 Original-Received: from localhost ([127.0.0.1]:40355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEYto-0003Cc-4B for submit@debbugs.gnu.org; Mon, 31 Jan 2022 10:47:24 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:47192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEYtm-00037I-SR for 53638@debbugs.gnu.org; Mon, 31 Jan 2022 10:47:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y9E2pzN5yf5XFyItOsLurP03DYNRc2XCbGiKwp2M8aI=; b=BerFsvZXFHxpwpFrW+2Kjvr4UB 8VfCLxOT8ijLZx5Z+q5dSryvgR6BAjFTbUxW7x+MptEYWJ34kYyI43rjx2a7y88Y5Sl+XLLDy6FTJ eHKIdax9TOrduRiRqf4h97ygs4LZxMug/3xF5J/7bPim9yPfgxxoZCQwP8dZpzaYZAiU=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEYte-0003zH-8H; Mon, 31 Jan 2022 16:47:16 +0100 X-Now-Playing: Two Nice Girls's _Like A Version_: "I Spent My Last $10.00 (on Birth Control & Beer)" In-Reply-To: <87h79lgg5n.fsf@protonmail.com> (mailj2@protonmail.com's message of "Sun, 30 Jan 2022 19:47:03 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225678 Archived-At: mailj2@protonmail.com writes: > The way newsticker currently handles paths involves directly concating > "/", which only works for UNIX systems. Can you rework the patch to use `expand-file-name', which is how file names are supposed to be constructed? > Additionally, since newsticker uses `prin1-to-string' for storing > groups and cache, it should be enforced that `print-level' and > `print-length' are set to nil for the operation just as a precaution (it > happened to me that I manually set these once, which resulted in the > newsticker cache being corrupted). That part of the patch looks good. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no