From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#53889: 29.0.50; obsolete git-sh-setup function sane_egrep in pre-commit hook Date: Tue, 08 Feb 2022 19:30:19 -0800 Message-ID: <87h798bttg.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38506"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 53889@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 09 04:31:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHdhW-0009qQ-Ru for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Feb 2022 04:31:27 +0100 Original-Received: from localhost ([::1]:33384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHdhV-0000pJ-Hz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 22:31:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHdh8-0000oz-Q6 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 22:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHdh8-00021U-9j for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 22:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHdh7-0005v6-U7 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 22:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Feb 2022 03:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53889 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164437744922733 (code B ref -1); Wed, 09 Feb 2022 03:31:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Feb 2022 03:30:49 +0000 Original-Received: from localhost ([127.0.0.1]:49270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHdgv-0005uZ-04 for submit@debbugs.gnu.org; Tue, 08 Feb 2022 22:30:49 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:35490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHdgs-0005uR-Qq for submit@debbugs.gnu.org; Tue, 08 Feb 2022 22:30:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHdgd-0000n4-0h for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 22:30:37 -0500 Original-Received: from mail-108-mta64.mxroute.com ([136.175.108.64]:43759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHdgW-0001yZ-IQ for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 22:30:28 -0500 Original-Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta64.mxroute.com (ZoneMTA) with ESMTPSA id 17edc8837ae0005a20.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 09 Feb 2022 03:30:21 +0000 X-Zone-Loop: 466487e1df2299c7d846e4f07dec9ebb7ec712d404da X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=3+uswtgrCiBtm8DvNBCgILxJ+8/2tgzFfYhBbL7KC+U=; b=F tQbEHmkxjMaX0tdERMEP1GSMhZBhELIU9FwrS1rSJc+JywJZUB6nrHAlyKGW8YDb3aUEQWrFHUYG9 UhWMlAlQnKCm7c8itUVqLsvH7+eKtkFS2Ii+9TV7fVyNtRtyh717RJ68jr/LFJDEbdM1XhAzKmvPq b7WPbefVSMK0N0SccXhz+B+pm8reykgbEunojj6aXchKRnN58ptbvdQuGS2re4gAHoJnaaWA3PUH7 KCoAF7yy7DHL6KujxyeS0TfnEEtbcY/V1rUmqc7QUbCmhpzuxk//od2xdsu6f2p+1fa1FSfCuX2US hHw/yn0hzAQ6OCD/Pq5Yw2EGEY1M1qyFA==; X-AuthUser: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.64; envelope-from=jp@neverwas.me; helo=mail-108-mta64.mxroute.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226425 Archived-At: Severity: minor Hi, I stumbled on this by accident after leaving a recent build of the Git suite in my PATH and trying to apply some Emacs patches with git-am. The patches still applied despite a warning being emitted: .git/hooks/pre-applypatch: line 48: sane_egrep: command not found I believe the breaking change[1] (in git.git) was first included[2] in release v2.35.0[3]. Browsing around, it looks like only bleeding edge distributions have begun packaging this Git release[4]. There's likely still some time before it starts affecting most of us. Thanks. [1] https://github.com/git/git/commit/ebeb39faad6e3a67c31884c3dc6b76ce58b3f= 15b commit ebeb39faad6e3a67c31884c3dc6b76ce58b3f15b Author: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason Date: Thu Oct 21 21:58:00 2021 +0200 =20=20=20=20 git-sh-setup: remove "sane_grep", it's not needed anymore =20=20=20=20 Remove the sane_grep() shell function in git-sh-setup. The two reas= ons for why it existed don't apply anymore: =20=20=20=20 1. It was added due to GNU grep supporting GREP_OPTIONS. See e1622bfcbad (Protect scripted Porcelains from GREP_OPTIONS insan= ity, 2009-11-23). =20=20=20=20 Newer versions of GNU grep ignore that, but even on older versio= ns its existence won't matter, none of these sane_grep() uses care about grep's output, they're merely using it to check if a string exists in a file or stream. We also don't care about the "LC_ALL= =3DC" that "sane_grep" was using, these greps for fixed or ASCII strin= gs will behave the same under any locale. =20=20=20=20 2. The SANE_TEXT_GREP added in 71b401032b9 (sane_grep: pass "-a" if grep accepts it, 2016-03-08) isn't needed either, none of these = grep uses deal with binary data. =20=20=20=20 Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason Signed-off-by: Junio C Hamano [2] https://github.com/git/git/commit/ad1260b6c994f7c0f9c259bd39f39979f7f4e= cc2 Merge branch 'ab/sh-retire-helper-functions' [3] https://github.com/git/git/commit/89bece5c8c96f0b962cfc89e63f82d603fd60= bed commit 89bece5c8c96f0b962cfc89e63f82d603fd60bed (tag: v2.35.0) Author: Junio C Hamano Date: Mon Jan 24 09:25:25 2022 -0800 Git 2.35 Signed-off-by: Junio C Hamano [4] https://github.com/archlinux/svntogit-packages/commit/6d64d752 https://src.fedoraproject.org/rpms/git/blob/rawhide/f/git.spec#_86 In GNU Emacs 29.0.50 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.3= 1, cairo version 1.17.4) of 2022-02-04 built on localhost Repository revision: 97966c5154bb842a3e5d04a003feadf7d761259b Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 35 (Workstation Edition) Configured using: 'configure --enable-check-lisp-object-type --enable-checking=3Dyes,glyphs --build=3Dx86_64-redhat-linux-gnu --host=3Dx86_64-redhat-linux-gnu --program-prefix=3D --prefix=3D/usr --exec-prefix=3D/usr --bindir=3D/usr/b= in --sbindir=3D/usr/sbin --sysconfdir=3D/etc --datadir=3D/usr/share --includedir=3D/usr/include --libdir=3D/usr/lib64 --libexecdir=3D/usr/libe= xec --localstatedir=3D/var --sharedstatedir=3D/var/lib --mandir=3D/usr/share/m= an --infodir=3D/usr/share/info --with-dbus --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xft --with-xpm --with-x-toolkit=3Dgtk3 --with-gpm=3Dno --with-xwidgets --with-modules --with-harfbuzz --with-cairo --with-json build_alias=3Dx86_64-redhat-linux-gnu host_alias=3Dx86_64-redhat-linux-gnu CC=3Dgcc 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Wl,-z,relro PKG_CONFIG_PATH=3D:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media rmc puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date seq gv subr-x byte-opt bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads xwidget-internal dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 44979 11627) (symbols 48 5690 1) (strings 32 15812 2354) (string-bytes 1 523893) (vectors 16 12816) (vector-slots 8 173470 33427) (floats 8 20 34) (intervals 56 261 0) (buffers 992 10))