From: Michael Albinus <michael.albinus@gmx.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 55166@debbugs.gnu.org, Dan McCarthy <daniel.c.mccarthy@gmail.com>
Subject: bug#55166: 28.1; tar-mode doesn't re-compress when saving remote files
Date: Tue, 03 May 2022 14:36:53 +0200 [thread overview]
Message-ID: <87h766u716.fsf@gmx.de> (raw)
In-Reply-To: <87y1zphwly.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 28 Apr 2022 20:49:13 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
Hi,
>> dan@solstice:/tmp$ touch a b c
>> dan@solstice:/tmp$ tar cf test.tar a b c
>> dan@solstice:/tmp$ bzip2 -z test.tar
>> dan@solstice:/tmp$ file test.tar.bz2
>> test.tar.bz2: bzip2 compressed data, block size = 900k
>>
>> If you visit that remote file and save it, the result will have the .bz2
>> extension but won't actually be compressed:
>>
>> dan@solstice:/tmp$ file test.tar.bz2
>> test.tar.bz2: POSIX tar archive (GNU)
>>
>> This doesn't happen with compressed remote files which aren't tar archives.
>
> I can reproduce this problem with Emacs 29, too. (And if I edit the
> file locally instead of via tramp, the tar file is saved compressed, so
> it seems to be tramp-related.)
Well, the problem seems to exist since Emacs 27, likely due to some
subtle changes in basic-save-buffer-1 or basic-save-buffer-2. I haven't
poked further there, because it looks like saving the buffer with this
constellation happened twice in Emacs 26, which looks not optimal.
The problem is an exotic feature of write-region, which first looks for
a file name handler in FILENAME, and if there isn't one, it checks
VISIT.
write-region of the compressed remote tar file in the scenario above is
called like
--8<---------------cut here---------------start------------->8---
...
tramp-file-name-handler(write-region nil nil "/ssh:detlef:/tmp/tmpfSxlA9" nil "/ssh:detlef:/tmp/test.tar.bz2" "/ssh:detlef:/tmp/test.tar.bz2" nil)
write-region(nil nil "/ssh:detlef:/tmp/tmpfSxlA9" nil "/ssh:detlef:/tmp/test.tar.bz2" "/ssh:detlef:/tmp/test.tar.bz2")
basic-save-buffer-2()
basic-save-buffer-1()
basic-save-buffer(t)
save-buffer(1)
funcall-interactively(save-buffer 1)
call-interactively(save-buffer nil nil)
command-execute(save-buffer)
--8<---------------cut here---------------end--------------->8---
That is, a remote temporary file ("/ssh:detlef:/tmp/tmpfSxlA9") is
written, and the magic extension of the remote VISIT argument
"/ssh:detlef:/tmp/test.tar.bz2" is ignored.
When FILENAME is a local temporary file, the handler for VISIT
(jka-compr-handler) is triggered. That's the second test Lars has applied.
I've pushed a fix to master, which shall fix this. Dan, could you pls
check?
In parallel I'll try to write a test case for this problem. But that's
unrelated to closing this bug.
Best regards, Michael.
next prev parent reply other threads:[~2022-05-03 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 15:43 bug#55166: 28.1; tar-mode doesn't re-compress when saving remote files Dan McCarthy
2022-04-28 18:49 ` Lars Ingebrigtsen
2022-05-03 12:36 ` Michael Albinus [this message]
2022-05-03 18:02 ` Dan McCarthy
2022-05-04 6:46 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h766u716.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=55166@debbugs.gnu.org \
--cc=daniel.c.mccarthy@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).