From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45922: 27.1; Better auto-fill for strings in python-mode Date: Sat, 07 May 2022 18:56:51 +0200 Message-ID: <87h761l1rg.fsf@gnus.org> References: <87tua1mjd9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10313"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: =?UTF-8?Q?=D0=90=D0=BA=D0=B8=D0=BC=D0=B6=D0=B0=D0=BD=D1=87=D0=B5=D0=B3?= , 45922@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 07 18:58:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnNkv-0002Qh-5w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 May 2022 18:58:09 +0200 Original-Received: from localhost ([::1]:44266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnNku-0002yu-7V for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 May 2022 12:58:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnNko-0002yb-5M for bug-gnu-emacs@gnu.org; Sat, 07 May 2022 12:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58992) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnNkn-0001HV-TC for bug-gnu-emacs@gnu.org; Sat, 07 May 2022 12:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nnNkn-0001NU-Ql for bug-gnu-emacs@gnu.org; Sat, 07 May 2022 12:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 May 2022 16:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45922 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45922-submit@debbugs.gnu.org id=B45922.16519426245213 (code B ref 45922); Sat, 07 May 2022 16:58:01 +0000 Original-Received: (at 45922) by debbugs.gnu.org; 7 May 2022 16:57:04 +0000 Original-Received: from localhost ([127.0.0.1]:52886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnNjr-0001M1-Qt for submit@debbugs.gnu.org; Sat, 07 May 2022 12:57:04 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnNjp-0001LR-Vk for 45922@debbugs.gnu.org; Sat, 07 May 2022 12:57:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oIeRnTm5VnYMmGNm9SXJOhuyElfDq3UrghkW4yVFq3Q=; b=t1XlECcyE1CWXUOcH8F0TeYy7Z d5ZN/hEUlK4ialv4vL+0FMpoISPMy2NUfTtphkIDFp8VLpnfulvYmvrcv+GDa2TqnyG8nskY4n2wZ J/Xozt+p8Vg0PGLyt5mLuu1S6S7D08TyWRDyodp/1anwiURnbmysiG3km11c+nznVEjM=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnNjf-0005O0-Ms; Sat, 07 May 2022 18:56:54 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEVnWVqRgGq7sdRJ QC7////V8fV2AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YFBxAuHFreE+UAAAGdSURBVDjLfZKJtesw CETBNABKA5Z+A/jQf29/QLISv43kOI6uhp2IycyUWNmsjbKuZpTGzZTrswApF6CUECktMOhpgLYU to4YMeZbW0DnVVZZ4EiAiCmJ9EEV3iYYM2YwfmTocV5KYwGcCwEwjX8Hia4YnHk4I7bRUHIhSVfd CsAx21AAfUXFOCuRBGgFEI1TpFW2RI6MTAE6gneK4Ibqz5kqepgR4cqT1Lng60g/HVCjZjhpANcL GtfZCNMD/RbHs9J1RsJzCHiI5yUjDdStVK76WaUdJUbwgKjNyRWuh0aQhLj18bQCJJfa47gXqDHx A2TPBbVTJf9pktfDkYDXDDZ9UQiaAPPZuXut4CMmuLIonuAYTTHRCbj1e0eMBxobW9GbTqA5mXgD zdU6MTCz3uUG944Sj1xte23ggSFZcQDaIOgSn8uNxqHoDSTbHFik3DLJzk7gIjGVGpw3dCvWeXrL S7cC/cp3x2aISf77ALfEb3U8ze/ivoJ98A3Ez8B/ASS/Kd66N6itiL8VG3juVrWXvgL7NN1F2jej +A8ZuH04Hm+lQwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wNS0wN1QxNjo0NjoyOCswMDowMBBY rskAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDUtMDdUMTY6NDY6MjgrMDA6MDBhBRZ1AAAAAElF TkSuQmCC X-Now-Playing: 50 Foot Wave's _Black Pearl_: "Double Barrel" In-Reply-To: (Stefan Monnier's message of "Sat, 07 May 2022 12:25:21 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231609 Archived-At: Stefan Monnier writes: >> The Python auto fill basically just calls `do-auto-fill', so I wondered >> whether there was something simple to tell that function to not consider >> any points where ppss-string-terminator is non-nil as a break point, but >> apparently not? > > `fill-nobreak-predicate`? Ah, yes, perfect. With this, it works like the original bug reporter wanted: (setq-local fill-nobreak-predicate (lambda () (ppss-string-terminator (syntax-ppss)))) But this reminds me that auto-fill-mode in programming modes is a bad idea in general: Even if it doesn't chop anything inside the string, it'll still lead to invalid code. So I think the answer to this bug report is really -- don't use auto-fill in python-mode, and I'm closing it as a wontfix. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no