From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Date: Wed, 14 Sep 2022 15:44:49 -0700 Message-ID: <87h719shi6.fsf@melete.silentflame.com> References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34597"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: Juri Linkov , 57807@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 15 00:45:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYb88-0008oK-Kv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Sep 2022 00:45:17 +0200 Original-Received: from localhost ([::1]:60522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYb87-0000oE-G9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 18:45:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYb7u-0000o3-Tv for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 18:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYb7u-0002xF-M9 for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 18:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYb7u-0002pf-GT for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 18:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 22:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs Original-Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166319549810863 (code B ref 57807); Wed, 14 Sep 2022 22:45:02 +0000 Original-Received: (at 57807) by debbugs.gnu.org; 14 Sep 2022 22:44:58 +0000 Original-Received: from localhost ([127.0.0.1]:56489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYb7p-0002p8-Oa for submit@debbugs.gnu.org; Wed, 14 Sep 2022 18:44:58 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYb7o-0002ov-1v for 57807@debbugs.gnu.org; Wed, 14 Sep 2022 18:44:56 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 007135C00E6; Wed, 14 Sep 2022 18:44:51 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 14 Sep 2022 18:44:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663195490; x=1663281890; bh=qJm1dsHgGG yWE92LYtk0uZVEj2MuIMu3W2Hg0nfBjJ0=; b=m7gPZqWOqCZjTVUAjZWbqcGcrK IXfwN2l3iGcUPSTRIqyBbXQTYU4PF4dhp7mGvhudhVV+5uEAKZa3BRs81x11batd 2M09SgRppZdmBOyUM8dP7Scn6Ep+Wx+8rMY6lH6Q8w2NFoM10S+79OUmjOrtJnjX CRfO1LztGGbHbL/3GOHnzjTMz1YB57rFILy1TIInVHLubFXV5uNFiTFqGmvEhSTH 0/pZF65JSmhy2Lry32pEMwgXBVm4559z3sBn3aG3QJ1Jpj7ktW63cchlFsO5a0hQ n54GpSJQbNjjrl8Jz3UQzdUa/6x24OgcrC2xTekJB+97f5s+547ZhB0XQBEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663195490; x=1663281890; bh=qJm1dsHgGGyWE92LYtk0uZVEj2Mu IMu3W2Hg0nfBjJ0=; b=S85yVotcu4s/5NA/lJj5iVDdFs3d12GY+x2kbipRYWmc RmhkbUNoGtCaCZpED+rpmG4oJe5hetJGd3HeXHMDAtFEhlxzYBGMdldqQztI7wfo qgJDHlJngrBdoxj17CDzyybXqNYVn7mi6u+o6z+4WJcEqLiPQ4jLSp7cMpIX/Tmm MkKdiW3SNqqIcqG3D98fPKTqM9esHDliZP/bDToegwM1Roc5ZI2XXlWhQSEf5Je7 ilsaI9YJIZ7iZWxcgOx1Yz0JxGYpzpqLbA07+lNt3YF+ohbFl+QKDauJ2mhiamFD /zpVnE0kPXVLiHPDwlsvDxy2oenShf9CoAfDW4/a5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedujedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepffeutedtfedvtdetvefgueefjefggedugfefuddtgeefteek heduvdefjeejieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 18:44:50 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 0E27F7F18D3; Wed, 14 Sep 2022 15:44:50 -0700 (MST) In-Reply-To: <86v8ppn5b2.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 14 Sep 2022 22:17:13 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242540 Archived-At: Hello, On Wed 14 Sep 2022 at 10:17PM +03, Juri Linkov wrote: >> vc-git-log-edit-mode is already able to properly understand git-log(1) > > I suppose vc-git-log-view-mode, not vc-git-log-edit-mode? Yes, sorry. >> output which logs multiple branches. Here's a hack to demonstrate that: >> >> (let ((default-directory "~/src/emacs/") >> (vc-git-log-switches >> (cons "origin/scratch/posix-spawn" vc-git-log-switches))) >> (call-process-shell-command "git branch -f tmp 4b2ca6bfc0") >> (vc-print-branch-log "tmp")) >> >> (4b2ca6bfc0 is an old tip of master close to scratch/posix-spawn.) > > Is this equivalent to `M-& git log origin/scratch/posix-spawn 4b2ca6bfc0`, > then enabling vc-git-log-view-mode in the output buffer? It's not, because vc-git-log-view-mode requires you pass four or five options to git-log to get output it can properly display. That knowledge is locked up in vc-git.el right now. > Maybe vc-print-branch-logs, to keep the original vc-print-branch-log > uncomplicated. Perhaps a prefix argument? >> (2) How could vc-print-branch-log prompt the user for multiple branch >> names? Magit has the user separate branch names with commas, offering >> completion for each branch name. But I suppose commas never appearing >> in branch names is git-specific. So the command could prompt the user >> repeatedly for branch names, until the user hits RET to input a >> zero-length branch name, indicating they've input them all. > > Maybe by using completing-read-multiple with branch names separated > by crm-separator, not necessarily comma? I guess it would be a strange VC system that allows spaces in branch names, huh? -- Sean Whitton