From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#58070: [PATCH] Add tamil99 input method Date: Tue, 27 Sep 2022 15:41:33 +0530 Message-ID: <87h70tdt4a.fsf@gmail.com> References: <20220925100020.13229-1-arunisaac@systemreboot.net> <20220925100244.13482-1-arunisaac@systemreboot.net> <87h70vsmyd.fsf@gmail.com> <87ill9ony7.fsf@systemreboot.net> <87ill98u3m.fsf@gmail.com> <83o7v1jpb0.fsf@gnu.org> <87pmfhe0dj.fsf@gmail.com> <83h70tjls4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10285"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: arunisaac@systemreboot.net, 58070@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 27 12:29:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1od7qX-0002Rs-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 12:29:49 +0200 Original-Received: from localhost ([::1]:47700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1od7qW-0006TD-D9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 06:29:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od7ZL-0007er-1m for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 06:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1od7ZK-0002NK-Ke for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 06:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1od7ZK-0005Il-Dq for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 06:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 10:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58070 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58070-submit@debbugs.gnu.org id=B58070.166427350820356 (code B ref 58070); Tue, 27 Sep 2022 10:12:02 +0000 Original-Received: (at 58070) by debbugs.gnu.org; 27 Sep 2022 10:11:48 +0000 Original-Received: from localhost ([127.0.0.1]:52903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od7Z5-0005IF-Ip for submit@debbugs.gnu.org; Tue, 27 Sep 2022 06:11:47 -0400 Original-Received: from mail-pl1-f193.google.com ([209.85.214.193]:36717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od7Z0-0005Hz-7N for 58070@debbugs.gnu.org; Tue, 27 Sep 2022 06:11:46 -0400 Original-Received: by mail-pl1-f193.google.com with SMTP id c24so8660272plo.3 for <58070@debbugs.gnu.org>; Tue, 27 Sep 2022 03:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=QVUzbiguYQTKhOTQ8pvBzTO8kbAC0YjB0AANADq60OE=; b=gtbLWPN3bhkgXD6DHl61heBa7xK46l/GvyUFDvcqUyleMzUDbt9YF3UkoGPU12rogL znGh/Gkjn8YquldUGsYjEgV5Z4CXmdqNGzGO6PykclERBawS/fDlMD9KG9XyuDcH39kf SuoWX71Te18ZDmulQoeJf4euOCDnaTtCdVb0EJUxc8NgElp0b9wclJ7Pjnvj2VWdnsu0 BMbvd2wT+ngbGfr9Op6C+H1U4eVpliuKTgw7UriCCYdQZftkW0NlEDjtH4+UO02NdDn0 U5OxUKBq5RCbcmxjpshPpuPpezdHCJnkI74ewZxK8uTXU/CFqtCd0Wd0KQz78Bqas3Vd kzCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=QVUzbiguYQTKhOTQ8pvBzTO8kbAC0YjB0AANADq60OE=; b=JGwE44WvPhwz5Nicw8e2wHT4tyBQt453hR3JAIPJk/9t7rOww53hCLbxe+HHCywk1l XVScwYhFUc+ra66gA/YQmXdcKa7Cc+fmSm7z9LsddJrhw8MvLJ1rhWJr6FAsXEW110zi Tci88twBbtwXoMMrtMZ6X8UmR1urgoEWKWMyyYvGVfeOFyDGKD24MF3rF7CoVja4TEz/ AdJi2CzautyAieCP3p3xKdxIkX9S1+8Hry3CA1/jckLLaOsZbQqyXNa+784D6JRn4dqw JldV0AS6bvHIK9ykYU0EWynhhUSr9tZjHUhpW/X6ed7CZJO8mfsSvU85ihZ+YLizTKYe 4+mA== X-Gm-Message-State: ACrzQf2CIyGp4ziyMLCONFflqFrrxENsKdPTf+RA6Be/IxnyBdBtUuyw roCjPI1jX0AKSbvb0tDXW2M= X-Google-Smtp-Source: AMsMyM6/9e0YSyoGBas5OPgFRNJM66vGSTvgcZg6X7hcxLVhAa0TYrSrVkAVbWvwI4Pe+MdYg89WWw== X-Received: by 2002:a17:902:ce8f:b0:176:e0b3:cf14 with SMTP id f15-20020a170902ce8f00b00176e0b3cf14mr25910991plg.153.1664273496635; Tue, 27 Sep 2022 03:11:36 -0700 (PDT) Original-Received: from localhost ([118.185.152.162]) by smtp.gmail.com with ESMTPSA id e12-20020a170902d38c00b0016c09a0ef87sm1084985pld.255.2022.09.27.03.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 03:11:35 -0700 (PDT) In-Reply-To: <83h70tjls4.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 27 Sep 2022 10:53:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243710 Archived-At: [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D = =E0=AE=9A=E0=AF=86=E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0= =AE=B0=E0=AF=8D 27, 2022] Eli Zaretskii wrote: >> From: Visuwesh >> Cc: arunisaac@systemreboot.net, 58070@debbugs.gnu.org >> Date: Tue, 27 Sep 2022 13:04:48 +0530 >>=20 >> In delete-forward-char, we use find-composition to get the extend of the >> current glyphs in terms of characters. AFAICT, find-composition does a >> forward search for the 'composition' text property. My proposal was >> that we write a find-composition variant that would do a backward search >> for the 'composition' text property which we then can make of use in >> delete-backward-char. > > You are looking at the wrong branch of the code. There's no > 'composition' text property in the case that is of interest to you; > the characters are composed by the so-called "automatic composition", > whereby Emacs decides which characters to compose without any special > text property. The relevant code is in find_automatic_composition, > which is called by find-composition-internal. My recollection of the find-composition-internal was that it eventually fell back to a text property search even for automatic compositions but I see now that's not the case. Thanks for setting me straight. > In any case, my suggestion for finding composition backward is to > incrementally go back and call find-composition-internal, until it > fails to find a composition at or before point. Thanks, I will see what I can do. > The next question will be: what would be the key to which you'd bind > this new command? I thought a user option that would make DEL delete by grapheme clusters would do the job. >> We cannot simply do backward-char then delete-forward-char and bind it >> to a command since IIRC the grapheme cluster movement happens in the >> display code? > > No, it happens in the command loop. See adjust_point_for_property, > which calls composition_adjust_point. I don't think this is important > for the issue at hand, because the point adjustment happens only after > interactive commands.