From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#58199: 29.0.50; Odd "git pull" output Date: Sat, 01 Oct 2022 15:37:03 +0200 Message-ID: <87h70nfyww.fsf@gnus.org> References: <87edvs4tb3.fsf@gnus.org> <83ill4d7ti.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38491"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58199@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 01 15:39:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oechx-0009oq-Gb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Oct 2022 15:39:09 +0200 Original-Received: from localhost ([::1]:34320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oechw-0006QK-Jn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Oct 2022 09:39:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oecgt-0005OZ-N6 for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 09:38:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oecgs-0007KY-Qi for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 09:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oecgs-0005RU-Lc for bug-gnu-emacs@gnu.org; Sat, 01 Oct 2022 09:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Oct 2022 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58199 X-GNU-PR-Package: emacs Original-Received: via spool by 58199-submit@debbugs.gnu.org id=B58199.166463143720834 (code B ref 58199); Sat, 01 Oct 2022 13:38:02 +0000 Original-Received: (at 58199) by debbugs.gnu.org; 1 Oct 2022 13:37:17 +0000 Original-Received: from localhost ([127.0.0.1]:43990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oecg9-0005Px-18 for submit@debbugs.gnu.org; Sat, 01 Oct 2022 09:37:17 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oecg6-0005Ph-Rr for 58199@debbugs.gnu.org; Sat, 01 Oct 2022 09:37:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yvy/YYFScUI+1nYf1Jxs3qPChzpp4GjjLPNs4m2fVm8=; b=o9u5/Rm6x8LF1r8H4+tERi4yG2 jJCytwqG1sEE2KryXDdRiWjwUUA/KsTUjH6y7KvLYwhhpVZiTXnVMcJPxat1erOmqQ0Eo0xaBGOiA kzeM0sU4g7W2lTzdKmaPlP24cD73gQflpkv1ssCnN1R+aftwQmh60Gdt5wDHixupekjc=; Original-Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oecfy-0004Xk-8L; Sat, 01 Oct 2022 15:37:08 +0200 In-Reply-To: <83ill4d7ti.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 30 Sep 2022 21:40:41 +0300") X-Now-Playing: Django Django's _Django Django Meets The Professor_: "Silver Rays" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244126 Archived-At: Eli Zaretskii writes: >> Those ^M characters look ugly. Should the filter process here do >> something about those? Or are they part of some ANSI control character >> sequence that's not parsed correctly, perhaps? > > No ANSI control sequences: that's Git overwriting its own output with > later output, for aesthetic reasons. We should convert those ^M > characters to newline, I think. Right. Hm... looking at the VC code, I see that vc-do-command sets a filter `vc-process-filter' that's trivial -- I had expected that there would be some mangling of the output already in there somewhere... Oh, OK, I see that the backends do stuff like (add-function :around (process-filter proc) #'vc-cvs-annotate-process-filter) so I guess the fix here would be to make vc-git-pull do something similar. I'll give it a go.