From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 58199@debbugs.gnu.org
Subject: bug#58199: 29.0.50; Odd "git pull" output
Date: Sat, 01 Oct 2022 15:37:03 +0200 [thread overview]
Message-ID: <87h70nfyww.fsf@gnus.org> (raw)
In-Reply-To: <83ill4d7ti.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 30 Sep 2022 21:40:41 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Those ^M characters look ugly. Should the filter process here do
>> something about those? Or are they part of some ANSI control character
>> sequence that's not parsed correctly, perhaps?
>
> No ANSI control sequences: that's Git overwriting its own output with
> later output, for aesthetic reasons. We should convert those ^M
> characters to newline, I think.
Right.
Hm... looking at the VC code, I see that vc-do-command sets a filter
`vc-process-filter' that's trivial -- I had expected that there would be
some mangling of the output already in there somewhere...
Oh, OK, I see that the backends do stuff like
(add-function :around (process-filter proc)
#'vc-cvs-annotate-process-filter)
so I guess the fix here would be to make vc-git-pull do something
similar.
I'll give it a go.
next prev parent reply other threads:[~2022-10-01 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 18:21 bug#58199: 29.0.50; Odd "git pull" output Lars Ingebrigtsen
2022-09-30 18:40 ` Eli Zaretskii
2022-10-01 13:37 ` Lars Ingebrigtsen [this message]
2022-10-01 13:41 ` Lars Ingebrigtsen
2022-10-01 13:52 ` Eli Zaretskii
2022-10-01 14:08 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h70nfyww.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=58199@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).