From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation Date: Mon, 12 Dec 2022 23:37:24 +0100 Message-ID: <87h6y0nt97.fsf@gmail.com> References: <83iliiv0yv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10700"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jim Porter , Eli Zaretskii , Stefan Monnier , 59956@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 23:38:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4rRA-0002cF-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 23:38:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4rQz-0002eW-Kw; Mon, 12 Dec 2022 17:38:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rQx-0002d2-0P for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4rQw-00077r-O8 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4rQw-0005A5-2U for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59956 X-GNU-PR-Package: emacs Original-Received: via spool by 59956-submit@debbugs.gnu.org id=B59956.167088465419827 (code B ref 59956); Mon, 12 Dec 2022 22:38:02 +0000 Original-Received: (at 59956) by debbugs.gnu.org; 12 Dec 2022 22:37:34 +0000 Original-Received: from localhost ([127.0.0.1]:55858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rQT-00059j-Ni for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:37:33 -0500 Original-Received: from mail-ej1-f46.google.com ([209.85.218.46]:34513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rQR-00059Z-J6 for 59956@debbugs.gnu.org; Mon, 12 Dec 2022 17:37:31 -0500 Original-Received: by mail-ej1-f46.google.com with SMTP id t17so32062728eju.1 for <59956@debbugs.gnu.org>; Mon, 12 Dec 2022 14:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ptx7cY9M02mdbiAxONk2nw1YP7TksZfQTnNMKaH2PEk=; b=lhEyJyLkSolg+MBLxfBLuRguAv3tx8+sAngRzZvxWWyHwm9GuiDAkRFhOyd+4DIHu8 YdCI7UlXPaiKgdygxrgEKx2XpLP0PKW2Fh9WUDUsGeASMj6ZGipYJMvrccJqP8x/QF+N WOiXSRkgGC2ZUQJG6KZqX3obuwfvuCTL1+r9LObORYlT7ev1TcdbK50NNHKaV1x54KQN Dgs5mCdao5odc5gna20AneiFFoLpo9K8JL9mWmNWApob79/5exyOQdSOW5uG1EMmHina BA+4rCAzJAGzDYQxZ/Iraybr8BVTKbX0SuSyitm8bNI6FbhECM5QIZLRn19915LOUEsb zA4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ptx7cY9M02mdbiAxONk2nw1YP7TksZfQTnNMKaH2PEk=; b=kIl44X8LwB5s8QleYw4XQWvTWMpotnurp10Mgg5eT0ewYDZzYanmGun/3LKlVrB9us Tx8t7J7jDWtiJbI85J010sebetCCgFaYya+BFixTmdwMFh3jUbD2c0uj5fbazDy5HOS1 3MY24Qct1HG7Fx5j7VB0XqJOqScE7F7F8qUDFVFbU5WKOSD2DPYrfWMplW3CcUeBF8ri xtbtwO1LKk8M9owR70dhgCcOa97VtNWurX1O4YUmHpP5WH6GBLzIaftNTJxoGwBKb73j UtOmXlx1rMpi4VylDvUcwhDZkMI4cfECqFXQWLPy7/TZypHFapzgB+jkXMZMmAP98Lhb oWWw== X-Gm-Message-State: ANoB5pmu1igK7EIVeNycdHn8piAI6OYt3dJNcqAPFCGZCEWEHlDAKsjq 8JSXuc/5tjVzorfSGr+spM8yPTbZBL5T6w== X-Google-Smtp-Source: AA0mqf5/zDUbpzXMmg5+6vqmH85GjB8BPWbFZWRXJwKw8KHk11IPzlW1X4Rly/nKdvdYRKcGgpVumQ== X-Received: by 2002:a17:907:c295:b0:78d:f455:c398 with SMTP id tk21-20020a170907c29500b0078df455c398mr3555826ejc.62.1670884645416; Mon, 12 Dec 2022 14:37:25 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::911f]) by smtp.gmail.com with ESMTPSA id ku3-20020a170907788300b007c18598a2f3sm528960ejc.196.2022.12.12.14.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 14:37:24 -0800 (PST) In-Reply-To: (Gregory Heytings's message of "Mon, 12 Dec 2022 22:21:03 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250763 Archived-At: On Mon, 12 Dec 2022 at 22:21, Gregory Heytings wrote: >>> Starting from "emacs -Q -f -eshell", type "echo $exec-path " (note >>> the trailing space), and then hit TAB. The result is this error: >>> >>> pcomplete-match: Wrong type argument: stringp, ("/usr/bin" ...) >>> >>> This is a regression from Emacs 28, and it looks like it's due to >>> 'pcomplete-here-using-help' assuming that all the pcomplete args >>> are strings. However, 'exec-path' is a list (and Eshell reports it >>> this way to pcomplete), so the completion fails. I think all that's >>> necessary is checking that the pcomplete args are strings in >>> 'pcomplete-here-using-help', but I know next to nothing about >>> pcomplete... >> >> Adding Stefan, who should know more about pcomplete. >> >> Stefan, any suggestions? >> > > I'm still not Stefan, but this bug is fixed by the attached patch. This is not a fix to the problem, in my opinion. Just take any other command with a pcomplete rule, say "cvs $exec-path SPC TAB" and you will see the same problem.