From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Date: Fri, 03 Feb 2023 09:00:48 +0100 Message-ID: <87h6w3ch5b.fsf@thornhill.no> References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> <831qn7w7m9.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15700"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jostein@secure.kjonigsen.net, casouri@gmail.com, 61104@debbugs.gnu.org, jostein@kjonigsen.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 03 09:01:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNr0S-0003sf-CZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Feb 2023 09:01:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNr0L-0006eb-5E; Fri, 03 Feb 2023 03:01:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNr0I-0006X7-So for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 03:01:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNr0I-0000uP-FZ for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 03:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNr0I-0006qi-4c for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 03:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 08:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs Original-Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167541125426308 (code B ref 61104); Fri, 03 Feb 2023 08:01:02 +0000 Original-Received: (at 61104) by debbugs.gnu.org; 3 Feb 2023 08:00:54 +0000 Original-Received: from localhost ([127.0.0.1]:36437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNr0A-0006qF-BG for submit@debbugs.gnu.org; Fri, 03 Feb 2023 03:00:54 -0500 Original-Received: from out-212.mta0.migadu.com ([91.218.175.212]:46811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNr07-0006q5-V3 for 61104@debbugs.gnu.org; Fri, 03 Feb 2023 03:00:53 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1675411249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hbwh2jx2/EoRvLwEsGlAltZyku/Jl29fcTU6Xb4Fhcw=; b=xU+mRnQ7AqkQCDlbNsTi6hvhu4LbDi7ZyS825X90oTySUyCBKiHqaGgBZE3cGTTrlHKU/a xLMS8joE5hdQCR27K3pFwddWsFzQ9OX+QkrMKGxUP0cq7aWDEjwzPE/1o81AN6Xp4nE/Cd s+GTl/xFaBBPyueS1mfRNtpnSexnmEs8m3hPMgRUxWoqEfqj43jkkNYZFypkOPS8ybyvF7 suyBEjF5TMyOa+e7GlB8iZ5Z93rjom7+wGX9MgS0z+PQDL+yOoD4gpe+9AW2fBvqmUdSf1 yYegSYweyvy/IFmw95wPY6zzo30qUeRgBRLlKd48d5Thzhofwt6E4tcQlD7wdQ== In-Reply-To: <831qn7w7m9.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254719 Archived-At: Eli Zaretskii writes: >> Date: Fri, 03 Feb 2023 06:30:29 +0100 >> From: Theodor Thornhill >> CC: 61104@debbugs.gnu.org, casouri@gmail.com >>=20 >> On 2 February 2023 22:01:11 CET, "Jostein Kj=C3=B8nigsen" wrote: >> >Any news on this one? Will this be merged? :) >> > >>=20 >> My guess is that it should go on master. I'll look at it today - sorry i= t took some time :) > > I'm okay with installing this on emacs-29 if the patch looks good. > Typescript mode is new in Emacs 29, so it's okay to make this change > now. But please be sure that the relevant tests still pass, i.e. that > this change doesn't break something else in compilation-mode. > > Thanks. Ok, I'll do that then. I'll add this in addition in the next commit, if that's ok. Thanks, Jostein and Eli :) Theo diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/com= pile-tests.el index 53dc7f2a13..22721563df 100644 --- a/test/lisp/progmodes/compile-tests.el +++ b/test/lisp/progmodes/compile-tests.el @@ -382,9 +382,13 @@ compile-tests--test-regexps-data ;; sun-ada (sun-ada "/home3/xdhar/rcds_rc/main.a, line 361, char 6:syntax error: = \",\" inserted" 1 6 361 "/home3/xdhar/rcds_rc/main.a") + (typescript-tsc-plain "/home/foo/greeter.ts(30,12): error TS2339: Prop= erty 'foo' does not exist." + 1 12 30 "/home/foo/greeter.ts") + (typescript-tsc-pretty "src/resources/document.ts:140:22 - error TS236= 2: something." + 1 22 140 "src/resources/document.ts") ;; 4bsd (edg-1 "/usr/src/foo/foo.c(8): warning: w may be used before set" - 1 nil 8 "/usr/src/foo/foo.c") + 1 nil 8 "/usr/src/foo/foo.c") (edg-1 "/usr/src/foo/foo.c(9): error: w is used before set" 1 nil 9 "/usr/src/foo/foo.c") (4bsd "strcmp: variable # of args. llib-lc(359) :: /usr/src/foo/foo.= c(8)" @@ -495,7 +499,7 @@ compile-test-error-regexps (compilation-num-warnings-found 0) (compilation-num-infos-found 0)) (mapc #'compile--test-error-line compile-tests--test-regexps-data) - (should (eq compilation-num-errors-found 98)) + (should (eq compilation-num-errors-found 100)) (should (eq compilation-num-warnings-found 35)) (should (eq compilation-num-infos-found 28))))) =20