From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic' Date: Thu, 23 Feb 2023 19:55:20 +0100 Message-ID: <87h6vcdxev.fsf@gmail.com> References: <87pmffd8ya.fsf@gmail.com> <874jrjf276.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18911"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58141@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 23 19:56:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVGlJ-0004ba-P0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Feb 2023 19:56:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVGlG-0003rA-UY; Thu, 23 Feb 2023 13:56:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVGl9-0003cG-IY for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 13:56:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVGl8-00043X-GF for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 13:56:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVGl8-0008PN-B9 for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 13:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Feb 2023 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58141 X-GNU-PR-Package: emacs Original-Received: via spool by 58141-submit@debbugs.gnu.org id=B58141.167717852932276 (code B ref 58141); Thu, 23 Feb 2023 18:56:02 +0000 Original-Received: (at 58141) by debbugs.gnu.org; 23 Feb 2023 18:55:29 +0000 Original-Received: from localhost ([127.0.0.1]:35336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVGkb-0008OW-87 for submit@debbugs.gnu.org; Thu, 23 Feb 2023 13:55:29 -0500 Original-Received: from mail-ed1-f47.google.com ([209.85.208.47]:40713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVGka-0008OF-0k for 58141@debbugs.gnu.org; Thu, 23 Feb 2023 13:55:28 -0500 Original-Received: by mail-ed1-f47.google.com with SMTP id i34so20493691eda.7 for <58141@debbugs.gnu.org>; Thu, 23 Feb 2023 10:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=OtYwQKNdy05IOL43hiwEaMSPb/byfSwRDrA+Yr/MhcU=; b=kQihV9Xd8XPllWzJ2OeEoJ6qtMuVPy4LwIJk9Wa5E3r6773z2A1+IFhN4aCEh7y5YT peajDHXpzZXt4abwO46qJN1m9wu8N2tZnem3zQtHGb4eWkMudJ0GuUOc2F0Zk2u6EL8b Mw+/v6VRkZg8iq2EqDZRsFRXAREiXBSEHfRkGvvovek8vK+G2TINrdJNtQeP27cpCtHK Qx2VSq78ZT9B0KBhnQ5UsS0ubWomWr/dhwWSCKJ+8bSW6xES4e0cq/gnnwD7ZgSmIy1V hZoyKS4Jpk5xQVZ3NZ0ADfsHA7I5Zpp8QS3aQHqEduxfNeMzK07xauvd6zDIvbmS8+IJ K/Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OtYwQKNdy05IOL43hiwEaMSPb/byfSwRDrA+Yr/MhcU=; b=BdLMY+gBPq9j53ENfYkMmNGhVJbOPnw8rZ+9JbAiHt6EUH+yeVQY5m1MD1RXJjXBpb ++56mqKltJp3ES3HNeXfa7+fYj1sWtxJ3wudIFkScRhQICAF6SFJgRMLJJ6Q5CKyFSb9 /Z6fjlsO8zOSxfYXizlAYFqifVH2avpxigZu6kEVAJTGUw0Z2evdrlySFJHjTaQq4LTj oh3UZRQk23PcTdYuOJwGGY6kZiCC5v/ko7pOdiRo8y+fMIU0VKVEo9AskmPGUpb54Hxz XkHCPyBM4z54BDZ9Ao/UwzNbqlgiOCeLXwAffJrWYlcUDyP/ini04caAP7PA1gb7Iedg 1JRg== X-Gm-Message-State: AO0yUKW4YnE51zqO5EvYSha8jbFD+CkKNRJ+7kVHQMT9pZzzPph3Mx0W LCn+oINEdVBx1ONy+tmHuG2unvLzm88= X-Google-Smtp-Source: AK7set9RbzFbZTp2srSZXXk9ydDUGfRsKzCY51A0Unlhp53rOnngGHEkprrbUXvebBydfjQOa0+PbQ== X-Received: by 2002:aa7:c651:0:b0:4ad:7b13:969b with SMTP id z17-20020aa7c651000000b004ad7b13969bmr10491488edr.27.1677178522187; Thu, 23 Feb 2023 10:55:22 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id n1-20020a50c201000000b004af6e957b22sm1028326edf.6.2023.02.23.10.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 10:55:21 -0800 (PST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 23 Feb 2023 11:59:29 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256515 Archived-At: On Thu, 23 Feb 2023 at 11:59, Jo=C3=A3o T=C3=A1vora wrote: > I'm not a fan of hardcoding colors in Eglot, since that needs themes > to update for the new face. Supporting the optional underline is > probably fine, though. Okay, but the current choice (inherit from shadow) is also not a safe one with respect to themes. So I'd say the next best thing is to make that face inherit from flymake-note or flymake-warning.