From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Fri, 24 Feb 2023 13:14:49 +0100 Message-ID: <87h6vb9s5i.fsf@gmail.com> References: <87a614g628.fsf@gmail.com> <83cz60r7hu.fsf@gnu.org> <875ybsfvtj.fsf@gmail.com> <831qmgr17p.fsf@gnu.org> <87wn48ecdz.fsf@gmail.com> <83v8jspgnr.fsf@gnu.org> <87lekodxja.fsf@gmail.com> <83a614p4sh.fsf@gnu.org> <87cz60dus9.fsf@gmail.com> <835ybrpnqj.fsf@gnu.org> <87y1oncz09.fsf@gmail.com> <83r0ufo3uc.fsf@gnu.org> <87356vbf0b.fsf@gmail.com> <87wn479vj7.fsf@gmail.com> <87pm9z9tfi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2778"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61726@debbugs.gnu.org, Eli Zaretskii To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 24 13:15:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVWyk-0000Yy-WF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Feb 2023 13:15:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVWyf-0001G9-E0; Fri, 24 Feb 2023 07:15:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVWyd-0001F5-Fi for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 07:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVWyc-0004sH-F3 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 07:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVWyc-0007aT-23 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 07:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2023 12:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.167724089929146 (code B ref 61726); Fri, 24 Feb 2023 12:15:02 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 24 Feb 2023 12:14:59 +0000 Original-Received: from localhost ([127.0.0.1]:36203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVWyZ-0007a2-C3 for submit@debbugs.gnu.org; Fri, 24 Feb 2023 07:14:59 -0500 Original-Received: from mail-ed1-f41.google.com ([209.85.208.41]:36459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVWyY-0007Zm-01 for 61726@debbugs.gnu.org; Fri, 24 Feb 2023 07:14:58 -0500 Original-Received: by mail-ed1-f41.google.com with SMTP id da10so55269025edb.3 for <61726@debbugs.gnu.org>; Fri, 24 Feb 2023 04:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pYcfOoizcGR0l0q4OG6ZDpfAr2qBWYCWeukmVPeTQ7k=; b=po8XxZF0zim6X4AdKWTVeAHAg5uwWDznwKtJykBLIhRUCU+aR0sChIQ7TmKLn7LRLL 2xbCDruVeOnaU0QZ0cewrtY9skrCBMbqW838pQtRvkjXADMLuYGUYPgzRN7oOYFytBvI glztK69ZY0QVuCMFQ0BFo3c+2ESxYrRJeN2JipGDHTpoHB7sUOeUQTKz0HMEnA6tWR/T OVc3QZvJ59k10EUL6Kpaqp3b6G65QuM7IfK/g1hBLekYSYq24GeX6uvrzhxqFu1Ts5NX HcnrwKDnooLC8+zvXeKWyr4cyyW+rZjhqIi8MrL6LDRKHgjhNbHJYmASFH1gf7ljlSDT /HXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pYcfOoizcGR0l0q4OG6ZDpfAr2qBWYCWeukmVPeTQ7k=; b=F91b6JAEBQuEEwg0nbn+MjDrR8PRsqCmO7nwlLm4VS22srkF/oUffjFIlQ2nNK+2ek iy0HL12mVYSD4ozfGJKsSB70iGOygTunaKaMjDHMjgp/NYYhkqzvfMzOXSushAytsplK BMXy55ThN0q+O3nmtsjw+dRdQXz6feiaPtoU03fG3tPugTkODzeVjWTKpaNINXKh5lph pwxBZz5qMFJ9Pmct5mquhnZu6aRBycZagoMKnRibZZWXK4v/kZm+QpOGxsMe1u9ojSRT hf3e8s+N/dEnnpcfCm2p2keu0rX7inyuHeyqrYU1LdA8vu/cDpRvAUBdg/Ul6UdxtYfN MZcA== X-Gm-Message-State: AO0yUKWuJ+nCZyJxrxvTx+10JhuYWhGiIJsOBIAZ9i4T1frW5Rxg81OA v+5OcX4SqVKInsOZVfHgr1TuYKZQ6wE= X-Google-Smtp-Source: AK7set9yp2/zeMNE90lMZUequdwBQXScyvwKN6QBe496UlgrSTN4fQF3P/uWmbx3MrsvpHbpqiZUSA== X-Received: by 2002:aa7:c1cc:0:b0:4ad:7204:6968 with SMTP id d12-20020aa7c1cc000000b004ad72046968mr13239488edp.32.1677240891781; Fri, 24 Feb 2023 04:14:51 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id z5-20020a509e05000000b004ad03b18ae3sm5614961ede.62.2023.02.24.04.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 04:14:51 -0800 (PST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 24 Feb 2023 12:05:07 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256579 Archived-At: On Fri, 24 Feb 2023 at 12:05, Jo=C3=A3o T=C3=A1vora wrote: > What IMO makes your solution more complex is that the new alternate > place of caching will not cause eglot-move-to-column-function and > eglot-current-column-function to be deleted. We can't delete, even > if we wanted to, because of backward compatibility. If you could, > I would agree that our two solutions are of similar complexity. But > that's not the reality. You might have missed it in this long thread, but my proposal was to obsolete eglot-move-to-column-function and eglot-current-column-function now and remove them in after several Emacs releases. The rationale is that these vars were introduced to work around nonconforming servers. With the new LSP capability, there should be no excuse for nonconforming servers to exist. They should all adapt in the medium term. So yes, I have no problem admitting my approach looks uglier today, but it's clear to me that it would lead to a cleaner result in 2030.