From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Date: Thu, 02 Mar 2023 16:51:59 +0100 Message-ID: <87h6v3jgm8.fsf@ledu-giraud.fr> References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25474"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61816@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 02 16:53:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXlF1-0006OS-Bd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Mar 2023 16:53:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXlEw-0007tB-5X; Thu, 02 Mar 2023 10:53:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlEs-0007sp-RS for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 10:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXlEr-00063Q-Qc for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 10:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXlEr-00059R-Mx for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 10:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2023 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61816-submit@debbugs.gnu.org id=B61816.167777232519737 (code B ref 61816); Thu, 02 Mar 2023 15:53:01 +0000 Original-Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 15:52:05 +0000 Original-Received: from localhost ([127.0.0.1]:58162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlDx-00058G-6u for submit@debbugs.gnu.org; Thu, 02 Mar 2023 10:52:05 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:14742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlDu-00057i-PJ for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 10:52:03 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=lv351A0B MNGfF6+u1fKJrivVSg0tV09sGnn9AzTmiSA=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=Yh1h6ib0ldeEIeS7BbC3uu/DFduKET SxNiZYOA89RJTcDNjkvH5DUjUpiI/khinZHC7Tdxd/VtM8jAoqv36fBg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=lv351A0BMNGfF6+u 1fKJrivVSg0tV09sGnn9AzTmiSA=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Uhw9Z4EqwUMy0dhBWJUPzZ/2qAM9vCcPAVrzvd YCXPqYS/rIqLUrwbSYFTOjYvq8kCCqCeVJck8KCj/SDX4voG0imN2YJGUqX8qO1InCCtG0 HaGAyCoy8fJO11zvFZnx9AJ/I3tIGGDMsPbCTyY9d9fUvPV4xCMmyRIi4WR/GRQDE85GKH kOOIA1BD3KxTHKYTLrCFYKxYEyG64qSpY/bWD2XLcS3wZUDAy2I/pV1GYsSHLxJWiXTXXp 8YXsECvkxWkUDYQlc8/g3w4q/ZRvG3niHeg3RPL9czMvrjbpQCYuJf37qpWlE0M/8ATV9+ Wm7keOviXgKtHZaiW8I6jXtw== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 7eca2234 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Mar 2023 16:52:01 +0100 (CET) In-Reply-To: <87lekfjh4q.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Thu, 02 Mar 2023 16:40:53 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257167 Archived-At: Manuel Giraud writes: > Eli Zaretskii writes: > > [...] > >> You are right, of course. It just feels strange to need to cater to >> themes in a core package, when the way themes are supposed to >> customize Emacs exists and can be used in this case as well. >> >> Alternatively, maybe themes should have settings for features such as >> this one? > > Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the > official Emacs themes for a start, WDYT? ... and in order to be able to use 'custom-theme-set-faces', we could have a 'doc-view-svg-face' (used only for its foreground and background). I'm caching you up slowly =F0=9F=98=85 --=20 Manuel Giraud