From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node Date: Sat, 11 Mar 2023 07:52:40 +0800 Message-ID: <87h6usf9kn.fsf@yahoo.com> References: <9FCDA5B7-D216-45B1-8051-35B05633BEFB@gmail.com> <83sfeukwsb.fsf@gnu.org> <574817C4-3FD8-43EA-B53C-B2BCB60A6D0A@gmail.com> <83mt51j6mv.fsf@gnu.org> <83a60xhou5.fsf@gnu.org> <83mt4wfvpd.fsf@gnu.org> <83fsaofp0x.fsf@gnu.org> <83v8jgaeqy.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21605"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , mickey@masteringemacs.org, casouri@gmail.com, 60237@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 11 00:53:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pamY5-0005Pl-Jk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Mar 2023 00:53:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pamXo-0001Ij-JE; Fri, 10 Mar 2023 18:53:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pamXn-0001Ib-US for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 18:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pamXn-00083X-Il for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 18:53:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pamXl-0000F5-N3 for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 18:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2023 23:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60237 X-GNU-PR-Package: emacs Original-Received: via spool by 60237-submit@debbugs.gnu.org id=B60237.1678492379917 (code B ref 60237); Fri, 10 Mar 2023 23:53:01 +0000 Original-Received: (at 60237) by debbugs.gnu.org; 10 Mar 2023 23:52:59 +0000 Original-Received: from localhost ([127.0.0.1]:56142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pamXi-0000Ei-OZ for submit@debbugs.gnu.org; Fri, 10 Mar 2023 18:52:59 -0500 Original-Received: from sonic308-10.consmr.mail.ne1.yahoo.com ([66.163.187.33]:33378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pamXf-0000EJ-UN for 60237@debbugs.gnu.org; Fri, 10 Mar 2023 18:52:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678492368; bh=9EjMTqXFVU3Jtz2AuAUuUUaOPKZNwG5u00L6xbFx+LE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=QZHy6n7aRdkXlOzW97g8IhB9rejHCw+E14VNZogM6StKvuLM47Q37gfvapImzcn0uP1yU+A5+ES8ZuvRnzdZ5PbUzLIeImSmabBL25XlqLDoYoKC3HLctemYtlQuxvX3IFYsr21VLNbenoNIrsy+a+3YrxVpV2hSpjOsZKDb+lHDOIRJjXTAJjE6xXEKEnFKNlnVSLcosUMG5goVf9WGKk+MNa+oIDM71aU4YkDB5IYpCOUsXsJhBO/eomzMoEpA+g2Fza6t1QyS1Gt7NPUwcpd6rRDecfNp70np3SXCrgInYn97W9Ubmk16YpuciMecngw4pJzivxiN3k4O9XIbTg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678492368; bh=S87FYlPZ+Ypo6eXLZceRLJsufAX3AEYyApXiVLuW2K/=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=fbw+pznPwcu8W2wfjAz6Jd/0GgEYJwsH9PSwk0gl2gDNY1fHtClDYSzfwBOdzNzhZBmLK7lheXyzzledLZNEiDqeynEFdQkgEN7nLh1WESvlEz8ZLukbUvLDELY2/2jwcsuKyIR/hyucTAI+wJUsZ1lMGmyZMcTyk25JgUj4/qosNE8NEs/rK77hTZvQyZQnjuZL0ZjJT0FxtO3TJeUPRbwMk4x/3TLFUcS/53unjA/zuldZA0Ob7G2y5pIQkM6e0l62oWGRkDcRcwXaC8EOAMXr1xwfvVsFJEVJUF6eW1pViLDn1K5RpsySyCSLZteQX/YIbNM3tEoAJ+Q7YXlUcA== X-YMail-OSG: YowuXOEVM1mxEwBbIM.jS1TgMUekX33q26.cnxg_e96PXAie9siPsUUiXCDgVj5 fmis1fDDkucMjCLso_lBDFc8LRreN0EopccgaqqQBbDZEWuqlBwT6ZwlYAAaxEcZj6JacwwrM_MR 8JPOwmI6z7XqSjzHcbP3DlHn2oIVxl8enJcW2jaiPFCIkivMx6H5A59apecqHBFDHpFEjfPXYZxu JL6woRVI_r34rpZgsuPndTdug8ABtH9DLnmuqpbXw0X2EGekPaKUU00cW3HnLrrOJmuosk3_goXU imgextTk47Jx5WMBrebWEif0aRd9XBfbvHY4offT5m3cthEeCivKsVG_BDw0AavPPMqvDoV21_LG 5A2R.bLtXREfnd_xygMZ2qsvr2kJMHfH11g6R8XhVLkI_J4Fp2tQc9NvwedC2POOdYhkE.5puBEl dJOAth4YK0bsss6smHuBtjbkhGG1SPz4jvPmIOTL5ItQvtLhNWT._t6YnxvuQwbnvzwac35wY3HE YFPNI9nMf0O5.74dSrXktG9jrouJIXwdimjBnsCBc_5qF_8ZB_mmhQVAoKTJ2pKrSDKNkji_4oEW wMRuhAUH5EBQDFlDaEmcymBDasN8gmUF6R9UvsAXkoHisLJ3b3I2rIoA8hW5PGwrfMSMTpk.TBHn Klkes2D0ueYKgP1ya8c12V8ev9jKtYj4TKJLQEVCAfJqsu6aCOnaKtgbqlg533GBBPDuqB9tBnHk zfW9mnacy2KtMycEXZTOdTzVu2N_sPCRLDjoKbzo4xNMTzugWFeaedLMItpzAQBwrYThCeJFiCRU MVyQTFrm5ocU6RFKblB.EOjG4ehYXyLmtBoXnsjvVF X-Sonic-MF: X-Sonic-ID: 79415aee-737c-4a4e-9c25-bea99cb994ed Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Fri, 10 Mar 2023 23:52:48 +0000 Original-Received: by hermes--production-sg3-67c57bccff-d5ptt (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 68233e667fffdbdd141df7b76be31c58; Fri, 10 Mar 2023 23:52:45 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Fri, 10 Mar 2023 13:28:20 -0500") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257734 Archived-At: Stefan Monnier writes: >>> I tried cargo-culting the cpu_gc_count stuff for the memory profiler, >>> see the patch below. However, something is amiss: this assertion in >>> profiler.el sometimes triggers: >>> >>> (maphash >>> (lambda (backtrace _count) >>> (let* ((max (1- (length backtrace))) >>> (head (aref backtrace max)) >>> (best-parent nil) >>> (best-match (1+ max)) >>> (parents (gethash head fun-map))) >>> (pcase-dolist (`(,i . ,parent) parents) >>> (when t ;; (<= (- max i) best-match) ;Else, it can't be better. >>> (let ((match max) >>> (imatch i)) >>> (cl-assert (>= match imatch)) <<<<<<<<<<<<<<<<<<<<<<<<<<<< >>> (cl-assert (function-equal (aref backtrace max) >>> (aref parent i))) >>> >>> I cannot reliably reproduce this, and don't understand what causes the >>> assertion. Any hints? >> >> Hmm... I just took a look but can't see neither why your change would >> be more likely to trigger this error than the existing code for the >> `cpu` case, nor why this assertion should always be true. > > I can imagine corner cases where this could trigger, but they all > involve funny business where we change `profiler-max-stack-depth` during > a single profiling run (I think you'd need to write ad-hoc ELisp code > for that). The only other explanation I can see is that we > somehow end up with a backtrace that includes `Automatic_GC` somewhere > not at the top (maybe this can happen with a `post-gc-hook`?). What about gc_in_progress? Why can't we use that? This should avoid everything related to post-gc-hook. Thanks.