From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#54406: 28.0.91; rcirc text wrapping Date: Sun, 30 Apr 2023 10:54:36 +0000 Message-ID: <87h6sxfxn7.fsf@posteo.net> References: <87lexac44t.fsf@redhat.com> <87h77yc0rt.fsf_-_@redhat.com> <8735jgvo12.fsf@gnus.org> <87r1703jb7.fsf@posteo.net> <871qqil4cs.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9363"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ken Raeburn , 54406@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 30 12:55:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pt4iE-0002FB-49 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Apr 2023 12:55:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pt4hz-0003Mp-Ka; Sun, 30 Apr 2023 06:55:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pt4hq-0003KH-L1 for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2023 06:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pt4hq-0002cp-Az for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2023 06:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pt4hq-0000ay-6H for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2023 06:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Apr 2023 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54406 X-GNU-PR-Package: emacs Original-Received: via spool by 54406-submit@debbugs.gnu.org id=B54406.16828520562072 (code B ref 54406); Sun, 30 Apr 2023 10:55:02 +0000 Original-Received: (at 54406) by debbugs.gnu.org; 30 Apr 2023 10:54:16 +0000 Original-Received: from localhost ([127.0.0.1]:37381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pt4h6-0000XH-7M for submit@debbugs.gnu.org; Sun, 30 Apr 2023 06:54:16 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:50947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pt4h1-0000WI-4q for 54406@debbugs.gnu.org; Sun, 30 Apr 2023 06:54:12 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 01E5D24027A for <54406@debbugs.gnu.org>; Sun, 30 Apr 2023 12:54:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682852045; bh=Xh3VA9BmxSYNERLrGGtO1U7emN2/7wBfEQviHXC/O8U=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=PdJAepgNGy20+zuIVYdhUfNDPnRRnos1xGZkO5fpYrIcwvzFgwUvjSu80GrjbD112 ZOYUCV+2lgM22tYas7dOUfG+m2lIbQa8RBQ8OmmJ6cc95/Pts7ZhC5ClK3lhSlQP+B g0cb7eDPzkPSxDFoMqTjNfM2o67NNzcNSso29VPBxn8BUIOGE/NYujwO0TY7bbGJXS FWywVhGwuqIRnetbopa7lfLWk8kW5TlAJ3DVitEQmnJp9bSZyqsabMsg3mQlHSnYt3 Bkl9Z5H6hwgnB8DX6deEzlZfpP7N9F+qZxkQOSxSMByvgl31i85fa4VqN7D0Nx68q6 7cCczPxgVBqmg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q8NWJ2wdhz9rxG; Sun, 30 Apr 2023 12:54:04 +0200 (CEST) In-Reply-To: <871qqil4cs.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 04 Nov 2022 22:52:35 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260833 Archived-At: Philip Kaludercic writes: > Philip Kaludercic writes: > >> Lars Ingebrigtsen writes: >> >>> Ken Raeburn writes: >>> >>>> The old version in 27.1 did: >>>> >>>> ;; squeeze spaces out of text before rcirc-text >>>> (fill-region fill-start >>>> (1- (or (next-single-property-change fill-start >>>> 'rcirc-text) >>>> rcirc-prompt-end-marker))) >>>> >>>> where fill-start is set to >>>> >>>> (marker-position rcirc-prompt-start-marker) >>>> >>>> evaluated before inserting the new text. The new version seems to be >>>> filling the entire narrowed region containing the just-inserted text. >>> >>> So I guess this was changed in: >>> >>> commit 849e71fd83fa8796198035464897bf2f28f6226c >>> Author: Philip Kaludercic >>> AuthorDate: Wed Jun 9 17:55:55 2021 +0200 >>> >>> I've added Philip to the CCs; perhaps he has some comments. >> >> It seems this was just a misunderstanding on what the "squeeze"-code >> does. The reason it had to be changed is so that messages with >> time-stamps could be received out-of-order. I am guessing (but would >> have to look into it in more detail) that the intention could be >> implemented more elegantly than by calling fill-region on a specific >> region. > > The call has been removed with b2283409fbe4324ee2fb50b385a9b6cc3458693c. > Should we close the report or does Ken want to try it out first to > confirm that everything works? Ping?