From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#62116: RFE: eglot: support window.showDocument LSP RPC Date: Tue, 09 May 2023 19:03:07 +0200 Message-ID: <87h6sla14k.fsf@betli.tmit.bme.hu> References: <87jzznxx8f.fsf@gmail.com> <83fsabwhpg.fsf@gnu.org> <87v8j7vy48.fsf@gmail.com> <83r0tuv62t.fsf@gnu.org> <874jp8gu8a.fsf@betli.tmit.bme.hu> <838re3jowg.fsf@gnu.org> <87ttwqsow9.fsf@gmail.com> <87ttwpbpaj.fsf@betli.tmit.bme.hu> <875y93arek.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: sebastian.poeplau@mailbox.org, adonovan@google.com, 62116@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 09 19:04:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwQkw-0005aV-2K for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 May 2023 19:04:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwQku-0004am-3l; Tue, 09 May 2023 13:04:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwQkt-0004Yi-19 for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 13:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwQks-0005c5-I0 for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 13:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwQks-0007mi-E2 for bug-gnu-emacs@gnu.org; Tue, 09 May 2023 13:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 May 2023 17:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62116-submit@debbugs.gnu.org id=B62116.168365179729869 (code B ref 62116); Tue, 09 May 2023 17:04:02 +0000 Original-Received: (at 62116) by debbugs.gnu.org; 9 May 2023 17:03:17 +0000 Original-Received: from localhost ([127.0.0.1]:44329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQk9-0007lf-9N for submit@debbugs.gnu.org; Tue, 09 May 2023 13:03:17 -0400 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:46296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQk7-0007lL-J1 for 62116@debbugs.gnu.org; Tue, 09 May 2023 13:03:16 -0400 Original-Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3063afa2372so5654070f8f.0 for <62116@debbugs.gnu.org>; Tue, 09 May 2023 10:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683651789; x=1686243789; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=mYAza1N0+YwTTOKCbVrc6yYBquaDmy3tOS83yoKEgig=; b=XRnWd3Ms66EyUXPgDZHPhU1j6XXl3S0Gcgs7uiSz+0RlNN1xFodEar9rgRsSL0JvBD 0Rf2xXWfCtjTakJZOcbih6t/DJGuEvpHm5hRznm8zsw50QHKeZU9peNMgxSt2bEb82l+ k+K4jlfD1vPZIrX0Ze69wmA/JZ0IjyhucVpT9sAYE9wR9e3+M2KglwR82If0d7zgkjgl /iHuOVDqLCmEs6QB+OyorDHmceTfRC4QB+6JdmQniowsSJW5+hrIkwT5qpMRXpJq3L1p TbwYpIM4TSY7mz+CW3eHNdNpn9cWxOGOMvWB6DwQwzBWO+n8VTr2vFuGjaM6+C48WePK vKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683651789; x=1686243789; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mYAza1N0+YwTTOKCbVrc6yYBquaDmy3tOS83yoKEgig=; b=TADBRy39EVcFqXJJZF5RXrrc3Je8YGI5glrlqQPpALpycDk325lwLORUNagF7svsT/ 4KONwI2HTD7krAGnkjynwu+ISBgfFh2t87VtOeC/Cujmw3S9Oyf0JQSToKKhBoPQ3XAE h2RxzVmzuLyui6dl5/5FKy0cRRMMKmZGPqIess0c9cf7qhaiQ7hsmgZxjK/T12yF+Sa9 peoNnOfopPcIfhHkrJBQc7VZb7SifnVSqv4VPr/CQa6I2pU9/BEY1PGNokO8kHVepR3p TR6WvS92WAen0WSGrTVHD3+s65ZAcUG8Rqm4z4E/+5VEvMrh0feKCivzG534zUg2feR2 GexA== X-Gm-Message-State: AC+VfDxUiCaFovTX0qIFcos6U8lWynLmypJAGP0egDuyraAN0zocpx9w fwoLAymWKbwOxOHU6vMnaiA= X-Google-Smtp-Source: ACHHUZ4d62E5867BzvQ2+xx90gWDmvOR33FUZesJS8AwPGF3o7+KDtrfZ6RLCQye0x8iY76rpAGLpQ== X-Received: by 2002:adf:edc6:0:b0:306:337e:4b28 with SMTP id v6-20020adfedc6000000b00306337e4b28mr11022321wro.3.1683651789257; Tue, 09 May 2023 10:03:09 -0700 (PDT) Original-Received: from betli.gmail.com (catv-89-134-210-182.catv.fixed.vodafone.hu. [89.134.210.182]) by smtp.gmail.com with ESMTPSA id s7-20020a1cf207000000b003f1733feb3dsm20376136wmc.0.2023.05.09.10.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 10:03:08 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 8 May 2023 17:36:43 +0100") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261434 Archived-At: Jo=C3=A3o T=C3=A1vora writes: >> Since it advances the status quo, can this be merged? If not, how >> should we proceed? > > Haven't looked at it, but I'd say yes. However, Alan Donovan > has replied recently, with a recipe showcasing his particular > use case. I dont' have time to try it right now, but if you > could try his recipe/use case with your solution, it would be > great. It requires to patch and recompile gopls, which would be too much effort for me, unfortunately. > One note that I didn't yet reply to is that IMO (likely in Alan's > opinion too), it does make sense to raise the frame. The > showDocument may indeed come from somewhere else which is not > Emacs at all. I used to work with Common Lisp IDEs like that > allowed the application being developed to issue requests to > the editor and pop it up to the user. It was extremely convenient. I've looked into this. The docstring of x-focus-frame says "If there is no window system support, this function does nothing." However, this command emacs -Q -nw --eval "(x-focus-frame nil)" errors out instead of doing nothing. But supporting the frame raising feature is approximately as simple as (let ((frame (window-frame (get-buffer-window buf t)))) (raise-frame frame) (x-focus-frame frame)) However, I don't work with multiple frames, so I don't know whether the all-frames parameter of the get-buffer-window should really be t. I hope the latest patch can be merged as is, and someone with more experience with multiple frames can later step in and provide an additional patch for this extra feature. Thanks.