From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Date: Wed, 10 May 2023 11:21:42 -0700 Message-ID: <87h6skqc7d.fsf@ericabrahamsen.net> References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <87y1m2w2s5.fsf@ericabrahamsen.net> <87ild6vwxp.fsf@ericabrahamsen.net> <875y96oulf.fsf@linux-m68k.org> <87bkixwg68.fsf@ericabrahamsen.net> <87pm7dnyor.fsf@igel.home> <873548wuwe.fsf@ericabrahamsen.net> <83pm786v4m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20320"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 10 20:22:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwoSF-00053B-KE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 May 2023 20:22:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwoRx-0005Bi-NJ; Wed, 10 May 2023 14:22:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwoRv-0005B1-LA for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 14:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwoRv-0003a3-AV for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 14:22:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwoRv-0006QT-5P for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 14:22:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 18:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs Original-Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168374291324671 (code B ref 62845); Wed, 10 May 2023 18:22:03 +0000 Original-Received: (at 62845) by debbugs.gnu.org; 10 May 2023 18:21:53 +0000 Original-Received: from localhost ([127.0.0.1]:49008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwoRl-0006Pq-8V for submit@debbugs.gnu.org; Wed, 10 May 2023 14:21:53 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:38912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwoRi-0006Pc-NZ for 62845@debbugs.gnu.org; Wed, 10 May 2023 14:21:51 -0400 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 1ECC6FA01F; Wed, 10 May 2023 18:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683742904; bh=H7TKIctaR7cB6hVYWScR5IRKok5Pf0iTPntCrzJ2jKE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ab79GpLLDw4vFgdhLTmELYLpgR+QkhppDLEsOASZAyfV2T3f/5tGzoldbVTRB20Cc GOZu5JKN4sBpn5UuyX53asUimREok1lOpX7lOJsAlkjkL27aBKgpXi4Dpsd25KwUXT Vc+9HnosodET1WtMf5O+mtUkBOh85dTeE6OttESs= In-Reply-To: <83pm786v4m.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 May 2023 18:53:13 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261526 Archived-At: On 05/10/23 18:53 PM, Eli Zaretskii wrote: >> From: Eric Abrahamsen >> Cc: Eli Zaretskii , 62845@debbugs.gnu.org >> Date: Sat, 06 May 2023 22:52:17 -0700 >> >> >> On 05/06/23 19:43 PM, Andreas Schwab wrote: >> > On Mai 06 2023, Eric Abrahamsen wrote: >> > >> > You cannot recreate a buffer once it is killed. You can create a new >> > buffer, but it will always be a different buffer. >> >> But `nntp-possibly-change-group' re-initializes `nntp-server-buffer' to >> a new buffer, and the `nntp-find-connection-buffer' inside >> `nntp-retrieve-group-data-early' uses the value of `nntp-server-buffer' >> to find its process. My reading is that each time the with-open-group >> function runs, its `bodyfun' lambda should get a new opportunity to find >> a live `nntp-server-buffer'. >> >> Plus, if the buffer were already dead the second time through, >> `nntp-retrieve-group-data-early' has sufficient guards to simply bail >> before doing anything. >> >> I'm not trying to be stubborn here, I assume your analysis is >> essentially right, I'm just trying to make sure I actually understand >> what's happening in the code. >> >> Even if it does require two timeouts in a row, I get that plenty often >> with a `nntp-connection-timeout' value of 6. > > Eric, any progress here? > > If no better ideas are ready to be implemented, I think we should > revert that commit on emacs-29 and leave it on master, where work on > fixing this fallout should continue. OK? Yeah, I haven't made much progress in the time I've had to look at this (and I still don't completely understand the current error!). I think the commit should be reverted on both emacs-29 and master. It was there to fix an inconvenience (an nntp failure would halt a Gnus refresh at the top level), but it caused an actual bug (Gnus messes with the contents of random buffers). Better to go back to the inconvenience until a fuller solution is found. Thanks, Eric