bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content

[Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> Hi,
>
> FTR, there is a thing that does not work with this "thumb name based on
> content": upon rotation the thumb is not updated properly.
>
> This comes from the fact that the image content has changed (obviously)
> so the new thumb will have a new name and is not displayed in the
> *image-dired* buffer 😅.  I'd have to find a way around it.

Hi,

So here is a patch that fixes this issue.  Thanks.
-- 
Manuel Giraud

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-thumbnail-update-when-thumb-name-is-based-on-ima.patch --]
[-- Type: text/x-patch, Size: 3111 bytes --]

From 5716e77a61a7a7459a00e266c4d6236be48c02c4 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Tue, 1 Aug 2023 18:56:33 +0200
Subject: [PATCH] Fix thumbnail update when thumb name is based on image
 content

* lisp/image/image-dired-util.el
(image-dired-update-thumbnail-at-point): New function to update
thumbnail when original image contents changed.

* lisp/image/image-dired-external.el
(image-dired-rotate-original): Use it.

* lisp/image/image-dired.el (image-dired-display-thumbs): Fix
spacing while here.
---
 lisp/image/image-dired-external.el |  3 ++-
 lisp/image/image-dired-util.el     | 15 +++++++++++++++
 lisp/image/image-dired.el          |  2 +-
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/lisp/image/image-dired-external.el b/lisp/image/image-dired-external.el
index 9f35e17a7e6..77352c25a3b 100644
--- a/lisp/image/image-dired-external.el
+++ b/lisp/image/image-dired-external.el
@@ -405,7 +405,8 @@ image-dired-rotate-original
                 (not image-dired-rotate-original-ask-before-overwrite))
             (progn
               (copy-file image-dired-temp-rotate-image-file file t)
-              (image-dired-refresh-thumb))
+              (image-dired-refresh-thumb)
+              (image-dired-update-thumbnail-at-point))
           (image-dired-display-image file))))))
 
 \f
diff --git a/lisp/image/image-dired-util.el b/lisp/image/image-dired-util.el
index 3f6880fc807..1114f50477c 100644
--- a/lisp/image/image-dired-util.el
+++ b/lisp/image/image-dired-util.el
@@ -190,6 +190,21 @@ image-dired-image-at-point-p
   "Return non-nil if there is an `image-dired' thumbnail at point."
   (get-text-property (point) 'image-dired-thumbnail))
 
+(defun image-dired-update-thumbnail-at-point ()
+  "Update the thumbnail at point if the original image file has been
+modified.  Take care of uncaching and removing the old thumbnail
+file."
+  (when (image-dired-image-at-point-p)
+    (let* ((file (image-dired-original-file-name))
+           (thumb (expand-file-name (image-dired-thumb-name file)))
+           (image (get-text-property (point) 'display)))
+      (when image
+        (let ((old-thumb (plist-get (cdr image) :file)))
+          (unless (string= thumb old-thumb)
+            (clear-image-cache old-thumb)
+            (delete-file old-thumb)
+            (setf (plist-get (cdr image) :file) thumb)))))))
+
 (defun image-dired-window-width-pixels (window)
   "Calculate WINDOW width in pixels."
   (declare (obsolete window-body-width "29.1"))
diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el
index 96a0c2ef9bc..7b0059e2f7a 100644
--- a/lisp/image/image-dired.el
+++ b/lisp/image/image-dired.el
@@ -590,7 +590,7 @@ image-dired-display-thumbs
 `image-dired-previous-line-and-display' where we do not want the
 thumbnail buffer to be selected."
   (interactive "P" nil dired-mode)
-  (setq image-dired--generate-thumbs-start  (current-time))
+  (setq image-dired--generate-thumbs-start (current-time))
   (let ((buf (image-dired-create-thumbnail-buffer))
         files dired-buf)
     (if arg
-- 
2.40.0