unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#68076: [PATCH] lisp/textmodes/remember.el: Remove org-remember support
@ 2023-12-28 11:02 Ihor Radchenko
  2023-12-28 13:47 ` Eli Zaretskii
  2023-12-30  7:46 ` Eli Zaretskii
  0 siblings, 2 replies; 3+ messages in thread
From: Ihor Radchenko @ 2023-12-28 11:02 UTC (permalink / raw)
  To: 68076; +Cc: bzg

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Tags: patch

Hi,

org-remember has been removed from Org mode very long time ago.
So, there is no reason to keep org-remember-related options in remember.el.


In GNU Emacs 30.0.50 (build 7, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.18.0) of 2023-12-25 built on localhost
Repository revision: 147ae00df849f04cdb00e09d8079533fa5dea98a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101009
System Description: Gentoo Linux

Configured using:
 'configure --with-native-compilation'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-textmodes-remember.el-Remove-org-remember-suppo.patch --]
[-- Type: text/patch, Size: 1876 bytes --]

From 5c04030059e6ef616a6a2a2fc669e0eef9fe4a79 Mon Sep 17 00:00:00 2001
Message-ID: <5c04030059e6ef616a6a2a2fc669e0eef9fe4a79.1703761240.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Thu, 28 Dec 2023 11:58:42 +0100
Subject: [PATCH] lisp/textmodes/remember.el: Remove org-remember support

org-remember has been removed from Org mode proper and then from
org-contrib 10 years ago in
https://git.sr.ht/~bzg/org-contrib/commit/be8736195e
---
 lisp/textmodes/remember.el | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el
index 84a0185f7b5..b4d1ea6c919 100644
--- a/lisp/textmodes/remember.el
+++ b/lisp/textmodes/remember.el
@@ -185,7 +185,7 @@ remember
 (defcustom remember-mode-hook nil
   "Functions run upon entering `remember-mode'."
   :type 'hook
-  :options '(flyspell-mode turn-on-auto-fill org-remember-apply-template))
+  :options '(flyspell-mode turn-on-auto-fill))
 
 (defcustom remember-in-new-frame nil
   "Non-nil means use a separate frame for capturing remember data."
@@ -210,8 +210,7 @@ remember-handler-functions
   :options '(remember-store-in-mailbox
              remember-append-to-file
              remember-store-in-files
-             remember-diary-extract-entries
-             org-remember-handler))
+             remember-diary-extract-entries))
 
 (defcustom remember-all-handler-functions nil
   "If non-nil every function in `remember-handler-functions' is called."
@@ -235,7 +234,7 @@ remember-save-after-remembering
 (defcustom remember-annotation-functions '(buffer-file-name)
   "Hook that returns an annotation to be inserted into the remember buffer."
   :type 'hook
-  :options '(org-remember-annotation buffer-file-name))
+  :options '(buffer-file-name))
 
 (defvar remember-annotation nil
   "Current annotation.")
-- 
2.42.0


[-- Attachment #3: Type: text/plain, Size: 224 bytes --]


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#68076: [PATCH] lisp/textmodes/remember.el: Remove org-remember support
  2023-12-28 11:02 bug#68076: [PATCH] lisp/textmodes/remember.el: Remove org-remember support Ihor Radchenko
@ 2023-12-28 13:47 ` Eli Zaretskii
  2023-12-30  7:46 ` Eli Zaretskii
  1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-12-28 13:47 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: bzg, 68076

> Cc: bzg@gnu.org
> From: Ihor Radchenko <yantar92@posteo.net>
> Date: Thu, 28 Dec 2023 11:02:09 +0000
> 
> org-remember has been removed from Org mode very long time ago.
> So, there is no reason to keep org-remember-related options in remember.el.

Thanks, feel free to install on the master branch.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#68076: [PATCH] lisp/textmodes/remember.el: Remove org-remember support
  2023-12-28 11:02 bug#68076: [PATCH] lisp/textmodes/remember.el: Remove org-remember support Ihor Radchenko
  2023-12-28 13:47 ` Eli Zaretskii
@ 2023-12-30  7:46 ` Eli Zaretskii
  1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-12-30  7:46 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: bzg, 68076-done

> Cc: bzg@gnu.org
> From: Ihor Radchenko <yantar92@posteo.net>
> Date: Thu, 28 Dec 2023 11:02:09 +0000
> 
> org-remember has been removed from Org mode very long time ago.
> So, there is no reason to keep org-remember-related options in remember.el.

Thanks, now installed on the master branch, and closing the bug.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-30  7:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-28 11:02 bug#68076: [PATCH] lisp/textmodes/remember.el: Remove org-remember support Ihor Radchenko
2023-12-28 13:47 ` Eli Zaretskii
2023-12-30  7:46 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).