From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#69237: 30.0.50; Toggle password visibility Date: Thu, 22 Feb 2024 22:30:48 +0000 Message-ID: <87h6i0xhbb.fsf@gmail.com> References: <87zfw0ttyp.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7647"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: michael.albinus@gmx.de To: 69237@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 22 23:33:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdHco-0001jW-9E for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Feb 2024 23:33:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdHcO-0003Cd-OR; Thu, 22 Feb 2024 17:32:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdHcN-0003CD-5p for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 17:32:39 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdHcM-0004fA-Te for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 17:32:38 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdHck-0003Hd-0d for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 17:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Feb 2024 22:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69237 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Michael Albinus , 69237@debbugs.gnu.org Original-Received: via spool by 69237-submit@debbugs.gnu.org id=B69237.170864114912512 (code B ref 69237); Thu, 22 Feb 2024 22:33:01 +0000 Original-Received: (at 69237) by debbugs.gnu.org; 22 Feb 2024 22:32:29 +0000 Original-Received: from localhost ([127.0.0.1]:36709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdHc9-0003Fd-UI for submit@debbugs.gnu.org; Thu, 22 Feb 2024 17:32:29 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:61813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdHc4-0003F0-AD for 69237@debbugs.gnu.org; Thu, 22 Feb 2024 17:32:24 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4125df3c40aso1795885e9.3 for <69237@debbugs.gnu.org>; Thu, 22 Feb 2024 14:31:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708641051; x=1709245851; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vQYK2dAKe89+ZxvaQurGeE4vke8q77RwUpOjSRLikwY=; b=cgoEOnoVhbAw/DDnR0Zd7gdbdscJpatgCgaxwssYcoc367PjNvgIteKHi3QMGtxBrC EpeFbd6Aqxl6miHwTkJ1HpiMHr7xH/XqK3KJIqz0CR+Sc+3ol9ccrm7CxY5wxSeMueV+ V/96Rt6E/ekXJ6HLIt9F896ub/MjofHMh8yDIebzO3oS4h8NrQsqJzbo5x11JfOVDwb7 qLjiL7g6M1K7868KWLJoPixVjehxcdz7rWESh/8lSH6zDSAqv5uz8VoaiBi7G8WzYr43 D/bQzptd+o70V85aGCqzMjojo0fhjrjM6eZQ2Eu0/OH3QCcgTZZVQ0IlZ62g455HCvY8 cNkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708641051; x=1709245851; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vQYK2dAKe89+ZxvaQurGeE4vke8q77RwUpOjSRLikwY=; b=YW6mw/6vV15p26cjLeJe1QIvlC3t3qsa5zNIYIYEycVaQjVjlENh8WUBgVlKCU9t26 3gmX/102mfSXnrcOXRQAenFWL9EF6W7RANzyLk7mNTtMbu/7/11jxnDJLBJ1fAJKCrik kR251IsE8Wjti4cr3EnQ0hnFzovf6Srp4+vUhaJ+O4aFerduP4LC1mJbeDIOHPI3zPOM zONX/ir6GREpr304z46aMKhz5eTJe0310kJMQVuUzyEMZuq+pEcpYxY+oGoAw0FUcY12 0xBbt/l39cys1sUGThGTXUc9gH7EPbzBEfN+kToErqudJxRetMtMxZ3e1AtVw9ALTxVJ DIhA== X-Gm-Message-State: AOJu0Yy0lO8nNyLH8wC7t2tyePp26JWI85I1mm21uwxlbV/tCh5hexG8 VNyZJaB9rz1trdnZwRc7r/9SoXhpS9K8yDowU4AZOk9zJv4EI9px X-Google-Smtp-Source: AGHT+IHZ2+Ss2GOunq1n1or/r1IfykxqFPY3geszs/IY+QAJJHZehZhL6Ihe993VBlL4ybLHEXFTBg== X-Received: by 2002:a05:600c:218b:b0:412:16d8:d565 with SMTP id e11-20020a05600c218b00b0041216d8d565mr61737wme.15.1708641050698; Thu, 22 Feb 2024 14:30:50 -0800 (PST) Original-Received: from hirondell ([194.42.239.18]) by smtp.gmail.com with ESMTPSA id g8-20020a056000118800b0033d8871acc3sm368832wrx.77.2024.02.22.14.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 14:30:49 -0800 (PST) In-Reply-To: <87zfw0ttyp.fsf@gmx.de> (Michael Albinus via's message of "Fri, 16 Feb 2024 14:33:02 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280476 Archived-At: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > We have `read-passwd', which reads a password in the minibuffer, hiding > the input. However, modern password input boxes outside Emacs allow to > show/hide the input while typing. > > The appended patch tries to implement this feature. The minibuffer in > `read-passwd' has bound TAB to a function, which toggles visibility of > the typed input. > > On graphic displays, the mode-line has an additional indicator for > whowing/hiding the typed password. Clicking on this indicator with > mouse-1 toggles the password visibility. > > Comments? Thank you so much for working on this! I've had my own half-baked implementation of this for months; never took the time to polish it up and submit. No strong feelings re. keybindings; I've been using C-c C-c because I wanted something easy to mash, but TAB fits that criterion as well. Not sure we can leverage any well-established mnemonic from other keymaps; FWIW=E2=80=A6 * TAB could be familiar to some outline users, but they'll probably associate that binding to (un)folding, not necessarily hiding/revealing; * hideshow has multiple bindings for "toggle-hiding", so not sure we can count on any single one having enough "mindshare". (Not too worried about needing to input TAB verbatim - I tend to naturally reach for C-q TAB when I need to do that, since in most contexts Emacs has a useful command bound to TAB instead of self-insert-command) Other than the keybinding, the only other musing I have is regarding the indicator: wondering if icons.el could help trim some of the boilerplate down. In any case, it would give the user some degree of control over how the indicator is shown (via the icon-preference option) even if we don't provide 'emoji nor 'symbol variants. Not overly familiar with that library though - if that's something you think might be worth looking into, the define-icon forms in outline.el might help you assess how helpful the library would actually be.