From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#70134: [PATCH] Show all date options when adding Gnus scores interactively Date: Wed, 22 May 2024 19:50:24 -0700 Message-ID: <87h6ep8cnj.fsf@ericabrahamsen.net> References: <87v835edkg.fsf@kubajecminek.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18018"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: "70134@debbugs.gnu.org" <70134@debbugs.gnu.org>, Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= , Eli Zaretskii , "larsi@gnus.org" , Richard Stallman To: Alex Bochannek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 23 04:51:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s9yYA-0004TR-0B for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 May 2024 04:51:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9yXm-0006t1-Ur; Wed, 22 May 2024 22:51:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9yXg-0006qp-Cy for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 22:50:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9yXg-00039J-28 for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 22:50:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9yXl-0004uo-Sq for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 22:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 May 2024 02:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70134 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70134-submit@debbugs.gnu.org id=B70134.171643264218888 (code B ref 70134); Thu, 23 May 2024 02:51:01 +0000 Original-Received: (at 70134) by debbugs.gnu.org; 23 May 2024 02:50:42 +0000 Original-Received: from localhost ([127.0.0.1]:58305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9yXR-0004ua-VR for submit@debbugs.gnu.org; Wed, 22 May 2024 22:50:42 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:46902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9yXO-0004uU-Nq for 70134@debbugs.gnu.org; Wed, 22 May 2024 22:50:40 -0400 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id B4BEFFA01F; Thu, 23 May 2024 02:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1716432626; bh=NWemTCH9FhbZVXMOzyYlR8BTS/8nIBqEAMc7GtAycJ0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=yx9vB9DyVOpmfnnSYhZfJE7Jk0rX02nRE06dDZpAkfi928Kfd4kLne34e0HdZEFEK IKhQfB59908jhdRxv4J40BRTAPtXHUPjnzHDrCCCfYcsDvQ6o5cCDDhUV00jz994jI JET5hxA1CA+u0/aQo58KRdgRGNlFW+x/+VbQ6aL4= In-Reply-To: (Alex Bochannek's message of "Wed, 22 May 2024 16:30:07 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285667 Archived-At: Alex Bochannek writes: > Jakub, > > Jakub Je=C4=8Dm=C3=ADnek writes: > >> Ping :). Is there anything else that needs to be resolved before this is >> installed? We can create different subtask for the bug that Alex pointed >> out. > > I did some testing again and the functionality you describe works > perfectly fine. I still would prefer the bug I pointed out to be fixed > before merging. > > My concern is that with the change applied, adding a new date-header > scoring rule interactively will rewrite some existing date rules in the > SCORE file. Expectedly not just entries created interactively, but any > entries in the list regardless of how they were created. In my testing, > I found this to be the case for all entries that are not using the new > match types for dates (i.e, for `before', `after', and `at', not for > `r', `<', or `>'.) > > I am perfectly happy to be overruled, I just think it will be confusing > to the users. If however a patch for this is forthcoming quickly, I am > OK with merging it. Can we maybe hoist the `copy-sequence` up into the caller, to get a similar effect?