From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Eli Zaretskii <eliz@gnu.org>, 71049@debbugs.gnu.org
Subject: bug#71049: async-shell-command ends with "Process *Async Shell Command* finished" when remote "direct-async-process"
Date: Wed, 29 May 2024 19:42:24 +0200 [thread overview]
Message-ID: <87h6egecqn.fsf@gmx.de> (raw)
In-Reply-To: <0ebb5a51-8634-4f65-a384-79f82592e339@gutov.dev> (Dmitry Gutov's message of "Wed, 29 May 2024 20:26:26 +0300")
Dmitry Gutov <dmitry@gutov.dev> writes:
> Okay, to summarize the previous messages:
Thanks. For Eli, I summarize the essential of my proposal.
> async-shell-command calls shell-mode, which loads the history file by
> calling comint-read-input-ring.
>
> shell-setup-input-ring.diff extracts the comint input ring setup to a
> separate function. That function is then only called by 'shell', but
> not by 'shell-mode' itself anymore, or any of its descendants. Any
> callers or descendants of it that actually need this setup (I'm not
> aware of any, but they might exist) will need to adapt by adding this
> call.
>
> shell-no-start-prog.diff does not move the logic, but predicates its
> execution on the value of the variable shell--start-prog being
> non-nil. In-tree it's only set by 'shell', so the result is the
> same. The "how to adapt" recipe would be setting shell--start-prog to
> non-nil (in callers).
shell-mode is changed to obey the existing tramp-histfile-override in
the remote case, which tells whether to use the default history file,
another history file (you can give the file name), or to suppress the
history file at all. Like many Tramp methods, you can customize it via
connection-local variables. I made also the proposal to suppress reading
the remote history file for shell-command by default (performance!);
every user can change the config of course.
Best regards, Michael.
next prev parent reply other threads:[~2024-05-29 17:42 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-19 0:19 bug#71049: async-shell-command ends with "Process *Async Shell Command* finished" when remote "direct-async-process" Dmitry Gutov
2024-05-19 6:17 ` Eli Zaretskii
2024-05-19 12:40 ` Dmitry Gutov
2024-05-24 11:15 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-24 14:06 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-24 14:50 ` Eli Zaretskii
2024-05-24 16:39 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-24 18:55 ` Eli Zaretskii
2024-05-24 19:20 ` Dmitry Gutov
2024-05-25 10:49 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 13:54 ` Dmitry Gutov
2024-05-25 15:51 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 16:17 ` Dmitry Gutov
2024-05-25 17:00 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 17:31 ` Dmitry Gutov
2024-05-25 17:44 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-26 14:18 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 1:59 ` Dmitry Gutov
2024-05-29 7:41 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 11:55 ` Dmitry Gutov
2024-05-29 15:19 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 11:53 ` Eli Zaretskii
2024-05-29 11:57 ` Dmitry Gutov
2024-05-29 12:46 ` Eli Zaretskii
2024-05-29 17:26 ` Dmitry Gutov
2024-05-29 17:42 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-29 18:15 ` Dmitry Gutov
2024-05-29 18:38 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 20:40 ` Dmitry Gutov
2024-05-30 8:49 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 0:24 ` Dmitry Gutov
2024-05-31 5:53 ` Eli Zaretskii
2024-05-31 16:24 ` Dmitry Gutov
2024-05-31 18:05 ` Eli Zaretskii
2024-06-01 1:21 ` Dmitry Gutov
2024-06-01 6:07 ` Eli Zaretskii
2024-06-01 15:33 ` Dmitry Gutov
2024-06-01 15:47 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 1:39 ` Dmitry Gutov
2024-06-02 8:36 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 14:10 ` Dmitry Gutov
2024-06-02 14:46 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 15:01 ` Dmitry Gutov
2024-06-02 17:31 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 7:27 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 12:13 ` Dmitry Gutov
2024-05-29 18:11 ` Eli Zaretskii
2024-05-25 17:10 ` Eli Zaretskii
2024-05-25 7:23 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-24 17:17 ` Dmitry Gutov
2024-05-24 17:41 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-24 17:50 ` Dmitry Gutov
2024-05-24 18:09 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 13:03 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 14:40 ` Dmitry Gutov
2024-05-25 15:26 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6egecqn.fsf@gmx.de \
--to=bug-gnu-emacs@gnu.org \
--cc=71049@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).