From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems Date: Thu, 05 Sep 2024 15:48:12 +0200 Message-ID: <87h6auw6sj.fsf@ledu-giraud.fr> References: <87le083m1s.fsf@ledu-giraud.fr> <877cbqjt03.fsf@posteo.net> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38551"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73004@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 05 15:49:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smCrH-0009rJ-QF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Sep 2024 15:49:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smCr5-0003MV-Oz; Thu, 05 Sep 2024 09:48:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smCr3-0003Ly-CY for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 09:48:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smCr3-0002na-2H for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 09:48:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=v7Imk326n2CuxvGdBCLmTCfXK1x5ki38+FvF4lR3Nds=; b=lw2h1IesNYUdmLEeLt7ksR0quj/ZzaQaUxwVfS5YGeQfS/LFfh4hvap5ynBjSR3fFZv7Fzf/9982DOr7+xEU0hzsNx4V0z6vgBDbvMAxde+JwA/EMFfIqeOJyoaayHwsMKCZSUXXkoB+Borpotf8vLLyzDWjnmgGKBmkq9A0VGINu/j+yFVjadjVjanDANtaSrztOW78dSx2ocrYutDIdTbeh4hv+9ZfrFC+mmijBpsRx9ZIv9sQ+svSzoOOjb0e+/mW1sOzyRTfsumweCVoGm9vfHdDiW3ljjHTvPPsRGPJCVXa6T6pcBKf0vyxR2VpOsTZyY0J/XoqYUa0FThJwA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smCs6-0002d9-3R for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 09:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2024 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73004-submit@debbugs.gnu.org id=B73004.17255441669985 (code B ref 73004); Thu, 05 Sep 2024 13:50:02 +0000 Original-Received: (at 73004) by debbugs.gnu.org; 5 Sep 2024 13:49:26 +0000 Original-Received: from localhost ([127.0.0.1]:36450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smCrV-0002az-VL for submit@debbugs.gnu.org; Thu, 05 Sep 2024 09:49:26 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:45380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smCrT-0002ao-9T for 73004@debbugs.gnu.org; Thu, 05 Sep 2024 09:49:24 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=4ZISbAiZ BQvLsFGkXdnJaygYggnP3NJGw/05phexJCM=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=KC+4T691HPSl8O39QZ5vx1aFDfgdHF MXIXT2fcwJ33DeKUWk3KFFwL5XoQ7Rv3U+ZJq6jJg5ECV9D+mgGFRrCg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=4ZISbAiZBQvLsFGk XdnJaygYggnP3NJGw/05phexJCM=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=kZzpT5h16e0EtTQzSGuk5BwrjEjp8uS+7566+T I6wWlNG+QA1VpuZoW1/mocLrWFsqMkCHno7Bg+gUh4b3oRS4uBPFind632sr09TLr78xhc OynkB1HuSMsxf/tDXHWmOGgbBUtEeoRrrkITwS/7ExwEqTJSl3PtK7h8rBAgRlML0GZiV/ vQQFWpf1fcxRrzubk00bNYixzgS938xG+kJ9nA9LudbC6sIuoHvVin4D6rfXMYyPJTL7WA lsgp0nGaimswjPHb4w7mjY+6YO+8/EbtrVIExauYYRklZyQ33iRdbcgG0xBnhh+TpIF6ug IXhpcb/pseN49lRoBLK4NL6g== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 87c8cf4f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 5 Sep 2024 15:48:12 +0200 (CEST) In-Reply-To: <877cbqjt03.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 05 Sep 2024 10:26:52 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291253 Archived-At: Philip Kaludercic writes: [...] >> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el >> index cd948bd7dd9..97b1e28a4ff 100644 >> --- a/lisp/dired-aux.el >> +++ b/lisp/dired-aux.el >> @@ -1472,7 +1472,7 @@ dired-do-open >> (when command >> (dolist (file files) >> (cond >> - ((memq system-type '(gnu/linux)) >> + ((memq system-type '(gnu/linux berkeley-unix)) > > Are these the only systems with xdg-open? I don't really know. I guess that FreeBSD and NetBSD also have ports of xdg-open. But I don't know for others "berkeley-unix". Anyway, this is less restrictive than just "gnu/linux". > And is xdg-open reliably available on BSD systems, so that we don't > generate an opaque error message if that is not the case? I think it would work whether xdg-open is install or not because `shell-command-guess-open' is defined by testing the presence of xdg-open. So if xdg-open is not installed, `command' in the code above will be nil and nothing will happen. -- Manuel Giraud