From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#73530: [PATCH] Add imenu index function for Djvu files in doc-view Date: Sat, 28 Sep 2024 21:15:31 +0200 Message-ID: <87h69zh9nw.fsf@gnu.org> References: <8734ljg6f5.fsf@gmail.com> <86msjr6ayu.fsf@gnu.org> <874j5ziudn.fsf@gnu.org> <87y13bel5m.fsf@gmail.com> <-wirQcNBR0cpaXo0jL0sp8CxUkFsFX_iWUm_BoGq4ChYLccOyN7QJN53eHf0Q-AncT65owrhqfPWYnnQO3gRHw==@protonmail.internalid> <87setjhcm6.fsf@gnu.org> <87zfnrzjl7.fsf@mail.jao.io> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20662"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.6; emacs 31.0.50 Cc: Eli Zaretskii , 73530@debbugs.gnu.org, Visuwesh To: jao Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 28 21:16:54 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sucw2-0005G9-4S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Sep 2024 21:16:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sucvi-0000is-OH; Sat, 28 Sep 2024 15:16:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sucvh-0000iR-5u for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2024 15:16:33 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sucvg-0001yT-B4 for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2024 15:16:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=TrH7fZXlVb7RnmyMLWDoTjeBuABSFdLWZVJlyD7ciKU=; b=HwY5x8AL7VOb5EE/mh54jqO2Ufe5ISGKGLE6wP453e/RLNsylORhYR9rxfwaGE4JmiqIfxmWW9sGK61a9JyWBZkCFg7J09hSGuA38ruidS7Ylm0Ui7OxmKGr11MqT/4iyXmQjMJ37eVr0smgO7qj74rmOglsuwRmd+M4XBEzIRq0kcFhzcIHhGefi0332KPLhrFDScSByYje6aXKpeLvFbbXvJZtL7zwU9xQ2LXfmdoIgJHYzBQVePOaLvnUSingqFPFVkq87oDkx1scQl7pX2SwrFCvB/plt7/QKmc8hzMva9uC1FM/dS+HahbrzNYAqbQx5XDwNpHshNvJeUjMHg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sucwA-00065T-0b for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2024 15:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Sep 2024 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73530 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73530-submit@debbugs.gnu.org id=B73530.172755097423160 (code B ref 73530); Sat, 28 Sep 2024 19:17:01 +0000 Original-Received: (at 73530) by debbugs.gnu.org; 28 Sep 2024 19:16:14 +0000 Original-Received: from localhost ([127.0.0.1]:40479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sucvO-00061T-H0 for submit@debbugs.gnu.org; Sat, 28 Sep 2024 15:16:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sucvM-000615-Pe for 73530@debbugs.gnu.org; Sat, 28 Sep 2024 15:16:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sucum-0001wq-II; Sat, 28 Sep 2024 15:15:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=TrH7fZXlVb7RnmyMLWDoTjeBuABSFdLWZVJlyD7ciKU=; b=b3CN0ulsK0TZuqn8UQYU C18ntaBkvNc+F0lK5vD6B/Z9VyzITjRuprVgZ/qoaJGb0sjaROIbH3+mdY8ByqeDis2PybdrsVahv oPGFzv4w7fx+rY1cXxOe++I8zL0Rz4d8Guq9TmAe6VOVEXWD/GM9TTZqAyym+WiHv3HoJu7LhaSog YS844ZHanMRakd0Md2OVRk1TfUv9i4m9hwhsC5oxqG4DCg0munAPx+1kNZlZ3nSmntodLoe+An/Pt dUhPrXkX13pn48Q8Yg7iaYInYdoxnXizH7spJ0PjYtrHiN+JEpbFwJsXN0TK4v+x5saZF+ugTlHeN IMiGkg/41AH30A==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdduuddgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne cuggftrfgrthhtvghrnhepleduvdegfeduvdejkeefteelgeetgfevhefhueffueffgeeh gfeufefgvdffgedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih hlrdhfmhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepjeefheeftdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiii esghhnuhdrohhrghdprhgtphhtthhopehvihhsuhifvghshhhmsehgmhgrihhlrdgtohhm pdhrtghpthhtohepjh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-Reply-To: <87zfnrzjl7.fsf@mail.jao.io> (jao@gnu.org's message of "Sat, 28 Sep 2024 20:03:48 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292602 Archived-At: jao writes: >>>>> doc-view-imenu-enabled > > If I recall correctly, that flag is there to save CPU cycles in case > users of doc-view are not interested in imenu. > > The PDF's outline is scanned using mutool when doc-view-mode is > activated if doc-view-imenu-enabled is true, and for big files that > can take a second or two. > > I am not sure why I didn't delay creation of the index, but it's > probably because there are menu entries to create and I didn't bother > to investigate deeper. Also, because I didn't want to see a pause the > first time imenu was invoked on a PDF. Thanks for explaining! > Admittedly, most of the time the pause is small enough to make all of > the above moot. I think I'd prefer to delay the creation of the index until imenu is invoked the first time and get rid of doc-view-imenu-enabled. If we really wanted to and the requirements are met, we could also run the index creation in an idle-timer. Probably not by default but maybe by adding and documenting a function one could add to doc-view-mode-hook for that purpose. Bye, Tassilo