From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Mon, 30 Sep 2024 07:46:46 +0800 Message-ID: <87h69ydnvd.fsf@melete.silentflame.com> References: <87zfo28fzu.fsf@zephyr.silentflame.com> <8d0b046e-4b29-4551-b421-e98e212a7b40@yandex.ru> <86msjxefkv.fsf@mail.linkov.net> <87cykt2gkl.fsf@zephyr.silentflame.com> <87jzf01bsk.fsf@zephyr.silentflame.com> <87y13dfgzz.fsf@melete.silentflame.com> <5e956e3b-5891-401a-a898-e339f52ea307@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39016"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73387@debbugs.gnu.org, monnier@iro.umontreal.ca, Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 30 01:48:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sv3er-0009wQ-1L for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Sep 2024 01:48:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sv3eU-0006qn-BP; Sun, 29 Sep 2024 19:48:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sv3eR-0006qN-CC for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 19:48:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sv3eQ-0003ud-KJ for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 19:48:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=FJAoLsqhQQmFbVZm0o5iQMOaCEEpwT0X4sEjUdgR0Uo=; b=CWm86HxQJFUy2fvrCHp08EqtRj+clxfRQUHWkV1H/UK9wNjY9bL40rFsZshwAV1KlewXgVdZkoEUTU5jgLi5uxUvT3yZdIRt6kj4ArYbjbc58SvzzdkthG5PJUzpAOLdciMaXyUYbyFfl8kVXbDeMj8OQSrcnZxeVmOK7/B+nOoNMvSuNCi95q0//fks1mosZO9masKZN3y1qVAjeaPgpxtOtHpan66WL8nSWzy30FqVYpb7HL4EceQIhsA5aJphA95YbBb8mYv23kL0dZ6ZdXY9LmSxvnVe9UDLapOREeIpsiUvOAYoVu1P/0LUVd/ryZwAKQKL8hlPj/pJULLPhA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sv3ew-0002Ab-FZ for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 19:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2024 23:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73387 X-GNU-PR-Package: emacs Original-Received: via spool by 73387-submit@debbugs.gnu.org id=B73387.17276536937950 (code B ref 73387); Sun, 29 Sep 2024 23:49:02 +0000 Original-Received: (at 73387) by debbugs.gnu.org; 29 Sep 2024 23:48:13 +0000 Original-Received: from localhost ([127.0.0.1]:42983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv3e3-00023F-GO for submit@debbugs.gnu.org; Sun, 29 Sep 2024 19:48:12 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:46886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sv3dV-0001sH-OO for 73387@debbugs.gnu.org; Sun, 29 Sep 2024 19:48:01 -0400 DKIM-Signature: a=rsa-sha256; b=sVPA9x9DJl1xmWULz5rCtvD2KwERizezm7Yx/nMNeZw7FOE8vBlNREdKMXm/huXNVJ2f4MC/V2imyH/iT4ruJ6j22/io5eXHz7tOvtEMiVNSee20JM4Twvzw5lfo/+ybP0SWc28XVo2mOfGOj3MRsxm3jL5RCf49QeGoYAtsjFlG/I79DIp+0z6cAx9RTQVt+0LQtZ6JE5pJ8UBahIf5Kg0SYgijGhtTZcgyWnEE1sxeDC8CjfocRF0rKBPF3XNlVf3TtDefhi+PPUzsIcL3jv0YfLF8JoeneTTavUpWiXaeY2LYbaYNVwpqyh7JTXh4s6ozK4HjjEDX8rOAHBVuBA==; s=purelymail1; d=spwhitton.name; v=1; bh=vr/NWKrT2vPUE5lLcAcxyIxQxha/3iwP2BJ9HUtfPiY=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=jxtOqiWGu05EGxzrv0vHFP+SJznwgDdDWFj4qSdFV2AJQs2d4kD04yuRhmM5a4THMWZsSydaIG18EB2o1MYBhRiAFHgX2Hxcwxf3xru1K3BtS9q5uFV3HSrJsGTfVb6X8xfOCjEFXtDzYFC2bAMqcp3jj25sR0Iq10Kq5ti4yS7VBiE40Xxf/tLYA/6CIt8Ic0vk1D2XpfGdfJpbyj4bR2KDMRzey+k7gM8eybgBq/WYapXKV8mCM+uRECuPQmvL58npIHbC2zt4snPKqVR/GJWmBCRAJpCLTRXlqXrnV8XAlcHMt0zNWf9+Sl+qtS5dpPZUpwx2BUMPFTMo4wzwQQ==; s=purelymail1; d=purelymail.com; v=1; bh=vr/NWKrT2vPUE5lLcAcxyIxQxha/3iwP2BJ9HUtfPiY=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73387@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1488085670; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 29 Sep 2024 23:46:50 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id BCAE57E0B3E; Mon, 30 Sep 2024 00:46:46 +0100 (BST) In-Reply-To: <5e956e3b-5891-401a-a898-e339f52ea307@yandex.ru> (Dmitry Gutov's message of "Fri, 27 Sep 2024 22:13:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292673 Archived-At: Hello, On Fri 27 Sep 2024 at 10:13pm +03, Dmitry Gutov wrote: >> What do you think about this: >> - add a command which does the kill-all-but-this-hunk (or hunks in >> region if mark active) thing -- it's generally useful. >> - make C-x v v on a narrowed buffer, by default, issue a message saying >> "Cannot commit patch when narrowed, consider " > > Or it would implement that previous alternative - using the modified buffer > string that's limited to the current narrowing. > > I'm somewhat concerned about supporting both approaches (how different are the > code paths going to be?), but if that's needed for usability, perhaps it's > okay. Hmm, I thought that we thought the modified buffer string approach was too messy. Would you mind outlining your proposal as a whole and how it differs from my most recent one? >> - add a user option that when non-nil means C-x v v on a narrowed buffer >> automatically widens, invokes the new command, and then commits. > > And/or Emacs could by default prompt whether it should do that. And that > prompting behavior could indeed be decided by a user option. > >> My thinking is that the latter behaviour is complex and so shouldn't be >> the default, but once you understand what's going on then there is a >> good chance you want to enable it. > > Maybe if the prompt is easy enough to understand, that will be fine... Yeah. -- Sean Whitton