From: Ihor Radchenko <yantar92@posteo.net>
To: Richard Lawrence <rwl@recursewithless.net>
Cc: 74994@debbugs.gnu.org, emacs-devel@gnu.org
Subject: bug#74994: Upstreaming org-element-ast (was: Improving Emacs' iCalendar support)
Date: Mon, 30 Dec 2024 17:16:11 +0000 [thread overview]
Message-ID: <87h66l2isk.fsf@localhost> (raw)
In-Reply-To: <87ttamtf7g.fsf@recursewithless.net>
Richard Lawrence <rwl@recursewithless.net> writes:
>> Richard, is there any specific reason why you had to make things from
>> scratch? May org-element-ast be changed to fit your needs?
> ...
> No, it was more that, as things stood, I wanted to wait and see what
> would happen with upstreaming org-element-ast. My idea was to make it
> easy to switch once that happened, but not to wait to make progress in
> the meantime, that's all.
org-element-ast is already a part of Emacs. The process of upstreaming
in this particular case is simply a question of (1) making the library
more useful outside Org mode; (2) renaming it.
Renaming is trivial.
The main question is making things usable outside Org mode.
And that's where your work is the most valuable.
So, it was me who is waiting for your input before upstreaming :)
> One thing about your question confuses me, namely:
>
>> ...instead implement a custom parser generator.
>
> As I understand org-element-ast, it basically just defines the parse
> tree representation and various accessors for working with it, not the
> parser itself. Was your suggestion that I could also use the Org parser,
> not just the parse tree representation? If so, then I misunderstood, and
> presumably more code is involved than is found in org-element-ast.el,
> right?
No, I did not mean that you should use org-element to generate parser.
I mostly referred to the way you implement the parser where part of the
parser configuration is stored in the AST. But I was reading your patch
very quickly and could have misunderstood something.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-12-30 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ed4dss2x.fsf@ohm.mail-host-address-is-not-set>
[not found] ` <87mshq9w5c.fsf@ohm.mail-host-address-is-not-set>
[not found] ` <86ed31j6zk.fsf@gnu.org>
[not found] ` <87ldx9vsnb.fsf@localhost>
[not found] ` <868qt8kj6f.fsf@gnu.org>
[not found] ` <87ikscx5io.fsf@localhost>
[not found] ` <867c8skhy6.fsf@gnu.org>
[not found] ` <87frngx4fx.fsf@localhost>
[not found] ` <864j3wkczm.fsf@gnu.org>
[not found] ` <87cyhg0zjz.fsf@localhost>
2024-12-29 20:19 ` bug#74994: Upstreaming org-element-ast (was: Improving Emacs' iCalendar support) Richard Lawrence
[not found] ` <87ttamtf7g.fsf@recursewithless.net>
2024-12-29 20:53 ` Richard Lawrence
2024-12-30 17:16 ` Ihor Radchenko [this message]
[not found] ` <87r05qtdm3.fsf@recursewithless.net>
2024-12-30 17:18 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h66l2isk.fsf@localhost \
--to=yantar92@posteo.net \
--cc=74994@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rwl@recursewithless.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).