From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#75354: (29.4; eww buffer is not displayed correctly when used from bookmark-jump ) Date: Wed, 08 Jan 2025 07:40:30 +0000 Message-ID: <87h669vjm9.fsf@posteo.net> References: <87zfk6eekc.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4477"; mail-complaints-to="usenet@ciao.gmane.io" To: 75354@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 08 08:35:24 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVQb5-00010Q-Mq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jan 2025 08:35:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVQap-0003bS-7P; Wed, 08 Jan 2025 02:35:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVQam-0003ZM-1O for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 02:35:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVQak-0006OG-Jj for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 02:35:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=R9yGG5SNESMa95K6zz0GrrHOmMSOIZZkgDJzkf0mkEs=; b=PHoBVgbxZw7wlgSFWb1dj7QkTVM49/j4R9KiKX+Efu5aRIBFIbR+FQucD6nGksO4A/qmVmskNIi+n2xI3jRWlHoQxaAyByNtGVw8ugwm2dcTilgccbzUQvSMYvTq7iwaME7T0wWnkGuGsgKnkr7M0B2/u5mIT7ig7wRhJGtNUg/gykylUArt6XWWbj9Pl+H630Zy+wPIbjoaCSLQNek2NOiLuI6QEkvjNTTz8uFIyQBs3fBCUjhJIFJC13GmKsSMalINChkOA6sDwIqD9bbmaTmD06M6UGXGVbmgRbMC+xFGGcJydFZHiK7XxwgLIoeBY0b8zwPMxRMZHWK0H7ZSeQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVQak-0003DO-8H for bug-gnu-emacs@gnu.org; Wed, 08 Jan 2025 02:35:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87zfk6eekc.fsf@posteo.net> Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2025 07:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75354 X-GNU-PR-Package: emacs Original-Received: via spool by 75354-submit@debbugs.gnu.org id=B75354.173632166712307 (code B ref 75354); Wed, 08 Jan 2025 07:35:02 +0000 Original-Received: (at 75354) by debbugs.gnu.org; 8 Jan 2025 07:34:27 +0000 Original-Received: from localhost ([127.0.0.1]:45825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVQaB-0003CR-9B for submit@debbugs.gnu.org; Wed, 08 Jan 2025 02:34:27 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:36815) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVQa6-0003C6-OQ for 75354@debbugs.gnu.org; Wed, 08 Jan 2025 02:34:25 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3E8FC240101 for <75354@debbugs.gnu.org>; Wed, 8 Jan 2025 08:34:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1736321656; bh=3+cMcg/3IhlzhXxj/hX3tmIIJaCAFpbfta1AxXPQAg0=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=lgM5pV4brFCawo9/Rr5FE+ObT3W3SRYSVsAcDLX5Ev5ZWFPRx2sW3JOSWelPPW5fe g5ydm8QqW/bXrI07bLOdVoVnt8rRfnYr6cbxQUmNdN6LtPkY+9W9abi6X3qYM1HWHe ZAZOqUHXLjdWXBYu5ZjGh2CdEcEobbCNfNBY0/90H5pO24Tidz7fB/Jpe+JcTWAAWY Kbub5+cV7j7ixhyZHiO7xjRj2UxC2cU5LLL/yBmzb0XyJusvM6gmy0/c87Pao4ExkQ YwJ3HtX524bG9m4y4J5xTOSLiKLUHESuWA8k/wZC8fJI6mt5HosK4Xylt3JZA6t/xf X3lfvSE5QaMGg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YSfn238Vsz6twC; Wed, 8 Jan 2025 08:34:14 +0100 (CET) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298761 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I could fix the problem by modifying bookmark--jump-via: diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 0048330e790..a474bed652e 100644 =2D-- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1261,28 +1261,29 @@ DISPLAY-FUNCTION is called with the current buffer = as argument. After calling DISPLAY-FUNCTION, set window point to the point specified by BOOKMARK-NAME-OR-RECORD, if necessary, run `bookmark-after-jump-hook', and then show any annotations for this bookmark." =2D (bookmark-handle-bookmark bookmark-name-or-record) =2D ;; Store `point' now, because `display-function' might change it. =2D (let ((point (point))) =2D (save-current-buffer =2D (funcall display-function (current-buffer))) =2D (let ((win (get-buffer-window (current-buffer) 0))) =2D (if win (set-window-point win point)))) =2D ;; FIXME: we used to only run bookmark-after-jump-hook in =2D ;; `bookmark-jump' itself, but in none of the other commands. =2D (when bookmark-fringe-mark =2D (let ((overlays (overlays-in (pos-bol) (1+ (pos-bol)))) =2D temp found) =2D (while (and (not found) (setq temp (pop overlays))) =2D (when (eq 'bookmark (overlay-get temp 'category)) =2D (setq found t))) =2D (unless found =2D (bookmark--set-fringe-mark)))) =2D (run-hooks 'bookmark-after-jump-hook) =2D (if bookmark-automatically-show-annotations + (let (buf) + (save-window-excursion + (bookmark-handle-bookmark bookmark-name-or-record) + (setq buf (current-buffer))) + (let ((point (with-current-buffer buf (point)))) + (funcall display-function buf) + (when-let ((win (get-buffer-window buf 0))) + (set-window-point win point))) + ;; FIXME: we used to only run bookmark-after-jump-hook in + ;; `bookmark-jump' itself, but in none of the other commands. + (when bookmark-fringe-mark + (let ((overlays (overlays-in (pos-bol) (1+ (pos-bol)))) + temp found) + (while (and (not found) (setq temp (pop overlays))) + (when (eq 'bookmark (overlay-get temp 'category)) + (setq found t))) + (unless found + (bookmark--set-fringe-mark)))) + (run-hooks 'bookmark-after-jump-hook) + (when bookmark-automatically-show-annotations ;; if there is an annotation for this bookmark, ;; show it in a buffer. =2D (bookmark-show-annotation bookmark-name-or-record))) + (bookmark-show-annotation bookmark-name-or-record)))) =20 =20 ;;;###autoload =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmd+K+8THHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk0UDC/9KNf2QifiGR/ZsSNc1Ztg3XHGxhXAW NX/2hYbL5fxlB1HZ9VK9VAjv+BsSPjOHJELBBwIrqxX4NBUwpp53GXAzOqM784dE +1iihcx6M8HANuUTVdCGIVeSJ3VjNwuNipZpToFAsIsYsqkCBLRryZ+pvhHXkzP5 EcZhj5PsNmSEYqiT36P+6r44ZHs/b3ijZpUAcMQRuRWXJwDV5zz/UxxOSWy4nUiF +QGhXjVGSvsisq3L6lcbckYKieDCyoCt+ezLD7AWQBfxr0XCyuhajM7lSUuP1RwU MMdMxA6d1CTLYe08vWzLzligNXEAgE2SOme6GRUZQp6ZitR9MOGyidOhkjP+EQ83 O4jpToCcYLW1MmoC7IGDnBrZ95+n/Z95FChl0MAqWGEOY7jiQ3JaE1lV1oRdp7ff 5l9FNU5PJ2fXOIA3d1M3Tyw/JndCs1qC0rOSwRGH6ewPA+q6Ee6+9085nvva1QuK RwElnDiu+gI4lev6fax/dJqmnwK1KvyFJwM= =iEOD -----END PGP SIGNATURE----- --=-=-=--