shell-script goofy indentation

shell-script goofy indentation

[Dan Jacobson]

What's up with this goofy indentation in shell-script mode?
Hit TAB on each line.
#!/bin/sh
if mla
    then pla
else bla
fi

Re: shell-script goofy indentation

[Dan Jacobson]

rms> I tried it, and the indentation did not change.  Is that a bug?

Well shouldn't the then and the else be at the same indentation?

Wait, more challenges, hit TAB on each line (which shouldn't change
anything, as I have already hit TAB there)
if a
    then b
elif c
    then g
fi

The above makes more sense than the else case. However what really
"boils" me is when one hits TAB on the third line of
if e
    then h
     <----
the cursor is indeed now sitting right below the t of then,
but then enter the word else and hit TAB. It slides back to column 1.
Oh, I see, I have encountered different people's indenting styles and
not a bug. I see, I can do
(setq sh-indent-for-else sh-indent-for-then)
Looks good, but only on four-liners. OK, if I only write in the
multi-liner style, I won't feel as bad.

Re: shell-script goofy indentation

[Jari Aalto]

Dan Jacobson <jidanni@jidanni.org> writes:

| rms> I tried it, and the indentation did not change.  Is that a bug?
| 
| Well shouldn't the then and the else be at the same indentation?
| 
| Wait, more challenges, hit TAB on each line (which shouldn't change
| anything, as I have already hit TAB there)
| if a
|     then b
| elif c
|     then g
| fi

I think the sh-mode is programmed to expect constructs like this:

    if a ; then
        b
    elif c ; then
        g
    fi

Or like this for longish "a" and "c" conditions:

    if a
    then
        b
    elif c
    then
        g
    fi

Jari

Re: shell-script goofy indentation

[Stefan Monnier]

> (setq sh-indent-for-else sh-indent-for-then)

You want (setq sh-indent-for-then 0)
That's what I use anyway, so that I can write

       if foo
       then bar
       else baz
       fi

I always found the default value of sh-indent-for-then (i.e. `+') to be
at best unnatural.


        Stefan