bug#980: Bug? sit-for and obsolete syntax

bug#980: Bug? sit-for and obsolete syntax

[Christoph Conrad]

GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of
2008-05-03 on terranova, modified by Ubuntu

sit-for supports an obsolete call syntax with

(sit-for SECONDS &optional MILLISECONDS NODISP)

according to the doc string.

It checks:

  (when (or obsolete (numberp nodisp))
    (setq seconds (+ seconds (* 1e-3 nodisp)))
    (setq nodisp obsolete))

the first logical 'or' should be imho 'and'. Else obsolete could be
non-nil, but nodisp could be no number (e.g. nil), and that results in
an error when multiplying.

bug#980: Bug? sit-for and obsolete syntax

[martin rudalics]

 > GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of
 > 2008-05-03 on terranova, modified by Ubuntu
 >
 > sit-for supports an obsolete call syntax with
 >
 > (sit-for SECONDS &optional MILLISECONDS NODISP)
 >
 > according to the doc string.
 >
 > It checks:
 >
 >   (when (or obsolete (numberp nodisp))
 >     (setq seconds (+ seconds (* 1e-3 nodisp)))
 >     (setq nodisp obsolete))
 >
 > the first logical 'or' should be imho 'and'. Else obsolete could be
 > non-nil, but nodisp could be no number (e.g. nil), and that results in
 > an error when multiplying.

The definition of `sit-for' has been changed by Glenn as

	* subr.el (sit-for): Fix obsolete form for nil second argument.

on 2008-02-21.  I'm not sure whether that has fixed the problem you see,
so could you please verify by having a look at the current CVS version?

Thank you very much, martin.

bug#980: Bug? sit-for and obsolete syntax

[Christoph Conrad]

Hi Martin,

> 	* subr.el (sit-for): Fix obsolete form for nil second argument.

I checked the current CVS version by looking at the source of sit-for.
The obsolete handling looks correct now.

With kind regards,
Christoph

bug#980: marked as done (Bug? sit-for and obsolete syntax)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]


Your message dated Sun, 14 Sep 2008 15:08:26 -0400
with message-id <hkljxuczpx.fsf@fencepost.gnu.org>
and subject line Re: bug#980: Bug? sit-for and obsolete syntax
has caused the Emacs bug report #980,
regarding Bug? sit-for and obsolete syntax
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
980: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=980
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2875 bytes --]

From: Christoph Conrad <christoph.conrad@gmx.de>
To: bug-gnu-emacs@gnu.org
Subject: Bug? sit-for and obsolete syntax
Date: Sun, 14 Sep 2008 13:03:09 +0200
Message-ID: <87fxo32df6.fsf@ID-24456.user.uni-berlin.de>

GNU Emacs 22.1.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of
2008-05-03 on terranova, modified by Ubuntu

sit-for supports an obsolete call syntax with

(sit-for SECONDS &optional MILLISECONDS NODISP)

according to the doc string.

It checks:

  (when (or obsolete (numberp nodisp))
    (setq seconds (+ seconds (* 1e-3 nodisp)))
    (setq nodisp obsolete))

the first logical 'or' should be imho 'and'. Else obsolete could be
non-nil, but nodisp could be no number (e.g. nil), and that results in
an error when multiplying.




[-- Attachment #3: Type: message/rfc822, Size: 1790 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: Christoph Conrad <christoph.conrad@gmx.de>
Cc: 980-done@emacsbugs.donarmstrong.com, martin rudalics <rudalics@gmx.at>
Subject: Re: bug#980: Bug? sit-for and obsolete syntax
Date: Sun, 14 Sep 2008 15:08:26 -0400
Message-ID: <hkljxuczpx.fsf@fencepost.gnu.org>

Christoph Conrad wrote:

> I checked the current CVS version by looking at the source of sit-for.
> The obsolete handling looks correct now.

Yes, this is fixed in Emacs 22.2 and up.