unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yavor Doganov <yavor@gnu.org>
To: Glenn Morris <rgm@gnu.org>,
	1171@emacsbugs.donarmstrong.com,
	Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Adrian Robert <adrian.b.robert@gmail.com>
Subject: bug#1171: #1171 - ns-version-string - Emacs bug report logs
Date: Wed, 22 Oct 2008 13:53:17 +0300	[thread overview]
Message-ID: <87fxmozysi.GNU's_Not_Unix!%yavor@gnu.org> (raw)
In-Reply-To: <pcy70h60cu.fsf@fencepost.gnu.org>

Glenn Morris wrote:
> 
> If there is a meaningful version number for the external GNUstep/Mac
> components (analogous to gtk-version-string) against which Emacs was
> built, that could also be printed.

For GNUstep, that would be the Base and GUI versions.  Ideally, the
GSBackend should also be detected and reported, but that's more
complicated as it has to happen at runtime.

For Mac OS X I don't have a clue, really.

The attached patch works for me, although it might not be entirely
correct.


2008-10-22  Yavor Doganov  <yavor@gnu.org>  (tiny change)

	* nsterm.m (syms_of_nsterm): Provide GNUstep Base/GUI versions as
	`ns-version-string'.


--- nsterm.m	21 окт 2008 15:50:42 +0300	1.32
+++ nsterm.m	22 окт 2008 13:17:21 +0300	
@@ -6382,7 +6382,22 @@
   /* TODO: try to move this back into lisp,  ns-win.el loaded too late
            right now */
   {
-    Lisp_Object args[3] = { intern ("ns-version-string"), build_string ("9.0"),
+#ifdef NS_IMPL_GNUSTEP
+  char gnustep_version[40];
+  snprintf (gnustep_version, sizeof (gnustep_version),
+	    "(GNUstep Base %u.%u.%u, GUI %u.%u.%u)",
+	    GNUSTEP_BASE_MAJOR_VERSION, GNUSTEP_BASE_MINOR_VERSION,
+	    GNUSTEP_BASE_SUBMINOR_VERSION,
+	    GNUSTEP_GUI_MAJOR_VERSION, GNUSTEP_GUI_MINOR_VERSION,
+	    GNUSTEP_GUI_SUBMINOR_VERSION);
+#endif
+    Lisp_Object args[3] = { intern ("ns-version-string"),
+#ifdef NS_IMPL_GNUSTEP
+			    build_string (gnustep_version),
+#else
+			    /* TODO: Something appropriate for Mac OS X.  */
+			    build_string ("9.0"),
+#endif
                     build_string ("NS Window system port version number.") };
     Fdefconst (Flist (3, args));
   }






  reply	other threads:[~2008-10-22 10:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 13:31 bug#1171: #1171 - ns-version-string - Emacs bug report logs Adrian Robert
2008-10-21 15:52 ` Stefan Monnier
2008-10-21 22:37   ` Glenn Morris
2008-10-22 10:53     ` Yavor Doganov [this message]
2008-10-22 12:29       ` Adrian Robert
2008-10-22 13:14       ` Adrian Robert
2008-10-22 17:05         ` Glenn Morris
2008-10-22 21:11         ` Yavor Doganov
2008-10-22 22:43           ` Adrian Robert
2008-10-22 23:20             ` Yavor Doganov
2008-10-23  1:16             ` Stefan Monnier
2008-11-12 13:34               ` Yavor Doganov
2008-11-12 16:01                 ` Stefan Monnier
2008-11-12 19:11                   ` Yavor Doganov
2008-11-12 19:19                     ` Adrian Robert
2008-11-12 19:48                     ` Stefan Monnier
2008-12-11 23:46                       ` bug#1171: ns-version-string Glenn Morris
2008-12-31 15:03                         ` Adrian Robert
2008-10-23  1:02           ` bug#1171: #1171 - ns-version-string - Emacs bug report logs Glenn Morris
2008-10-23  0:48         ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87fxmozysi.GNU'\''s_Not_Unix'\!'%yavor@gnu.org' \
    --to=yavor@gnu.org \
    --cc=1171@emacsbugs.donarmstrong.com \
    --cc=adrian.b.robert@gmail.com \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).