* bug#1233: rcirc fill-region bugfix
@ 2008-10-23 15:10 Jeff Makey
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Makey @ 2008-10-23 15:10 UTC (permalink / raw)
To: bug-gnu-emacs
When a message begins with a very long word (typically a URL), rcirc
in Emacs 22 inserts a useless newline like this:
08:10 <SaintNick>
http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
has this month's archives
The patch below excludes the timestamp and nick from the beginning of
the filled region, which will cause such a line to be shown in this
more compact format:
08:10 <SaintNick> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
has this month's archives
-----------------------------------------------------------------
--- rcirc.el.orig 2008-02-10 06:03:53 -0800
+++ rcirc.el 2008-10-08 23:33:57 -0700
@@ -1251,7 +1251,7 @@
(rcirc-fill-column
rcirc-fill-column)
(t fill-column))))
- (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
+ (fill-region text-start rcirc-prompt-start-marker 'left t)))))
;; set inserted text to be read-only
(when rcirc-read-only-flag
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#1233: rcirc fill-region bugfix
@ 2008-10-23 22:04 Chong Yidong
2008-10-28 3:06 ` Ryan Yeske
0 siblings, 1 reply; 3+ messages in thread
From: Chong Yidong @ 2008-10-23 22:04 UTC (permalink / raw)
To: Ryan Yeske; +Cc: 1233
Hi Ryan,
Could you review this patch?
Jeff Makey <jeff@sdsc.edu> wrote:
> When a message begins with a very long word (typically a URL), rcirc
> in Emacs 22 inserts a useless newline like this:
>
> 08:10 <SaintNick>
> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
> has this month's archives
>
> The patch below excludes the timestamp and nick from the beginning of
> the filled region, which will cause such a line to be shown in this
> more compact format:
>
> 08:10 <SaintNick> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
> has this month's archives
--- rcirc.el.orig 2008-02-10 06:03:53 -0800
+++ rcirc.el 2008-10-08 23:33:57 -0700
@@ -1251,7 +1251,7 @@
(rcirc-fill-column
rcirc-fill-column)
(t fill-column))))
- (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
+ (fill-region text-start rcirc-prompt-start-marker 'left t)))))
;; set inserted text to be read-only
(when rcirc-read-only-flag
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#1233: rcirc fill-region bugfix
2008-10-23 22:04 bug#1233: rcirc fill-region bugfix Chong Yidong
@ 2008-10-28 3:06 ` Ryan Yeske
0 siblings, 0 replies; 3+ messages in thread
From: Ryan Yeske @ 2008-10-28 3:06 UTC (permalink / raw)
To: Chong Yidong; +Cc: Ryan Yeske, 1233
Chong Yidong <cyd@stupidchicken.com> writes:
> Hi Ryan,
>
> Could you review this patch?
It looks good to me. Thanks for the patch, Jeff.
The way filling is handled in the CVS trunk has been reworked, and it
includes a fix along these lines already.
Ryan
> Jeff Makey <jeff@sdsc.edu> wrote:
>
>> When a message begins with a very long word (typically a URL), rcirc
>> in Emacs 22 inserts a useless newline like this:
>>
>> 08:10 <SaintNick>
>> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>> has this month's archives
>>
>> The patch below excludes the timestamp and nick from the beginning of
>> the filled region, which will cause such a line to be shown in this
>> more compact format:
>>
>> 08:10 <SaintNick> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>> has this month's archives
>
>
> --- rcirc.el.orig 2008-02-10 06:03:53 -0800
> +++ rcirc.el 2008-10-08 23:33:57 -0700
> @@ -1251,7 +1251,7 @@
> (rcirc-fill-column
> rcirc-fill-column)
> (t fill-column))))
> - (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
> + (fill-region text-start rcirc-prompt-start-marker 'left t)))))
>
> ;; set inserted text to be read-only
> (when rcirc-read-only-flag
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-28 3:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-23 22:04 bug#1233: rcirc fill-region bugfix Chong Yidong
2008-10-28 3:06 ` Ryan Yeske
-- strict thread matches above, loose matches on Subject: below --
2008-10-23 15:10 Jeff Makey
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).