unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Stefan Monnier  <monnier@iro.umontreal.ca>
Cc: Eli Barzilay <eli@barzilay.org>, 4219@emacsbugs.donarmstrong.com
Subject: bug#4219: 23.1; case insensitive + partial completions
Date: Fri, 11 Sep 2009 21:23:20 -0400	[thread overview]
Message-ID: <87fxatq7lj.fsf@stupidchicken.com> (raw)

> Start with a default Emacs, and
>
>   (setq read-file-name-completion-ignore-case t)
>   (setq completion-styles '(partial-completion))
>
> Now go to a directory that has two files called
>
>   INSTALL
>   install-sh
>
> Hit `C-x C-f ins TAB' -- it will be completed to "insTALL".

Stefan, could you take a look at this?  I glanced through your partial
completion code, and it's clear where the problem arises.  In
completion-pcm--merge-try,

  (completion-pcm--merge-completions all pattern)

returns

  (all "TALL" "ins")

and so completion-pcm--pattern->string naively joins the result into
"insTALL".  However, I don't know how to fix this.  The default
completion style actually does the right thing, because it can just
replace the string wholesale, but I'm not sure if the pcm style can do
the same thing.





             reply	other threads:[~2009-09-12  1:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-12  1:23 Chong Yidong [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-08-21  2:49 bug#4219: 23.1; case insensitive + partial completions Eli Barzilay
2009-09-14  3:35 ` Stefan Monnier
2009-09-14  5:55   ` Eli Barzilay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fxatq7lj.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=4219@emacsbugs.donarmstrong.com \
    --cc=eli@barzilay.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).