unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: bug-gnu-emacs@gnu.org
Subject: bug#6881: 23.2; bookmark-bmenu-search makes menu disappear
Date: Thu, 19 Aug 2010 11:22:08 +0200	[thread overview]
Message-ID: <87fwybq7nj.fsf@tux.homenetwork> (raw)
In-Reply-To: <m1aaojdcmh.fsf@cam.ac.uk>

Leo <sdl.web@gmail.com> writes:

> This is a bug in read-key.

read-key should not echo the command in minibuffer.

> It appears using read-char solve this problem and the key echoing one.

Note that if read-char is used in `bookmark-read-search-input'
`inhibit-quit' need to be set to t, as read-char is not aware of C-g
like read-key.
It is safe to use inhibit-quit in bookmark-read-search-input, i use it
without problems since months in bookmark-extensions.el (with
read-char).
An alternative to read-char is to use most of the time read-char and
when read-char fail use read-event instead:

(defun ioccur-read-char-or-event (prompt)
  "Replace `read-key' when not available using PROMPT."
  (if (fboundp 'read-key)
      (read-key prompt)
->      (let* ((chr (condition-case nil (read-char prompt) (error nil)))
->             (evt (unless chr (read-event prompt))))
->        (or chr evt))))


-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 






  reply	other threads:[~2010-08-19  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 18:00 bug#6881: 23.2; bookmark-bmenu-search makes menu disappear Leo
2010-08-19  7:10 ` Leo
2010-08-19  9:22   ` Thierry Volpiatto [this message]
2010-08-19 14:47   ` Stefan Monnier
2010-08-19 15:21     ` Leo
2010-08-19 15:30     ` Thierry Volpiatto
2010-08-19 21:37     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwybq7nj.fsf@tux.homenetwork \
    --to=thierry.volpiatto@gmail.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).